summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKasper Nilsson <kaspern@google.com>2018-09-26 10:25:27 -0700
committerKasper Nilsson <kaspern@google.com>2018-09-26 10:28:47 -0700
commit4fa21ada22faf1c8a60832245bde5e8dab53bc23 (patch)
tree63f2f0ca22ae8a4a98a315a3836642f4cb3a56c5
parent3a73e35dae06c47cfc13a8bef8205dd39ca93306 (diff)
Add hyperlink to draft comments banner
Some users were not able to find the closed changes with draft comments referred to by the banner. This change adds a "view all" link to the query for all closed changes with draft comments to provide additional context to the user. Bug: Issue 9771 Change-Id: I61ebb7e50558b487afb8729ba2a4b8da8cef579b
-rw-r--r--polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.html1
-rw-r--r--polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.js4
2 files changed, 5 insertions, 0 deletions
diff --git a/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.html b/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.html
index 7e56deb903..af320e2b49 100644
--- a/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.html
+++ b/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.html
@@ -68,6 +68,7 @@ limitations under the License.
<div class$="banner [[_computeBannerClass(_showDraftsBanner)]]">
<div>
You have draft comments on closed changes.
+ <a href$="[[_computeDraftsLink(_showDraftsBanner)]]" target="_blank">(view all)</a>
</div>
<div>
<gr-button
diff --git a/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.js b/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.js
index 73669db928..8aa7084ba4 100644
--- a/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.js
+++ b/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.js
@@ -244,5 +244,9 @@
_closeConfirmDeleteOverlay() {
this.$.confirmDeleteOverlay.close();
},
+
+ _computeDraftsLink() {
+ return Gerrit.Nav.getUrlForSearchQuery('has:draft -is:open');
+ },
});
})();