summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEdwin Kempin <ekempin@google.com>2018-10-17 10:13:29 +0200
committerEdwin Kempin <ekempin@google.com>2018-10-17 10:13:29 +0200
commit55021e7e333a650524aac97ab6762bccbb33940c (patch)
treea144e341ed307671789d68b85e8db49fe7ed7b81
parent950ce2633dac0cf57a107fe6b0a75039391f5929 (diff)
RevisionIT.cherryPick: Assert WIP flag on target change, not on source change
Change-Id: I77d47c8c6f8311f3845f43cdd0589be84743ac7c Signed-off-by: Edwin Kempin <ekempin@google.com>
-rw-r--r--gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/api/revision/RevisionIT.java7
1 files changed, 4 insertions, 3 deletions
diff --git a/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/api/revision/RevisionIT.java b/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/api/revision/RevisionIT.java
index 0b3815eef5..e38958c941 100644
--- a/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/api/revision/RevisionIT.java
+++ b/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/api/revision/RevisionIT.java
@@ -315,7 +315,6 @@ public class RevisionIT extends AbstractDaemonTest {
ChangeInfo changeInfoWithDetails =
gApi.changes().id(project.get() + "~master~" + r.getChangeId()).get();
- assertThat(changeInfoWithDetails.workInProgress).isNull();
Collection<ChangeMessageInfo> messages = changeInfoWithDetails.messages;
assertThat(messages).hasSize(2);
@@ -330,8 +329,10 @@ public class RevisionIT extends AbstractDaemonTest {
origIt.next();
assertThat(origIt.next().message).isEqualTo(expectedMessage);
- assertThat(cherry.get().messages).hasSize(1);
- Iterator<ChangeMessageInfo> cherryIt = cherry.get().messages.iterator();
+ ChangeInfo cherryPickChangeInfoWithDetails = cherry.get();
+ assertThat(cherryPickChangeInfoWithDetails.workInProgress).isNull();
+ assertThat(cherryPickChangeInfoWithDetails.messages).hasSize(1);
+ Iterator<ChangeMessageInfo> cherryIt = cherryPickChangeInfoWithDetails.messages.iterator();
expectedMessage = "Patch Set 1: Cherry Picked from branch master.";
assertThat(cherryIt.next().message).isEqualTo(expectedMessage);