diff options
author | Sven Selberg <svense@axis.com> | 2018-10-17 11:24:05 +0200 |
---|---|---|
committer | Sven Selberg <svense@axis.com> | 2018-10-17 11:55:13 +0200 |
commit | ca587135321311624ee9aca3fb09caa2efd3d7e8 (patch) | |
tree | 7df24f962df7a6599398ef8c2087985e4e554350 | |
parent | 950ce2633dac0cf57a107fe6b0a75039391f5929 (diff) |
ReviewCommand: Let PostReview handle notifyhandling
In ea3e3b7 - "Downgrade default notify for WIP reviews" default
notify handling for reviews of changes in WIP state was fixed in
PostReviews.
However ReviewCommand explicitly sets notify to ALL if notify wasn't
specified in the call which circumvents the default notify logic
in PostReviews.
Use the default notify handling in PostReviews for calls to the
"review" ssh command if notify isn't specifed in the call.
Bug: Issue 9880
Change-Id: I63a8b4ce32835055aa7ab5f7a1ca531d9b648ee8
-rw-r--r-- | gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ReviewCommand.java | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ReviewCommand.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ReviewCommand.java index a6dd0b1bd4..a9899b5b09 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ReviewCommand.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ReviewCommand.java @@ -252,9 +252,6 @@ public class ReviewCommand extends SshCommand { } private void reviewPatchSet(PatchSet patchSet) throws Exception { - if (notify == null) { - notify = NotifyHandling.ALL; - } ReviewInput review = new ReviewInput(); review.message = Strings.emptyToNull(changeComment); |