summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid Ostrovsky <david@ostrovsky.org>2018-11-27 06:42:47 +0100
committerDavid Ostrovsky <david@ostrovsky.org>2021-02-09 19:56:32 +0100
commit1965e0b3dd5c843369833ce530fa92089a755491 (patch)
treec5e5799d48cc40d0a47b115cde3d4b65a9a8a76b
parentfce488d7dc45396dae3bde6011e3c296ce7f1357 (diff)
Use NoteDb sequence seed for accounts sequence initialization
NoteDb sequence seed is already used in Sequences class. Consistently use it also in SequencesOnInit and avoid using the ReviewDb for that. Changes in Schema_155 class were reverted because ReviewDb must still be used during migration of accounts from ReviewDb to NoteDb. Change-Id: I75ac27dae90ec9be0efe017f73c798d3ccd0ad04
-rw-r--r--java/com/google/gerrit/pgm/init/InitAdminUser.java2
-rw-r--r--java/com/google/gerrit/pgm/init/api/SequencesOnInit.java6
2 files changed, 3 insertions, 5 deletions
diff --git a/java/com/google/gerrit/pgm/init/InitAdminUser.java b/java/com/google/gerrit/pgm/init/InitAdminUser.java
index f4289e776a..64827fe003 100644
--- a/java/com/google/gerrit/pgm/init/InitAdminUser.java
+++ b/java/com/google/gerrit/pgm/init/InitAdminUser.java
@@ -111,7 +111,7 @@ public class InitAdminUser implements InitStep {
if (!accounts.hasAnyAccount()) {
ui.header("Gerrit Administrator");
if (ui.yesno(true, "Create administrator user")) {
- Account.Id id = new Account.Id(sequencesOnInit.nextAccountId(db));
+ Account.Id id = new Account.Id(sequencesOnInit.nextAccountId());
String username = ui.readString("admin", "username");
String name = ui.readString("Administrator", "name");
String httpPassword = ui.readString("secret", "HTTP password");
diff --git a/java/com/google/gerrit/pgm/init/api/SequencesOnInit.java b/java/com/google/gerrit/pgm/init/api/SequencesOnInit.java
index c9c3a64c27..1716a3cd57 100644
--- a/java/com/google/gerrit/pgm/init/api/SequencesOnInit.java
+++ b/java/com/google/gerrit/pgm/init/api/SequencesOnInit.java
@@ -35,16 +35,14 @@ public class SequencesOnInit {
this.allUsersName = allUsersName;
}
- public int nextAccountId(ReviewDb db) throws OrmException {
- @SuppressWarnings("deprecation")
- RepoSequence.Seed accountSeed = db::nextAccountId;
+ public int nextAccountId() throws OrmException {
RepoSequence accountSeq =
new RepoSequence(
repoManager,
GitReferenceUpdated.DISABLED,
new Project.NameKey(allUsersName.get()),
Sequences.NAME_ACCOUNTS,
- accountSeed,
+ () -> ReviewDb.FIRST_ACCOUNT_ID,
1);
return accountSeq.next();
}