diff options
author | David Pursehouse <dpursehouse@collab.net> | 2019-03-14 09:01:59 +0900 |
---|---|---|
committer | David Pursehouse <dpursehouse@collab.net> | 2019-03-14 09:08:30 +0900 |
commit | 7a519876e5eaec14a86d091962a767054530709e (patch) | |
tree | fe099a465a92f6ae30156703d13cfa9c564c454f | |
parent | fed5a852ffc4e21df6673715ac8febb52dd578d8 (diff) | |
parent | 70c569da872934815f43cb16db8286d14b6b2dfa (diff) |
Merge branch 'stable-2.15' into stable-2.16
* stable-2.15:
Upgrade google-java-format to 1.7
Change-Id: Ia7383822ef59fb60bb5559956a065ae46b2e4f4a
149 files changed, 224 insertions, 603 deletions
diff --git a/Documentation/dev-contributing.txt b/Documentation/dev-contributing.txt index 561f0b47f7..e3ab7ce360 100644 --- a/Documentation/dev-contributing.txt +++ b/Documentation/dev-contributing.txt @@ -164,7 +164,7 @@ Guide]. To format Java source code, Gerrit uses the link:https://github.com/google/google-java-format[`google-java-format`] -tool (version 1.6), and to format Bazel BUILD, WORKSPACE and .bzl files the +tool (version 1.7), and to format Bazel BUILD, WORKSPACE and .bzl files the link:https://github.com/bazelbuild/buildtools/tree/master/buildifier[`buildifier`] tool (version 0.20.0). These tools automatically apply format according to the style guides; this diff --git a/Documentation/dev-eclipse.txt b/Documentation/dev-eclipse.txt index 0f23db5201..c335a2d086 100644 --- a/Documentation/dev-eclipse.txt +++ b/Documentation/dev-eclipse.txt @@ -68,7 +68,7 @@ Java 8 is still the default: To format source code, Gerrit uses the link:https://github.com/google/google-java-format[`google-java-format`] -tool (version 1.3), which automatically formats code to follow the +tool (version 1.7), which automatically formats code to follow the style guide. See link:dev-contributing.html#style[Code Style] for the instruction how to set up command line tool that uses this formatter. The Eclipse plugin is provided that allows to format with the same diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Labels.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Labels.java index 801a9274f2..267a983ebc 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Labels.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Labels.java @@ -140,8 +140,7 @@ class Labels extends Grid { void set(ChangeInfo info) { List<String> names = - info.labels() - .stream() + info.labels().stream() .sorted() .collect(collectingAndThen(toList(), Collections::unmodifiableList)); Set<Integer> removable = info.removableReviewerIds(); diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ReplyBox.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ReplyBox.java index 8a1a2d5367..addd692306 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ReplyBox.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ReplyBox.java @@ -126,9 +126,7 @@ public class ReplyBox extends Composite { initWidget(uiBinder.createAndBindUi(this)); List<String> names = - permitted - .keySet() - .stream() + permitted.keySet().stream() .sorted() .collect(collectingAndThen(toList(), Collections::unmodifiableList)); if (names.isEmpty()) { @@ -446,8 +444,7 @@ public class ReplyBox extends Composite { } List<String> paths = - m.keySet() - .stream() + m.keySet().stream() .sorted() .collect(collectingAndThen(toList(), Collections::unmodifiableList)); diff --git a/java/com/google/gerrit/acceptance/AbstractNotificationTest.java b/java/com/google/gerrit/acceptance/AbstractNotificationTest.java index 7a30f0cd8f..c33bb7a16b 100644 --- a/java/com/google/gerrit/acceptance/AbstractNotificationTest.java +++ b/java/com/google/gerrit/acceptance/AbstractNotificationTest.java @@ -116,9 +116,7 @@ public abstract class AbstractNotificationTest extends AbstractDaemonTest { recipients.put(CC, parseAddresses(message, "Cc")); recipients.put( BCC, - message - .rcpt() - .stream() + message.rcpt().stream() .map(Address::getEmail) .filter(e -> !recipients.get(TO).contains(e) && !recipients.get(CC).contains(e)) .collect(toList())); diff --git a/java/com/google/gerrit/acceptance/HttpResponse.java b/java/com/google/gerrit/acceptance/HttpResponse.java index 8132c32d05..88079a4046 100644 --- a/java/com/google/gerrit/acceptance/HttpResponse.java +++ b/java/com/google/gerrit/acceptance/HttpResponse.java @@ -65,8 +65,7 @@ public class HttpResponse { } public ImmutableList<String> getHeaders(String name) { - return Arrays.asList(response.getHeaders(name)) - .stream() + return Arrays.asList(response.getHeaders(name)).stream() .map(Header::getValue) .collect(toImmutableList()); } diff --git a/java/com/google/gerrit/acceptance/ProjectResetter.java b/java/com/google/gerrit/acceptance/ProjectResetter.java index 7d0a59c164..cc263c68b6 100644 --- a/java/com/google/gerrit/acceptance/ProjectResetter.java +++ b/java/com/google/gerrit/acceptance/ProjectResetter.java @@ -260,9 +260,7 @@ public class ProjectResetter implements AutoCloseable { refsPatternByProject.asMap().entrySet()) { try (Repository repo = repoManager.openRepository(e.getKey())) { Collection<Ref> nonRestoredRefs = - repo.getRefDatabase() - .getRefs() - .stream() + repo.getRefDatabase().getRefs().stream() .filter( r -> !keptRefsByProject.containsEntry(e.getKey(), r.getName()) @@ -315,9 +313,7 @@ public class ProjectResetter implements AutoCloseable { private Set<Project.NameKey> projectsWithConfigChanges( Multimap<Project.NameKey, String> projects) { - return projects - .entries() - .stream() + return projects.entries().stream() .filter(e -> e.getValue().equals(RefNames.REFS_CONFIG)) .map(Map.Entry::getKey) .collect(toSet()); diff --git a/java/com/google/gerrit/acceptance/ReindexProjectsAtStartup.java b/java/com/google/gerrit/acceptance/ReindexProjectsAtStartup.java index 4893efa279..f585f81810 100644 --- a/java/com/google/gerrit/acceptance/ReindexProjectsAtStartup.java +++ b/java/com/google/gerrit/acceptance/ReindexProjectsAtStartup.java @@ -42,9 +42,7 @@ public class ReindexProjectsAtStartup implements LifecycleListener { @Override public void start() { - repoMgr - .list() - .stream() + repoMgr.list().stream() .forEach( projectName -> { try { diff --git a/java/com/google/gerrit/elasticsearch/ElasticIndexVersionDiscovery.java b/java/com/google/gerrit/elasticsearch/ElasticIndexVersionDiscovery.java index a777f470d7..100022a181 100644 --- a/java/com/google/gerrit/elasticsearch/ElasticIndexVersionDiscovery.java +++ b/java/com/google/gerrit/elasticsearch/ElasticIndexVersionDiscovery.java @@ -54,11 +54,8 @@ class ElasticIndexVersionDiscovery { } return new JsonParser() - .parse(AbstractElasticIndex.getContent(response)) - .getAsJsonObject() - .entrySet() - .stream() - .map(e -> e.getKey().replace(name, "")) - .collect(toList()); + .parse(AbstractElasticIndex.getContent(response)).getAsJsonObject().entrySet().stream() + .map(e -> e.getKey().replace(name, "")) + .collect(toList()); } } diff --git a/java/com/google/gerrit/extensions/registration/DynamicSet.java b/java/com/google/gerrit/extensions/registration/DynamicSet.java index dcd0d8f1b0..8c2e566b3d 100644 --- a/java/com/google/gerrit/extensions/registration/DynamicSet.java +++ b/java/com/google/gerrit/extensions/registration/DynamicSet.java @@ -226,8 +226,7 @@ public class DynamicSet<T> implements Iterable<T> { * @return sorted set of active plugins that supply at least one item. */ public ImmutableSortedSet<String> plugins() { - return items - .stream() + return items.stream() .map(i -> i.get().getPluginName()) .collect(toImmutableSortedSet(naturalOrder())); } @@ -239,8 +238,7 @@ public class DynamicSet<T> implements Iterable<T> { * @return items exported by a plugin. */ public ImmutableSet<Provider<T>> byPlugin(String pluginName) { - return items - .stream() + return items.stream() .filter(i -> i.get().getPluginName().equals(pluginName)) .map(i -> i.get().getProvider()) .collect(toImmutableSet()); diff --git a/java/com/google/gerrit/index/project/ProjectField.java b/java/com/google/gerrit/index/project/ProjectField.java index 5e484b22bc..3bc028d1b8 100644 --- a/java/com/google/gerrit/index/project/ProjectField.java +++ b/java/com/google/gerrit/index/project/ProjectField.java @@ -61,9 +61,7 @@ public class ProjectField { storedOnly("ref_state") .buildRepeatable( projectData -> - projectData - .tree() - .stream() + projectData.tree().stream() .filter(p -> p.getProject().getConfigRefState() != null) .map(p -> toRefState(p.getProject())) .collect(toImmutableList())); diff --git a/java/com/google/gerrit/index/query/QueryProcessor.java b/java/com/google/gerrit/index/query/QueryProcessor.java index 081575b631..64d8742ab1 100644 --- a/java/com/google/gerrit/index/query/QueryProcessor.java +++ b/java/com/google/gerrit/index/query/QueryProcessor.java @@ -373,8 +373,7 @@ public abstract class QueryProcessor<T> { } private static Optional<QueryParseException> findQueryParseException(Throwable t) { - return Throwables.getCausalChain(t) - .stream() + return Throwables.getCausalChain(t).stream() .filter(c -> c instanceof QueryParseException) .map(QueryParseException.class::cast) .findFirst(); diff --git a/java/com/google/gerrit/launcher/GerritLauncher.java b/java/com/google/gerrit/launcher/GerritLauncher.java index 5406d52a87..e407d08870 100644 --- a/java/com/google/gerrit/launcher/GerritLauncher.java +++ b/java/com/google/gerrit/launcher/GerritLauncher.java @@ -626,9 +626,7 @@ public final class GerritLauncher { * @return true if any thread has a stack frame in {@code org.eclipse.jdt}. */ public static boolean isRunningInEclipse() { - return Thread.getAllStackTraces() - .values() - .stream() + return Thread.getAllStackTraces().values().stream() .flatMap(Arrays::stream) .anyMatch(e -> e.getClassName().startsWith("org.eclipse.jdt.")); } diff --git a/java/com/google/gerrit/lucene/LuceneChangeIndex.java b/java/com/google/gerrit/lucene/LuceneChangeIndex.java index 66db468c98..9944c8a15f 100644 --- a/java/com/google/gerrit/lucene/LuceneChangeIndex.java +++ b/java/com/google/gerrit/lucene/LuceneChangeIndex.java @@ -655,8 +655,7 @@ public class LuceneChangeIndex implements ChangeIndex { } private static List<byte[]> copyAsBytes(Collection<IndexableField> fields) { - return fields - .stream() + return fields.stream() .map( f -> { BytesRef ref = f.binaryValue(); diff --git a/java/com/google/gerrit/mail/HtmlParser.java b/java/com/google/gerrit/mail/HtmlParser.java index 98215997a1..265c4122de 100644 --- a/java/com/google/gerrit/mail/HtmlParser.java +++ b/java/com/google/gerrit/mail/HtmlParser.java @@ -78,8 +78,7 @@ public class HtmlParser { for (Element e : d.body().getAllElements()) { String elementName = e.tagName(); boolean isInBlockQuote = - e.parents() - .stream() + e.parents().stream() .anyMatch( p -> p.tagName().equals("blockquote") diff --git a/java/com/google/gerrit/mail/RawMailParser.java b/java/com/google/gerrit/mail/RawMailParser.java index 00754d3c32..b7e2030b2b 100644 --- a/java/com/google/gerrit/mail/RawMailParser.java +++ b/java/com/google/gerrit/mail/RawMailParser.java @@ -85,10 +85,7 @@ public class RawMailParser { } // Add additional headers - mimeMessage - .getHeader() - .getFields() - .stream() + mimeMessage.getHeader().getFields().stream() .filter(f -> !MAIN_HEADERS.contains(f.getName().toLowerCase())) .forEach(f -> messageBuilder.addAdditionalHeader(f.getName() + ": " + f.getBody())); diff --git a/java/com/google/gerrit/pgm/init/InitLogging.java b/java/com/google/gerrit/pgm/init/InitLogging.java index 52d0d2f99d..b6d25bc4bc 100644 --- a/java/com/google/gerrit/pgm/init/InitLogging.java +++ b/java/com/google/gerrit/pgm/init/InitLogging.java @@ -53,8 +53,7 @@ public class InitLogging implements InitStep { } private static boolean isSet(List<String> javaOptions, String javaOptionName) { - return javaOptions - .stream() + return javaOptions.stream() .anyMatch( o -> o.startsWith("-D" + javaOptionName + "=") diff --git a/java/com/google/gerrit/server/CommentsUtil.java b/java/com/google/gerrit/server/CommentsUtil.java index 99dfbbb1a2..d72d73afb6 100644 --- a/java/com/google/gerrit/server/CommentsUtil.java +++ b/java/com/google/gerrit/server/CommentsUtil.java @@ -221,8 +221,7 @@ public class CommentsUtil { } return c; } - return draftByChangeAuthor(db, notes, user.getAccountId()) - .stream() + return draftByChangeAuthor(db, notes, user.getAccountId()).stream() .filter(c -> key.equals(c.key)) .findFirst(); } diff --git a/java/com/google/gerrit/server/CreateGroupPermissionSyncer.java b/java/com/google/gerrit/server/CreateGroupPermissionSyncer.java index ee0138c53f..cd7cd47bba 100644 --- a/java/com/google/gerrit/server/CreateGroupPermissionSyncer.java +++ b/java/com/google/gerrit/server/CreateGroupPermissionSyncer.java @@ -107,9 +107,7 @@ public class CreateGroupPermissionSyncer implements ChangeMergedListener { config.getAccessSection(RefNames.REFS_GROUPS + "*", true); if (createGroupsGlobal.isEmpty()) { createGroupAccessSection.setPermissions( - createGroupAccessSection - .getPermissions() - .stream() + createGroupAccessSection.getPermissions().stream() .filter(p -> !Permission.CREATE.equals(p.getName())) .collect(toList())); config.replace(createGroupAccessSection); diff --git a/java/com/google/gerrit/server/ModuleOverloader.java b/java/com/google/gerrit/server/ModuleOverloader.java index 7083e6d743..9a8fe845d2 100644 --- a/java/com/google/gerrit/server/ModuleOverloader.java +++ b/java/com/google/gerrit/server/ModuleOverloader.java @@ -27,8 +27,7 @@ public class ModuleOverloader { // group candidates by annotation existence Map<Boolean, List<Module>> grouped = - overrideCandidates - .stream() + overrideCandidates.stream() .collect( Collectors.groupingBy(m -> m.getClass().getAnnotation(ModuleImpl.class) != null)); @@ -44,16 +43,14 @@ public class ModuleOverloader { } // swipe cache implementation with alternative provided in lib - return modules - .stream() + return modules.stream() .map( m -> { ModuleImpl a = m.getClass().getAnnotation(ModuleImpl.class); if (a == null) { return m; } - return overrides - .stream() + return overrides.stream() .filter( o -> o.getClass() diff --git a/java/com/google/gerrit/server/StarredChangesUtil.java b/java/com/google/gerrit/server/StarredChangesUtil.java index 8fa5fafcad..4e349e6948 100644 --- a/java/com/google/gerrit/server/StarredChangesUtil.java +++ b/java/com/google/gerrit/server/StarredChangesUtil.java @@ -298,9 +298,7 @@ public class StarredChangesUtil { private static Set<String> getRefNames(Repository repo, String prefix) throws IOException { RefDatabase refDb = repo.getRefDatabase(); - return refDb - .getRefsByPrefix(prefix) - .stream() + return refDb.getRefsByPrefix(prefix).stream() .map(r -> r.getName().substring(prefix.length())) .collect(toSet()); } @@ -425,8 +423,7 @@ public class StarredChangesUtil { } public static Set<Integer> getStarredPatchSets(Set<String> labels, String label) { - return labels - .stream() + return labels.stream() .filter(l -> l.startsWith(label + "/")) .filter(l -> Ints.tryParse(l.substring(label.length() + 1)) != null) .map(l -> Integer.valueOf(l.substring(label.length() + 1))) diff --git a/java/com/google/gerrit/server/account/AccountControl.java b/java/com/google/gerrit/server/account/AccountControl.java index 3772b4e203..b43e786e6e 100644 --- a/java/com/google/gerrit/server/account/AccountControl.java +++ b/java/com/google/gerrit/server/account/AccountControl.java @@ -215,9 +215,7 @@ public class AccountControl { } private Set<AccountGroup.UUID> groupsOf(IdentifiedUser user) { - return user.getEffectiveGroups() - .getKnownGroups() - .stream() + return user.getEffectiveGroups().getKnownGroups().stream() .filter(a -> !SystemGroupBackend.isSystemGroup(a)) .collect(toSet()); } diff --git a/java/com/google/gerrit/server/account/AccountManager.java b/java/com/google/gerrit/server/account/AccountManager.java index 36b4b79f42..27945d1f07 100644 --- a/java/com/google/gerrit/server/account/AccountManager.java +++ b/java/com/google/gerrit/server/account/AccountManager.java @@ -456,8 +456,7 @@ public class AccountManager { } if (filteredExtIdsByScheme.size() > 1 - || !filteredExtIdsByScheme - .stream() + || !filteredExtIdsByScheme.stream() .anyMatch(e -> e.key().equals(who.getExternalIdKey()))) { u.deleteExternalIds(filteredExtIdsByScheme); } @@ -514,8 +513,7 @@ public class AccountManager { (a, u) -> { u.deleteExternalIds(extIds); if (a.getAccount().getPreferredEmail() != null - && extIds - .stream() + && extIds.stream() .anyMatch(e -> a.getAccount().getPreferredEmail().equals(e.email()))) { u.setPreferredEmail(null); } diff --git a/java/com/google/gerrit/server/account/AccountResolver.java b/java/com/google/gerrit/server/account/AccountResolver.java index 48bd1c1a8b..8c7cdb4dea 100644 --- a/java/com/google/gerrit/server/account/AccountResolver.java +++ b/java/com/google/gerrit/server/account/AccountResolver.java @@ -205,10 +205,7 @@ public class AccountResolver { // and pray we come up with a reasonable result list. // TODO(dborowitz): This doesn't match the documentation; consider whether it's possible to be // more strict here. - return accountQueryProvider - .get() - .byDefault(nameOrEmail) - .stream() + return accountQueryProvider.get().byDefault(nameOrEmail).stream() .map(a -> a.getAccount().getId()) .collect(toSet()); } diff --git a/java/com/google/gerrit/server/account/Accounts.java b/java/com/google/gerrit/server/account/Accounts.java index 1a61c02b6a..f3758bf2c4 100644 --- a/java/com/google/gerrit/server/account/Accounts.java +++ b/java/com/google/gerrit/server/account/Accounts.java @@ -140,9 +140,7 @@ public class Accounts { } public static Stream<Account.Id> readUserRefs(Repository repo) throws IOException { - return repo.getRefDatabase() - .getRefsByPrefix(RefNames.REFS_USERS) - .stream() + return repo.getRefDatabase().getRefsByPrefix(RefNames.REFS_USERS).stream() .map(r -> Account.Id.fromRef(r.getName())) .filter(Objects::nonNull); } diff --git a/java/com/google/gerrit/server/account/AccountsConsistencyChecker.java b/java/com/google/gerrit/server/account/AccountsConsistencyChecker.java index 0b63927fe5..6873f92f42 100644 --- a/java/com/google/gerrit/server/account/AccountsConsistencyChecker.java +++ b/java/com/google/gerrit/server/account/AccountsConsistencyChecker.java @@ -37,9 +37,7 @@ public class AccountsConsistencyChecker { for (AccountState accountState : accounts.all()) { Account account = accountState.getAccount(); if (account.getPreferredEmail() != null) { - if (!accountState - .getExternalIds() - .stream() + if (!accountState.getExternalIds().stream() .anyMatch(e -> account.getPreferredEmail().equals(e.email()))) { addError( String.format( diff --git a/java/com/google/gerrit/server/account/AccountsUpdate.java b/java/com/google/gerrit/server/account/AccountsUpdate.java index 1445dfdad9..0e3f379814 100644 --- a/java/com/google/gerrit/server/account/AccountsUpdate.java +++ b/java/com/google/gerrit/server/account/AccountsUpdate.java @@ -462,9 +462,7 @@ public class AccountsUpdate { } private static Set<Account.Id> getUpdatedAccounts(BatchRefUpdate batchRefUpdate) { - return batchRefUpdate - .getCommands() - .stream() + return batchRefUpdate.getCommands().stream() .map(c -> Account.Id.fromRef(c.getRefName())) .filter(Objects::nonNull) .collect(toSet()); diff --git a/java/com/google/gerrit/server/account/Emails.java b/java/com/google/gerrit/server/account/Emails.java index e91ce492f3..7c798ca7e4 100644 --- a/java/com/google/gerrit/server/account/Emails.java +++ b/java/com/google/gerrit/server/account/Emails.java @@ -85,10 +85,7 @@ public class Emails { public ImmutableSetMultimap<String, Account.Id> getAccountsFor(String... emails) throws IOException, OrmException { ImmutableSetMultimap.Builder<String, Account.Id> builder = ImmutableSetMultimap.builder(); - externalIds - .byEmails(emails) - .entries() - .stream() + externalIds.byEmails(emails).entries().stream() .forEach(e -> builder.put(e.getKey(), e.getValue().accountId())); executeIndexQuery(() -> queryProvider.get().byPreferredEmail(emails).entries().stream()) .forEach(e -> builder.put(e.getKey(), e.getValue().getAccount().getId())); diff --git a/java/com/google/gerrit/server/account/GroupIncludeCacheImpl.java b/java/com/google/gerrit/server/account/GroupIncludeCacheImpl.java index 58eaf21811..a089d9e216 100644 --- a/java/com/google/gerrit/server/account/GroupIncludeCacheImpl.java +++ b/java/com/google/gerrit/server/account/GroupIncludeCacheImpl.java @@ -154,10 +154,7 @@ public class GroupIncludeCacheImpl implements GroupIncludeCache { @Override public ImmutableSet<AccountGroup.UUID> load(Account.Id memberId) throws OrmException { try (TraceTimer timer = TraceContext.newTimer("Loading groups with member %s", memberId)) { - return groupQueryProvider - .get() - .byMember(memberId) - .stream() + return groupQueryProvider.get().byMember(memberId).stream() .map(InternalGroup::getGroupUUID) .collect(toImmutableSet()); } @@ -176,10 +173,7 @@ public class GroupIncludeCacheImpl implements GroupIncludeCache { @Override public ImmutableList<AccountGroup.UUID> load(AccountGroup.UUID key) throws OrmException { try (TraceTimer timer = TraceContext.newTimer("Loading parent groups of %s", key)) { - return groupQueryProvider - .get() - .bySubgroup(key) - .stream() + return groupQueryProvider.get().bySubgroup(key).stream() .map(InternalGroup::getGroupUUID) .collect(toImmutableList()); } diff --git a/java/com/google/gerrit/server/account/GroupMembers.java b/java/com/google/gerrit/server/account/GroupMembers.java index faa162177f..710f553e0f 100644 --- a/java/com/google/gerrit/server/account/GroupMembers.java +++ b/java/com/google/gerrit/server/account/GroupMembers.java @@ -127,9 +127,7 @@ public class GroupMembers { GroupControl groupControl = groupControlFactory.controlFor(new InternalGroupDescription(group)); Set<Account> directMembers = - group - .getMembers() - .stream() + group.getMembers().stream() .filter(groupControl::canSeeMember) .map(accountCache::get) .flatMap(Streams::stream) diff --git a/java/com/google/gerrit/server/account/ProjectWatches.java b/java/com/google/gerrit/server/account/ProjectWatches.java index cc913e536e..8b3e1b33bf 100644 --- a/java/com/google/gerrit/server/account/ProjectWatches.java +++ b/java/com/google/gerrit/server/account/ProjectWatches.java @@ -202,9 +202,7 @@ public class ProjectWatches { private static ImmutableMap<ProjectWatchKey, ImmutableSet<NotifyType>> immutableCopyOf( Map<ProjectWatchKey, Set<NotifyType>> projectWatches) { ImmutableMap.Builder<ProjectWatchKey, ImmutableSet<NotifyType>> b = ImmutableMap.builder(); - projectWatches - .entrySet() - .stream() + projectWatches.entrySet().stream() .forEach(e -> b.put(e.getKey(), ImmutableSet.copyOf(e.getValue()))); return b.build(); } diff --git a/java/com/google/gerrit/server/account/UniversalGroupBackend.java b/java/com/google/gerrit/server/account/UniversalGroupBackend.java index e7b3c91e82..50a5e9f842 100644 --- a/java/com/google/gerrit/server/account/UniversalGroupBackend.java +++ b/java/com/google/gerrit/server/account/UniversalGroupBackend.java @@ -218,8 +218,7 @@ public class UniversalGroupBackend implements GroupBackend { @Override public void check() throws StartupException { String invalid = - cfg.getSubsections("groups") - .stream() + cfg.getSubsections("groups").stream() .filter( sub -> { AccountGroup.UUID uuid = new AccountGroup.UUID(sub); diff --git a/java/com/google/gerrit/server/account/externalids/AllExternalIds.java b/java/com/google/gerrit/server/account/externalids/AllExternalIds.java index bb1ade753b..8b23f6c396 100644 --- a/java/com/google/gerrit/server/account/externalids/AllExternalIds.java +++ b/java/com/google/gerrit/server/account/externalids/AllExternalIds.java @@ -45,8 +45,7 @@ public abstract class AllExternalIds { private static ImmutableSetMultimap<String, ExternalId> byEmailCopy( Collection<ExternalId> externalIds) { - return externalIds - .stream() + return externalIds.stream() .filter(e -> !Strings.isNullOrEmpty(e.email())) .collect(toImmutableSetMultimap(e -> e.email(), e -> e)); } @@ -62,10 +61,7 @@ public abstract class AllExternalIds { public byte[] serialize(AllExternalIds object) { ObjectIdConverter idConverter = ObjectIdConverter.create(); AllExternalIdsProto.Builder allBuilder = AllExternalIdsProto.newBuilder(); - object - .byAccount() - .values() - .stream() + object.byAccount().values().stream() .map(extId -> toProto(idConverter, extId)) .forEach(allBuilder::addExternalId); return ProtoCacheSerializers.toByteArray(allBuilder.build()); @@ -92,8 +88,7 @@ public abstract class AllExternalIds { public AllExternalIds deserialize(byte[] in) { ObjectIdConverter idConverter = ObjectIdConverter.create(); return create( - ProtoCacheSerializers.parseUnchecked(AllExternalIdsProto.parser(), in) - .getExternalIdList() + ProtoCacheSerializers.parseUnchecked(AllExternalIdsProto.parser(), in).getExternalIdList() .stream() .map(proto -> toExternalId(idConverter, proto)) .collect(toList())); diff --git a/java/com/google/gerrit/server/account/externalids/ExternalId.java b/java/com/google/gerrit/server/account/externalids/ExternalId.java index 22a6ee49a3..c363b5bf03 100644 --- a/java/com/google/gerrit/server/account/externalids/ExternalId.java +++ b/java/com/google/gerrit/server/account/externalids/ExternalId.java @@ -82,8 +82,7 @@ public abstract class ExternalId implements Serializable { * ExternalId#SCHEME_USERNAME} scheme */ public static Optional<String> getUserName(Collection<ExternalId> extIds) { - return extIds - .stream() + return extIds.stream() .filter(e -> e.isScheme(SCHEME_USERNAME)) .map(e -> e.key().id()) .filter(u -> !Strings.isNullOrEmpty(u)) diff --git a/java/com/google/gerrit/server/account/externalids/ExternalIdNotes.java b/java/com/google/gerrit/server/account/externalids/ExternalIdNotes.java index 5acf63c4c9..76e7f81ad7 100644 --- a/java/com/google/gerrit/server/account/externalids/ExternalIdNotes.java +++ b/java/com/google/gerrit/server/account/externalids/ExternalIdNotes.java @@ -762,8 +762,7 @@ public class ExternalIdNotes extends VersionedMetaData { noteMapUpdates.clear(); if (!footers.isEmpty()) { commit.setMessage( - footers - .stream() + footers.stream() .sorted() .collect(joining("\n", commit.getMessage().trim() + "\n\n", ""))); } diff --git a/java/com/google/gerrit/server/account/externalids/ExternalIds.java b/java/com/google/gerrit/server/account/externalids/ExternalIds.java index b1a59b1ef3..9098630f02 100644 --- a/java/com/google/gerrit/server/account/externalids/ExternalIds.java +++ b/java/com/google/gerrit/server/account/externalids/ExternalIds.java @@ -71,8 +71,7 @@ public class ExternalIds { /** Returns the external IDs of the specified account that have the given scheme. */ public Set<ExternalId> byAccount(Account.Id accountId, String scheme) throws IOException { - return byAccount(accountId) - .stream() + return byAccount(accountId).stream() .filter(e -> e.key().isScheme(scheme)) .collect(toImmutableSet()); } @@ -85,8 +84,7 @@ public class ExternalIds { /** Returns the external IDs of the specified account that have the given scheme. */ public Set<ExternalId> byAccount(Account.Id accountId, String scheme, ObjectId rev) throws IOException { - return byAccount(accountId, rev) - .stream() + return byAccount(accountId, rev).stream() .filter(e -> e.key().isScheme(scheme)) .collect(toImmutableSet()); } diff --git a/java/com/google/gerrit/server/account/externalids/ExternalIdsConsistencyChecker.java b/java/com/google/gerrit/server/account/externalids/ExternalIdsConsistencyChecker.java index 14ead2fb50..fe7cc482b2 100644 --- a/java/com/google/gerrit/server/account/externalids/ExternalIdsConsistencyChecker.java +++ b/java/com/google/gerrit/server/account/externalids/ExternalIdsConsistencyChecker.java @@ -93,10 +93,7 @@ public class ExternalIdsConsistencyChecker { } } - emails - .asMap() - .entrySet() - .stream() + emails.asMap().entrySet().stream() .filter(e -> e.getValue().size() > 1) .forEach( e -> @@ -104,8 +101,7 @@ public class ExternalIdsConsistencyChecker { String.format( "Email '%s' is not unique, it's used by the following external IDs: %s", e.getKey(), - e.getValue() - .stream() + e.getValue().stream() .map(k -> "'" + k.get() + "'") .sorted() .collect(joining(", "))), diff --git a/java/com/google/gerrit/server/cache/h2/H2CacheImpl.java b/java/com/google/gerrit/server/cache/h2/H2CacheImpl.java index a8fb53b9c6..3732e37e19 100644 --- a/java/com/google/gerrit/server/cache/h2/H2CacheImpl.java +++ b/java/com/google/gerrit/server/cache/h2/H2CacheImpl.java @@ -345,8 +345,7 @@ public class H2CacheImpl<K, V> extends AbstractLoadingCache<K, V> implements Per } } } catch (Exception e) { - if (Throwables.getCausalChain(e) - .stream() + if (Throwables.getCausalChain(e).stream() .anyMatch(InvalidClassException.class::isInstance)) { // If deserialization failed using default Java serialization, this means we are using // the old serialVersionUID-based invalidation strategy. In that case, authors are diff --git a/java/com/google/gerrit/server/cache/testing/SerializedClassSubject.java b/java/com/google/gerrit/server/cache/testing/SerializedClassSubject.java index b902c1cefb..2351e2c05a 100644 --- a/java/com/google/gerrit/server/cache/testing/SerializedClassSubject.java +++ b/java/com/google/gerrit/server/cache/testing/SerializedClassSubject.java @@ -81,8 +81,7 @@ public class SerializedClassSubject extends Subject<SerializedClassSubject, Clas public void hasFields(Map<String, Type> expectedFields) { isConcrete(); assertThat( - FieldUtils.getAllFieldsList(actual()) - .stream() + FieldUtils.getAllFieldsList(actual()).stream() .filter(f -> !Modifier.isStatic(f.getModifiers())) .collect(toImmutableMap(Field::getName, Field::getGenericType))) .containsExactlyEntriesIn(expectedFields); diff --git a/java/com/google/gerrit/server/change/AddReviewersOp.java b/java/com/google/gerrit/server/change/AddReviewersOp.java index 947deadc74..6c0aa942db 100644 --- a/java/com/google/gerrit/server/change/AddReviewersOp.java +++ b/java/com/google/gerrit/server/change/AddReviewersOp.java @@ -263,8 +263,7 @@ public class AddReviewersOp implements BatchUpdateOp { !change.isWorkInProgress()); if (!addedReviewers.isEmpty()) { List<AccountState> reviewers = - addedReviewers - .stream() + addedReviewers.stream() .map(r -> accountCache.get(r.getAccountId())) .flatMap(Streams::stream) .collect(toList()); diff --git a/java/com/google/gerrit/server/change/ChangeInserter.java b/java/com/google/gerrit/server/change/ChangeInserter.java index 33c7f73bdf..80d05dff71 100644 --- a/java/com/google/gerrit/server/change/ChangeInserter.java +++ b/java/com/google/gerrit/server/change/ChangeInserter.java @@ -480,9 +480,7 @@ public class ChangeInserter implements InsertChangeOp { cm.setNotify(notify); cm.setAccountsToNotify(accountsToNotify); cm.addReviewers( - reviewerAdditions - .flattenResults(AddReviewersOp.Result::addedReviewers) - .stream() + reviewerAdditions.flattenResults(AddReviewersOp.Result::addedReviewers).stream() .map(PatchSetApproval::getAccountId) .collect(toImmutableSet())); cm.addReviewersByEmail( diff --git a/java/com/google/gerrit/server/change/ChangeJson.java b/java/com/google/gerrit/server/change/ChangeJson.java index c64cd129fe..05cd2358ce 100644 --- a/java/com/google/gerrit/server/change/ChangeJson.java +++ b/java/com/google/gerrit/server/change/ChangeJson.java @@ -613,8 +613,7 @@ public class ChangeJson { if (has(TRACKING_IDS)) { ListMultimap<String, String> set = trackingFooters.extract(cd.commitFooters()); out.trackingIds = - set.entries() - .stream() + set.entries().stream() .map(e -> new TrackingIdInfo(e.getKey(), e.getValue())) .collect(toList()); } @@ -754,16 +753,14 @@ public class ChangeJson { } private Collection<AccountInfo> toAccountInfo(Collection<Account.Id> accounts) { - return accounts - .stream() + return accounts.stream() .map(accountLoader::get) .sorted(AccountInfoComparator.ORDER_NULLS_FIRST) .collect(toList()); } private Collection<AccountInfo> toAccountInfoByEmail(Collection<Address> addresses) { - return addresses - .stream() + return addresses.stream() .map(a -> new AccountInfo(a.getName(), a.getEmail())) .sorted(AccountInfoComparator.ORDER_NULLS_FIRST) .collect(toList()); diff --git a/java/com/google/gerrit/server/change/ChangeResource.java b/java/com/google/gerrit/server/change/ChangeResource.java index ef8b2f9000..d61d56f538 100644 --- a/java/com/google/gerrit/server/change/ChangeResource.java +++ b/java/com/google/gerrit/server/change/ChangeResource.java @@ -154,9 +154,7 @@ public class ChangeResource implements RestResource, HasETag { accounts.add(getChange().getAssignee()); } try { - patchSetUtil - .byChange(db.get(), notes) - .stream() + patchSetUtil.byChange(db.get(), notes).stream() .map(PatchSet::getUploader) .forEach(accounts::add); diff --git a/java/com/google/gerrit/server/change/IncludedInResolver.java b/java/com/google/gerrit/server/change/IncludedInResolver.java index 62e94547a3..09ca258103 100644 --- a/java/com/google/gerrit/server/change/IncludedInResolver.java +++ b/java/com/google/gerrit/server/change/IncludedInResolver.java @@ -173,8 +173,7 @@ public class IncludedInResolver { */ private static ImmutableSortedSet<String> getMatchingRefNames( Set<String> matchingRefs, Collection<Ref> allRefs) { - return allRefs - .stream() + return allRefs.stream() .map(Ref::getName) .filter(matchingRefs::contains) .map(Repository::shortenRefName) diff --git a/java/com/google/gerrit/server/change/LabelsJson.java b/java/com/google/gerrit/server/change/LabelsJson.java index 29c14271ba..787e8ef0f7 100644 --- a/java/com/google/gerrit/server/change/LabelsJson.java +++ b/java/com/google/gerrit/server/change/LabelsJson.java @@ -326,9 +326,7 @@ public class LabelsJson { } if (detailed) { - labels - .entrySet() - .stream() + labels.entrySet().stream() .filter(e -> labelTypes.byLabel(e.getKey()) != null) .forEach(e -> setLabelValues(labelTypes.byLabel(e.getKey()), e.getValue())); } @@ -524,9 +522,7 @@ public class LabelsJson { Maps.newHashMapWithExpectedSize(permittedLabels.size()); for (String label : permittedLabels.keySet()) { List<Integer> permittedVotingRange = - permittedLabels - .get(label) - .stream() + permittedLabels.get(label).stream() .map(this::parseRangeValue) .filter(java.util.Objects::nonNull) .sorted() diff --git a/java/com/google/gerrit/server/change/ReviewerAdder.java b/java/com/google/gerrit/server/change/ReviewerAdder.java index adbfe54bb2..fe6090f385 100644 --- a/java/com/google/gerrit/server/change/ReviewerAdder.java +++ b/java/com/google/gerrit/server/change/ReviewerAdder.java @@ -608,8 +608,7 @@ public class ReviewerAdder { } public ImmutableList<ReviewerAddition> getFailures() { - return additions - .stream() + return additions.stream() .filter(a -> a.isFailure() && !a.isIgnorableFailure()) .collect(toImmutableList()); } @@ -639,8 +638,7 @@ public class ReviewerAdder { a -> checkArgument( a.op != null && a.op.getResult() != null, "missing result on %s", a)); - return additions() - .stream() + return additions().stream() .map(a -> a.op.getResult()) .map(func) .flatMap(Collection::stream) @@ -648,8 +646,7 @@ public class ReviewerAdder { } private ImmutableList<ReviewerAddition> additions() { - return additions - .stream() + return additions.stream() .filter( a -> { if (a.isFailure()) { diff --git a/java/com/google/gerrit/server/config/ConfigUpdatedEvent.java b/java/com/google/gerrit/server/config/ConfigUpdatedEvent.java index 0bfe5fdc9a..a7aff83eba 100644 --- a/java/com/google/gerrit/server/config/ConfigUpdatedEvent.java +++ b/java/com/google/gerrit/server/config/ConfigUpdatedEvent.java @@ -97,8 +97,7 @@ public class ConfigUpdatedEvent { private Multimap<UpdateResult, ConfigUpdateEntry> createUpdate( Set<ConfigKey> entries, UpdateResult updateResult) { Multimap<UpdateResult, ConfigUpdateEntry> updates = ArrayListMultimap.create(); - entries - .stream() + entries.stream() .filter(this::isValueUpdated) .map(e -> new ConfigUpdateEntry(e, getString(e, oldConfig), getString(e, newConfig))) .forEach(e -> updates.put(updateResult, e)); diff --git a/java/com/google/gerrit/server/config/RepositoryConfig.java b/java/com/google/gerrit/server/config/RepositoryConfig.java index a52c0760c6..d8c8468854 100644 --- a/java/com/google/gerrit/server/config/RepositoryConfig.java +++ b/java/com/google/gerrit/server/config/RepositoryConfig.java @@ -61,8 +61,7 @@ public class RepositoryConfig { } public ImmutableList<Path> getAllBasePaths() { - return cfg.getSubsections(SECTION_NAME) - .stream() + return cfg.getSubsections(SECTION_NAME).stream() .map(sub -> cfg.getString(SECTION_NAME, sub, BASE_PATH_NAME)) .filter(Objects::nonNull) .map(Paths::get) @@ -90,8 +89,7 @@ public class RepositoryConfig { */ @Nullable private String findSubSection(String project) { - return cfg.getSubsections(SECTION_NAME) - .stream() + return cfg.getSubsections(SECTION_NAME).stream() .filter(ss -> isMatch(ss, project)) .max(comparing(String::length)) .orElse(null); diff --git a/java/com/google/gerrit/server/git/LockFailureException.java b/java/com/google/gerrit/server/git/LockFailureException.java index 02a30e098b..503c0d9008 100644 --- a/java/com/google/gerrit/server/git/LockFailureException.java +++ b/java/com/google/gerrit/server/git/LockFailureException.java @@ -36,9 +36,7 @@ public class LockFailureException extends IOException { public LockFailureException(String message, BatchRefUpdate batchRefUpdate) { super(message); refs = - batchRefUpdate - .getCommands() - .stream() + batchRefUpdate.getCommands().stream() .filter(c -> c.getResult() == ReceiveCommand.Result.LOCK_FAILURE) .map(ReceiveCommand::getRefName) .collect(toImmutableList()); diff --git a/java/com/google/gerrit/server/git/MergeUtil.java b/java/com/google/gerrit/server/git/MergeUtil.java index 50eaa5dc3d..f964916038 100644 --- a/java/com/google/gerrit/server/git/MergeUtil.java +++ b/java/com/google/gerrit/server/git/MergeUtil.java @@ -291,9 +291,7 @@ public class MergeUtil { ((ResolveMerger) m).getMergeResults(); filesWithGitConflicts = - mergeResults - .entrySet() - .stream() + mergeResults.entrySet().stream() .filter(e -> e.getValue().containsConflicts()) .map(Map.Entry::getKey) .collect(toImmutableSet()); diff --git a/java/com/google/gerrit/server/git/receive/ReceiveCommits.java b/java/com/google/gerrit/server/git/receive/ReceiveCommits.java index 6cbce0784c..0abaed4f02 100644 --- a/java/com/google/gerrit/server/git/receive/ReceiveCommits.java +++ b/java/com/google/gerrit/server/git/receive/ReceiveCommits.java @@ -700,9 +700,7 @@ class ReceiveCommits { List<CreateRequest> created = newChanges.stream().filter(r -> r.change != null).collect(toList()); List<ReplaceRequest> updated = - replaceByChange - .values() - .stream() + replaceByChange.values().stream() .filter(r -> r.inputCommand.getResult() == OK) .sorted(comparingInt(r -> r.notes.getChangeId().get())) .collect(toList()); @@ -812,9 +810,7 @@ class ReceiveCommits { throw INSERT_EXCEPTION.apply(e); } - replaceByChange - .values() - .stream() + replaceByChange.values().stream() .forEach(req -> resultChangeIds.add(Key.REPLACED, req.ontoChange)); newChanges.stream().forEach(req -> resultChangeIds.add(Key.CREATED, req.changeId)); diff --git a/java/com/google/gerrit/server/git/receive/ReplaceOp.java b/java/com/google/gerrit/server/git/receive/ReplaceOp.java index a580cf6170..7bb16d817d 100644 --- a/java/com/google/gerrit/server/git/receive/ReplaceOp.java +++ b/java/com/google/gerrit/server/git/receive/ReplaceOp.java @@ -383,13 +383,9 @@ public class ReplaceOp implements BatchUpdateOp { inputs = Streams.concat( inputs, - magicBranch - .getCombinedReviewers(fromFooters) - .stream() + magicBranch.getCombinedReviewers(fromFooters).stream() .map(r -> newAddReviewerInput(r, ReviewerState.REVIEWER)), - magicBranch - .getCombinedCcs(fromFooters) - .stream() + magicBranch.getCombinedCcs(fromFooters).stream() .map(r -> newAddReviewerInput(r, ReviewerState.CC))); } return inputs.collect(toImmutableList()); @@ -582,9 +578,7 @@ public class ReplaceOp implements BatchUpdateOp { cm.addReviewers( Streams.concat( oldRecipients.getReviewers().stream(), - reviewerAdditions - .flattenResults(AddReviewersOp.Result::addedReviewers) - .stream() + reviewerAdditions.flattenResults(AddReviewersOp.Result::addedReviewers).stream() .map(PatchSetApproval::getAccountId)) .collect(toImmutableSet())); cm.addExtraCC( diff --git a/java/com/google/gerrit/server/git/validators/AccountValidator.java b/java/com/google/gerrit/server/git/validators/AccountValidator.java index e9fe562cbf..08870d36dc 100644 --- a/java/com/google/gerrit/server/git/validators/AccountValidator.java +++ b/java/com/google/gerrit/server/git/validators/AccountValidator.java @@ -114,9 +114,7 @@ public class AccountValidator { accountConfig.load(allUsersName, rw, commit); if (messages != null) { messages.addAll( - accountConfig - .getValidationErrors() - .stream() + accountConfig.getValidationErrors().stream() .map(ValidationError::getMessage) .collect(toSet())); } diff --git a/java/com/google/gerrit/server/git/validators/CommitValidators.java b/java/com/google/gerrit/server/git/validators/CommitValidators.java index 781972abe4..b228267ad4 100644 --- a/java/com/google/gerrit/server/git/validators/CommitValidators.java +++ b/java/com/google/gerrit/server/git/validators/CommitValidators.java @@ -699,8 +699,7 @@ public class CommitValidators { List<ConsistencyProblemInfo> problems = externalIdsConsistencyChecker.check(receiveEvent.commit); List<CommitValidationMessage> msgs = - problems - .stream() + problems.stream() .map( p -> new CommitValidationMessage( @@ -766,8 +765,7 @@ public class CommitValidators { if (!errorMessages.isEmpty()) { throw new CommitValidationException( "invalid account configuration", - errorMessages - .stream() + errorMessages.stream() .map(m -> new CommitValidationMessage(m, Type.ERROR)) .collect(toList())); } diff --git a/java/com/google/gerrit/server/group/PeriodicGroupIndexer.java b/java/com/google/gerrit/server/group/PeriodicGroupIndexer.java index dbbc3f690a..2a9538d07a 100644 --- a/java/com/google/gerrit/server/group/PeriodicGroupIndexer.java +++ b/java/com/google/gerrit/server/group/PeriodicGroupIndexer.java @@ -125,8 +125,7 @@ public class PeriodicGroupIndexer implements Runnable { public synchronized void run() { try (Repository allUsers = repoManager.openRepository(allUsersName)) { ImmutableSet<AccountGroup.UUID> newGroupUuids = - GroupNameNotes.loadAllGroups(allUsers) - .stream() + GroupNameNotes.loadAllGroups(allUsers).stream() .map(GroupReference::getUUID) .collect(toImmutableSet()); GroupIndexer groupIndexer = groupIndexerProvider.get(); diff --git a/java/com/google/gerrit/server/group/db/GroupConfigCommitMessage.java b/java/com/google/gerrit/server/group/db/GroupConfigCommitMessage.java index 62cc20de39..56271546af 100644 --- a/java/com/google/gerrit/server/group/db/GroupConfigCommitMessage.java +++ b/java/com/google/gerrit/server/group/db/GroupConfigCommitMessage.java @@ -107,13 +107,11 @@ class GroupConfigCommitMessage { Function<T, String> toString = element -> toParsableString.apply(auditLogFormatter, element); Stream<String> removedElements = - Sets.difference(oldElements, newElements) - .stream() + Sets.difference(oldElements, newElements).stream() .map(toString) .map((removalFooterKey.getName() + ": ")::concat); Stream<String> addedElements = - Sets.difference(newElements, oldElements) - .stream() + Sets.difference(newElements, oldElements).stream() .map(toString) .map((additionFooterKey.getName() + ": ")::concat); return Stream.concat(removedElements, addedElements); diff --git a/java/com/google/gerrit/server/group/db/GroupNameNotes.java b/java/com/google/gerrit/server/group/db/GroupNameNotes.java index 6c21dc4334..e95e91fbd2 100644 --- a/java/com/google/gerrit/server/group/db/GroupNameNotes.java +++ b/java/com/google/gerrit/server/group/db/GroupNameNotes.java @@ -295,8 +295,7 @@ public class GroupNameNotes extends VersionedMetaData { private static ImmutableBiMap<AccountGroup.UUID, String> toBiMap( Collection<GroupReference> groupReferences) { try { - return groupReferences - .stream() + return groupReferences.stream() .collect(toImmutableBiMap(GroupReference::getUUID, GroupReference::getName)); } catch (IllegalArgumentException e) { throw new IllegalArgumentException(UNIQUE_REF_ERROR, e); diff --git a/java/com/google/gerrit/server/group/db/Groups.java b/java/com/google/gerrit/server/group/db/Groups.java index f2289d47a6..37de011fb7 100644 --- a/java/com/google/gerrit/server/group/db/Groups.java +++ b/java/com/google/gerrit/server/group/db/Groups.java @@ -124,9 +124,7 @@ public class Groups { getGroupFromNoteDb(allUsersName, allUsersRepo, internalGroup.getUUID()); group.map(InternalGroup::getSubgroups).ifPresent(allSubgroups::addAll); } - return allSubgroups - .build() - .stream() + return allSubgroups.build().stream() .filter(groupUuid -> !AccountGroup.isInternalGroup(groupUuid)); } diff --git a/java/com/google/gerrit/server/index/account/AccountField.java b/java/com/google/gerrit/server/index/account/AccountField.java index 111991ce93..f67a41d045 100644 --- a/java/com/google/gerrit/server/index/account/AccountField.java +++ b/java/com/google/gerrit/server/index/account/AccountField.java @@ -157,8 +157,7 @@ public class AccountField { storedOnly("external_id_state") .buildRepeatable( a -> - a.getExternalIds() - .stream() + a.getExternalIds().stream() .filter(e -> e.blobId() != null) .map(ExternalId::toByteArray) .collect(toSet())); diff --git a/java/com/google/gerrit/server/index/change/AllChangesIndexer.java b/java/com/google/gerrit/server/index/change/AllChangesIndexer.java index 37e288c0cf..b0f4de761f 100644 --- a/java/com/google/gerrit/server/index/change/AllChangesIndexer.java +++ b/java/com/google/gerrit/server/index/change/AllChangesIndexer.java @@ -135,9 +135,7 @@ public class AllChangesIndexer extends SiteIndexer<Change.Id, ChangeData, Change // Estimate size based on IDs that show up in ref names. This is not perfect, since patch set // refs may exist for changes whose metadata was never successfully stored. But that's ok, as // the estimate is just used as a heuristic for sorting projects. - return repo.getRefDatabase() - .getRefsByPrefix(RefNames.REFS_CHANGES) - .stream() + return repo.getRefDatabase().getRefsByPrefix(RefNames.REFS_CHANGES).stream() .map(r -> Change.Id.fromRef(r.getName())) .filter(Objects::nonNull) .distinct() diff --git a/java/com/google/gerrit/server/index/change/ChangeField.java b/java/com/google/gerrit/server/index/change/ChangeField.java index 5d12e79cfe..da807e79ba 100644 --- a/java/com/google/gerrit/server/index/change/ChangeField.java +++ b/java/com/google/gerrit/server/index/change/ChangeField.java @@ -737,8 +737,7 @@ public class ChangeField { @VisibleForTesting static List<SubmitRecord> parseSubmitRecords(Collection<String> values) { - return values - .stream() + return values.stream() .map(v -> GSON.fromJson(v, StoredSubmitRecord.class).toSubmitRecord()) .collect(toList()); } diff --git a/java/com/google/gerrit/server/index/project/StalenessChecker.java b/java/com/google/gerrit/server/index/project/StalenessChecker.java index 25cc5faca3..733e48657f 100644 --- a/java/com/google/gerrit/server/index/project/StalenessChecker.java +++ b/java/com/google/gerrit/server/index/project/StalenessChecker.java @@ -66,9 +66,7 @@ public class StalenessChecker { SetMultimap<Project.NameKey, RefState> currentRefStates = MultimapBuilder.hashKeys().hashSetValues().build(); - projectData - .tree() - .stream() + projectData.tree().stream() .filter(p -> p.getProject().getConfigRefState() != null) .forEach( p -> diff --git a/java/com/google/gerrit/server/logging/CallerFinder.java b/java/com/google/gerrit/server/logging/CallerFinder.java index 62f2bbc860..c27dbbb05c 100644 --- a/java/com/google/gerrit/server/logging/CallerFinder.java +++ b/java/com/google/gerrit/server/logging/CallerFinder.java @@ -170,8 +170,7 @@ public abstract class CallerFinder { public LazyArg<String> findCaller() { return lazy( () -> - targets() - .stream() + targets().stream() .map(t -> findCallerOf(t, skip() + 1)) .filter(Optional::isPresent) .findFirst() diff --git a/java/com/google/gerrit/server/logging/TraceContext.java b/java/com/google/gerrit/server/logging/TraceContext.java index 76968d546f..ded34d03e8 100644 --- a/java/com/google/gerrit/server/logging/TraceContext.java +++ b/java/com/google/gerrit/server/logging/TraceContext.java @@ -134,10 +134,7 @@ public class TraceContext implements AutoCloseable { } Optional<String> existingTraceId = - LoggingContext.getInstance() - .getTagsAsMap() - .get(RequestId.Type.TRACE_ID.name()) - .stream() + LoggingContext.getInstance().getTagsAsMap().get(RequestId.Type.TRACE_ID.name()).stream() .findAny(); if (existingTraceId.isPresent()) { // request tracing was already started, no need to generate a new trace ID diff --git a/java/com/google/gerrit/server/mail/receive/MailProcessor.java b/java/com/google/gerrit/server/mail/receive/MailProcessor.java index 9562821870..15a71e0f3d 100644 --- a/java/com/google/gerrit/server/mail/receive/MailProcessor.java +++ b/java/com/google/gerrit/server/mail/receive/MailProcessor.java @@ -233,8 +233,7 @@ public class MailProcessor { // comments from the outbound email. // TODO(hiesel) Also filter by original comment author. Collection<Comment> comments = - cd.publishedComments() - .stream() + cd.publishedComments().stream() .filter(c -> (c.writtenOn.getTime() / 1000) == (metadata.timestamp.getTime() / 1000)) .sorted(CommentsUtil.COMMENT_ORDER) .collect(toList()); @@ -427,8 +426,7 @@ public class MailProcessor { private Set<String> existingMessageIds(ChangeData cd) throws OrmException { Set<String> existingMessageIds = new HashSet<>(); - cd.messages() - .stream() + cd.messages().stream() .forEach( m -> { String messageId = CommentsUtil.extractMessageId(m.getTag()); @@ -436,8 +434,7 @@ public class MailProcessor { existingMessageIds.add(messageId); } }); - cd.publishedComments() - .stream() + cd.publishedComments().stream() .forEach( c -> { String messageId = CommentsUtil.extractMessageId(c.tag); diff --git a/java/com/google/gerrit/server/mail/send/CommentSender.java b/java/com/google/gerrit/server/mail/send/CommentSender.java index eaf07ef2c1..69a79266ec 100644 --- a/java/com/google/gerrit/server/mail/send/CommentSender.java +++ b/java/com/google/gerrit/server/mail/send/CommentSender.java @@ -458,8 +458,7 @@ public class CommentSender extends ReplyToChangeSender { } private List<Map<String, Object>> commentBlocksToSoyData(List<CommentFormatter.Block> blocks) { - return blocks - .stream() + return blocks.stream() .map( b -> { Map<String, Object> map = new HashMap<>(); diff --git a/java/com/google/gerrit/server/notedb/ChangeBundle.java b/java/com/google/gerrit/server/notedb/ChangeBundle.java index c4d6a91f72..058e5e5785 100644 --- a/java/com/google/gerrit/server/notedb/ChangeBundle.java +++ b/java/com/google/gerrit/server/notedb/ChangeBundle.java @@ -557,8 +557,7 @@ public class ChangeBundle { } if (!bs.isEmpty()) { sb.append("Only in B:"); - bs.values() - .stream() + bs.values().stream() .sorted(CHANGE_MESSAGE_COMPARATOR) .forEach(cm -> sb.append("\n ").append(cm)); } @@ -675,9 +674,7 @@ public class ChangeBundle { private static boolean createdOnIsMonotonic( Map<?, PatchSet> patchSets, Set<PatchSet.Id> limitToIds) { List<PatchSet> orderedById = - patchSets - .values() - .stream() + patchSets.values().stream() .filter(ps -> limitToIds.contains(ps.getId())) .sorted(ChangeUtil.PS_ID_ORDER) .collect(toList()); diff --git a/java/com/google/gerrit/server/notedb/ChangeNotes.java b/java/com/google/gerrit/server/notedb/ChangeNotes.java index d2942dc7a6..086b2e28f2 100644 --- a/java/com/google/gerrit/server/notedb/ChangeNotes.java +++ b/java/com/google/gerrit/server/notedb/ChangeNotes.java @@ -336,8 +336,7 @@ public class ChangeNotes extends AbstractChangeNotes<ChangeNotes> { ScanResult sr = scanChangeIds(repo); PrimaryStorage defaultStorage = args.migration.changePrimaryStorage(); - return sr.all() - .stream() + return sr.all().stream() .map(id -> scanOneNoteDbChange(db, project, sr, defaultStorage, id)) .filter(Objects::nonNull); } diff --git a/java/com/google/gerrit/server/notedb/ChangeNotesState.java b/java/com/google/gerrit/server/notedb/ChangeNotesState.java index ca579ae231..02fe4167a6 100644 --- a/java/com/google/gerrit/server/notedb/ChangeNotesState.java +++ b/java/com/google/gerrit/server/notedb/ChangeNotesState.java @@ -565,23 +565,17 @@ public abstract class ChangeNotesState { .changeId(changeId) .columns(toChangeColumns(changeId, proto.getColumns())) .pastAssignees( - proto - .getPastAssigneeList() - .stream() + proto.getPastAssigneeList().stream() .map(Account.Id::new) .collect(toImmutableSet())) .hashtags(proto.getHashtagList()) .patchSets( - proto - .getPatchSetList() - .stream() + proto.getPatchSetList().stream() .map(PATCH_SET_CODEC::decode) .map(ps -> Maps.immutableEntry(ps.getId(), ps)) .collect(toImmutableList())) .approvals( - proto - .getApprovalList() - .stream() + proto.getApprovalList().stream() .map(APPROVAL_CODEC::decode) .map(a -> Maps.immutableEntry(a.getPatchSetId(), a)) .collect(toImmutableList())) @@ -590,28 +584,20 @@ public abstract class ChangeNotesState { .pendingReviewers(toReviewerSet(proto.getPendingReviewerList())) .pendingReviewersByEmail(toReviewerByEmailSet(proto.getPendingReviewerByEmailList())) .allPastReviewers( - proto - .getPastReviewerList() - .stream() + proto.getPastReviewerList().stream() .map(Account.Id::new) .collect(toImmutableList())) .reviewerUpdates(toReviewerStatusUpdateList(proto.getReviewerUpdateList())) .submitRecords( - proto - .getSubmitRecordList() - .stream() + proto.getSubmitRecordList().stream() .map(r -> GSON.fromJson(r, StoredSubmitRecord.class).toSubmitRecord()) .collect(toImmutableList())) .changeMessages( - proto - .getChangeMessageList() - .stream() + proto.getChangeMessageList().stream() .map(MESSAGE_CODEC::decode) .collect(toImmutableList())) .publishedComments( - proto - .getPublishedCommentList() - .stream() + proto.getPublishedCommentList().stream() .map(r -> GSON.fromJson(r, Comment.class)) .collect(toImmutableListMultimap(c -> new RevId(c.revId), c -> c))); if (proto.getHasReadOnlyUntil()) { diff --git a/java/com/google/gerrit/server/notedb/DeleteCommentRewriter.java b/java/com/google/gerrit/server/notedb/DeleteCommentRewriter.java index 0cd3452b64..656e9ec951 100644 --- a/java/com/google/gerrit/server/notedb/DeleteCommentRewriter.java +++ b/java/com/google/gerrit/server/notedb/DeleteCommentRewriter.java @@ -141,9 +141,7 @@ public class DeleteCommentRewriter implements NoteDbRewriter { throws IOException, ConfigInvalidException { return RevisionNoteMap.parse( changeNoteJson, legacyChangeNoteRead, changeId, reader, noteMap, PUBLISHED) - .revisionNotes - .values() - .stream() + .revisionNotes.values().stream() .flatMap(n -> n.getComments().stream()) .collect(toMap(c -> c.key.uuid, Function.identity())); } @@ -189,9 +187,7 @@ public class DeleteCommentRewriter implements NoteDbRewriter { */ private List<Comment> getDeletedComments( Map<String, Comment> parMap, Map<String, Comment> curMap) { - return parMap - .entrySet() - .stream() + return parMap.entrySet().stream() .filter(c -> !curMap.containsKey(c.getKey())) .map(Map.Entry::getValue) .collect(toList()); diff --git a/java/com/google/gerrit/server/notedb/rebuild/ChangeRebuilderImpl.java b/java/com/google/gerrit/server/notedb/rebuild/ChangeRebuilderImpl.java index 8740710d05..0d516e5b88 100644 --- a/java/com/google/gerrit/server/notedb/rebuild/ChangeRebuilderImpl.java +++ b/java/com/google/gerrit/server/notedb/rebuild/ChangeRebuilderImpl.java @@ -419,9 +419,7 @@ public class ChangeRebuilderImpl extends ChangeRebuilder { private static List<Comment> getComments( ChangeBundle bundle, String serverId, PatchLineComment.Status status, PatchSet ps) { - return bundle - .getPatchLineComments() - .stream() + return bundle.getPatchLineComments().stream() .filter(c -> c.getPatchSetId().equals(ps.getId()) && c.getStatus() == status) .map(plc -> plc.asComment(serverId)) .sorted(CommentsUtil.COMMENT_ORDER) diff --git a/java/com/google/gerrit/server/notedb/rebuild/NoteDbMigrator.java b/java/com/google/gerrit/server/notedb/rebuild/NoteDbMigrator.java index 736792df5c..1ac1da2a6b 100644 --- a/java/com/google/gerrit/server/notedb/rebuild/NoteDbMigrator.java +++ b/java/com/google/gerrit/server/notedb/rebuild/NoteDbMigrator.java @@ -447,8 +447,7 @@ public class NoteDbMigrator implements AutoCloseable { int sequenceGap, boolean autoMigrate) throws MigrationException { - if (ImmutableList.of(!changes.isEmpty(), !projects.isEmpty(), !skipProjects.isEmpty()) - .stream() + if (ImmutableList.of(!changes.isEmpty(), !projects.isEmpty(), !skipProjects.isEmpty()).stream() .filter(e -> e) .count() > 1) { @@ -628,8 +627,7 @@ public class NoteDbMigrator implements AutoCloseable { try (ContextHelper contextHelper = new ContextHelper()) { List<ListenableFuture<Boolean>> futures = - allChanges - .stream() + allChanges.stream() .map( id -> executor.submit( diff --git a/java/com/google/gerrit/server/patch/EditTransformer.java b/java/com/google/gerrit/server/patch/EditTransformer.java index 9083ede9c4..90f442eca3 100644 --- a/java/com/google/gerrit/server/patch/EditTransformer.java +++ b/java/com/google/gerrit/server/patch/EditTransformer.java @@ -89,8 +89,7 @@ class EditTransformer { * @return the transformed edits per file path */ public Multimap<String, ContextAwareEdit> getEditsPerFilePath() { - return edits - .stream() + return edits.stream() .collect( toMultimap( ContextAwareEdit::getNewFilePath, Function.identity(), ArrayListMultimap::create)); @@ -112,9 +111,7 @@ class EditTransformer { transformingEntries.stream().collect(groupingBy(EditTransformer::getOldFilePath)); edits = - editsPerFilePath - .entrySet() - .stream() + editsPerFilePath.entrySet().stream() .flatMap( pathAndEdits -> { List<PatchListEntry> transEntries = @@ -137,12 +134,11 @@ class EditTransformer { } // TODO(aliceks): Find a way to prevent an explosion of the number of entries. - return transformingEntries - .stream() + return transformingEntries.stream() .flatMap( transEntry -> transformEdits( - sideStrategy, originalEdits, transEntry.getEdits(), transEntry.getNewName()) + sideStrategy, originalEdits, transEntry.getEdits(), transEntry.getNewName()) .stream()); } diff --git a/java/com/google/gerrit/server/patch/PatchListLoader.java b/java/com/google/gerrit/server/patch/PatchListLoader.java index 074e3441ca..08de537305 100644 --- a/java/com/google/gerrit/server/patch/PatchListLoader.java +++ b/java/com/google/gerrit/server/patch/PatchListLoader.java @@ -287,8 +287,7 @@ public class PatchListLoader implements Callable<PatchList> { } List<DiffEntry> relevantDiffEntries = - diffEntries - .stream() + diffEntries.stream() .filter(diffEntry -> isTouched(touchedFilePaths, diffEntry)) .collect(toImmutableList()); @@ -397,8 +396,7 @@ public class PatchListLoader implements Callable<PatchList> { } private static Set<Edit> getContentEdits(Set<ContextAwareEdit> editsDueToRebase) { - return editsDueToRebase - .stream() + return editsDueToRebase.stream() .map(ContextAwareEdit::toEdit) .filter(Optional::isPresent) .map(Optional::get) diff --git a/java/com/google/gerrit/server/permissions/DefaultPermissionBackend.java b/java/com/google/gerrit/server/permissions/DefaultPermissionBackend.java index 406eda8814..1782ac9acb 100644 --- a/java/com/google/gerrit/server/permissions/DefaultPermissionBackend.java +++ b/java/com/google/gerrit/server/permissions/DefaultPermissionBackend.java @@ -252,8 +252,7 @@ public class DefaultPermissionBackend extends PermissionBackend { private boolean allow(Collection<PermissionRule> rules) { return user.getEffectiveGroups() .containsAnyOf( - rules - .stream() + rules.stream() .filter(r -> r.getAction() == Action.ALLOW) .map(r -> r.getGroup().getUUID()) .collect(toSet())); @@ -261,8 +260,7 @@ public class DefaultPermissionBackend extends PermissionBackend { private boolean notDenied(Collection<PermissionRule> rules) { Set<AccountGroup.UUID> denied = - rules - .stream() + rules.stream() .filter(r -> r.getAction() != Action.ALLOW) .map(r -> r.getGroup().getUUID()) .collect(toSet()); diff --git a/java/com/google/gerrit/server/permissions/PermissionBackend.java b/java/com/google/gerrit/server/permissions/PermissionBackend.java index db3c96169c..fea42b5de6 100644 --- a/java/com/google/gerrit/server/permissions/PermissionBackend.java +++ b/java/com/google/gerrit/server/permissions/PermissionBackend.java @@ -502,9 +502,7 @@ public abstract class PermissionBackend { } private static Set<LabelPermission.WithValue> valuesOf(LabelType label) { - return label - .getValues() - .stream() + return label.getValues().stream() .map((v) -> new LabelPermission.WithValue(label, v)) .collect(toSet()); } diff --git a/java/com/google/gerrit/server/permissions/PermissionCollection.java b/java/com/google/gerrit/server/permissions/PermissionCollection.java index b419698415..1a3198d84e 100644 --- a/java/com/google/gerrit/server/permissions/PermissionCollection.java +++ b/java/com/google/gerrit/server/permissions/PermissionCollection.java @@ -151,8 +151,7 @@ public class PermissionCollection { Lists.reverse(Lists.newArrayList(sectionToProject.entrySet())); Map<Project.NameKey, List<AccessSection>> accessByProject = - accessDescending - .stream() + accessDescending.stream() .collect( Collectors.groupingBy( Map.Entry::getValue, diff --git a/java/com/google/gerrit/server/project/ChildProjects.java b/java/com/google/gerrit/server/project/ChildProjects.java index 868d0afff5..ce9992eeba 100644 --- a/java/com/google/gerrit/server/project/ChildProjects.java +++ b/java/com/google/gerrit/server/project/ChildProjects.java @@ -93,8 +93,7 @@ public class ChildProjects { Project.NameKey parent) throws PermissionBackendException { List<Project.NameKey> canSee = - perm.filter(ProjectPermission.ACCESS, children.get(parent)) - .stream() + perm.filter(ProjectPermission.ACCESS, children.get(parent)).stream() .sorted() .collect(toList()); children.removeAll(parent); // removing all entries prevents cycles. diff --git a/java/com/google/gerrit/server/project/ProjectCacheImpl.java b/java/com/google/gerrit/server/project/ProjectCacheImpl.java index 39475faa28..8ddeea3348 100644 --- a/java/com/google/gerrit/server/project/ProjectCacheImpl.java +++ b/java/com/google/gerrit/server/project/ProjectCacheImpl.java @@ -235,8 +235,7 @@ public class ProjectCacheImpl implements ProjectCache { @Override public Set<AccountGroup.UUID> guessRelevantGroupUUIDs() { - return all() - .stream() + return all().stream() .map(n -> byName.getIfPresent(n.get())) .filter(Objects::nonNull) .flatMap(p -> p.getConfig().getAllGroupUUIDs().stream()) diff --git a/java/com/google/gerrit/server/project/ProjectConfig.java b/java/com/google/gerrit/server/project/ProjectConfig.java index bccc4158a9..81cc78b4e5 100644 --- a/java/com/google/gerrit/server/project/ProjectConfig.java +++ b/java/com/google/gerrit/server/project/ProjectConfig.java @@ -1168,14 +1168,12 @@ public class ProjectConfig extends VersionedMetaData implements ValidationError. private void saveNotifySections(Config rc, Set<AccountGroup.UUID> keepGroups) { for (NotifyConfig nc : sort(notifySections.values())) { - nc.getGroups() - .stream() + nc.getGroups().stream() .map(gr -> gr.getUUID()) .filter(Objects::nonNull) .forEach(keepGroups::add); List<String> email = - nc.getGroups() - .stream() + nc.getGroups().stream() .map(gr -> new PermissionRule(gr).asString(false)) .sorted() .collect(toList()); diff --git a/java/com/google/gerrit/server/project/ProjectState.java b/java/com/google/gerrit/server/project/ProjectState.java index 88c56c1e2b..75ce4830fe 100644 --- a/java/com/google/gerrit/server/project/ProjectState.java +++ b/java/com/google/gerrit/server/project/ProjectState.java @@ -219,8 +219,7 @@ public class ProjectState { } // If not, we check the parents. - return parents() - .stream() + return parents().stream() .map(ProjectState::getConfig) .map(ProjectConfig::getRulesId) .anyMatch(Objects::nonNull); diff --git a/java/com/google/gerrit/server/project/ProjectsConsistencyChecker.java b/java/com/google/gerrit/server/project/ProjectsConsistencyChecker.java index e61c5df4c4..894037d2ac 100644 --- a/java/com/google/gerrit/server/project/ProjectsConsistencyChecker.java +++ b/java/com/google/gerrit/server/project/ProjectsConsistencyChecker.java @@ -296,9 +296,7 @@ public class ProjectsConsistencyChecker { // Auto-close by commit for (ObjectId patchSetSha1 : - autoCloseableChange - .patchSets() - .stream() + autoCloseableChange.patchSets().stream() .map(ps -> ObjectId.fromString(ps.getRevision().get())) .collect(toSet())) { if (mergedSha1s.contains(patchSetSha1)) { diff --git a/java/com/google/gerrit/server/project/SuggestParentCandidates.java b/java/com/google/gerrit/server/project/SuggestParentCandidates.java index 99833af9fa..d3dfdcdf04 100644 --- a/java/com/google/gerrit/server/project/SuggestParentCandidates.java +++ b/java/com/google/gerrit/server/project/SuggestParentCandidates.java @@ -42,9 +42,7 @@ public class SuggestParentCandidates { } public List<Project.NameKey> getNameKeys() throws PermissionBackendException { - return permissionBackend - .currentUser() - .filter(ProjectPermission.ACCESS, readableParents()) + return permissionBackend.currentUser().filter(ProjectPermission.ACCESS, readableParents()) .stream() .sorted() .collect(toList()); diff --git a/java/com/google/gerrit/server/query/account/InternalAccountQuery.java b/java/com/google/gerrit/server/query/account/InternalAccountQuery.java index d0840d605b..e8e72a83b0 100644 --- a/java/com/google/gerrit/server/query/account/InternalAccountQuery.java +++ b/java/com/google/gerrit/server/query/account/InternalAccountQuery.java @@ -108,8 +108,7 @@ public class InternalAccountQuery extends InternalQuery<AccountState> { return ImmutableList.of(); } - return query(AccountPredicates.preferredEmail(email)) - .stream() + return query(AccountPredicates.preferredEmail(email)).stream() .filter(a -> a.getAccount().getPreferredEmail().equals(email)) .collect(toList()); } @@ -145,8 +144,7 @@ public class InternalAccountQuery extends InternalQuery<AccountState> { for (int i = 0; i < emailList.size(); i++) { String email = emailList.get(i); Set<AccountState> matchingAccounts = - r.get(i) - .stream() + r.get(i).stream() .filter(a -> a.getAccount().getPreferredEmail().equals(email)) .collect(toSet()); accountsByEmail.putAll(email, matchingAccounts); diff --git a/java/com/google/gerrit/server/query/change/ChangeQueryBuilder.java b/java/com/google/gerrit/server/query/change/ChangeQueryBuilder.java index 2ec2e7ccb3..fb3439380a 100644 --- a/java/com/google/gerrit/server/query/change/ChangeQueryBuilder.java +++ b/java/com/google/gerrit/server/query/change/ChangeQueryBuilder.java @@ -1358,8 +1358,7 @@ public class ChangeQueryBuilder extends QueryBuilder<ChangeData> { if (!forDefaultField || accounts.size() <= MAX_ACCOUNTS_PER_DEFAULT_FIELD) { reviewerPredicate = Predicate.or( - accounts - .stream() + accounts.stream() .map(id -> ReviewerPredicate.forState(id, state)) .collect(toList())); } diff --git a/java/com/google/gerrit/server/query/change/SubmitRecordPredicate.java b/java/com/google/gerrit/server/query/change/SubmitRecordPredicate.java index 17034dfff4..6a81ff60df 100644 --- a/java/com/google/gerrit/server/query/change/SubmitRecordPredicate.java +++ b/java/com/google/gerrit/server/query/change/SubmitRecordPredicate.java @@ -31,8 +31,7 @@ public class SubmitRecordPredicate extends ChangeIndexPredicate { return new SubmitRecordPredicate(status.name() + ',' + lowerLabel); } return Predicate.or( - accounts - .stream() + accounts.stream() .map(a -> new SubmitRecordPredicate(status.name() + ',' + lowerLabel + ',' + a.get())) .collect(toList())); } diff --git a/java/com/google/gerrit/server/query/change/SubmittablePredicate.java b/java/com/google/gerrit/server/query/change/SubmittablePredicate.java index df78315bd5..8a2c8896b9 100644 --- a/java/com/google/gerrit/server/query/change/SubmittablePredicate.java +++ b/java/com/google/gerrit/server/query/change/SubmittablePredicate.java @@ -28,8 +28,7 @@ public class SubmittablePredicate extends ChangeIndexPredicate { @Override public boolean match(ChangeData cd) throws OrmException { - return cd.submitRecords(ChangeField.SUBMIT_RULE_OPTIONS_STRICT) - .stream() + return cd.submitRecords(ChangeField.SUBMIT_RULE_OPTIONS_STRICT).stream() .anyMatch(r -> r.status == status); } diff --git a/java/com/google/gerrit/server/restapi/account/DeleteEmail.java b/java/com/google/gerrit/server/restapi/account/DeleteEmail.java index f0269f1775..6bacde2220 100644 --- a/java/com/google/gerrit/server/restapi/account/DeleteEmail.java +++ b/java/com/google/gerrit/server/restapi/account/DeleteEmail.java @@ -85,9 +85,7 @@ public class DeleteEmail implements RestModifyView<AccountResource.Email, Input> } Set<ExternalId> extIds = - externalIds - .byAccount(user.getAccountId()) - .stream() + externalIds.byAccount(user.getAccountId()).stream() .filter(e -> email.equals(e.email())) .collect(toSet()); if (extIds.isEmpty()) { diff --git a/java/com/google/gerrit/server/restapi/account/DeleteExternalIds.java b/java/com/google/gerrit/server/restapi/account/DeleteExternalIds.java index 05b1771467..9fb535c114 100644 --- a/java/com/google/gerrit/server/restapi/account/DeleteExternalIds.java +++ b/java/com/google/gerrit/server/restapi/account/DeleteExternalIds.java @@ -77,9 +77,7 @@ public class DeleteExternalIds implements RestModifyView<AccountResource, List<S } Map<ExternalId.Key, ExternalId> externalIdMap = - externalIds - .byAccount(resource.getUser().getAccountId()) - .stream() + externalIds.byAccount(resource.getUser().getAccountId()).stream() .collect(toMap(ExternalId::key, Function.identity())); List<ExternalId> toDelete = new ArrayList<>(); diff --git a/java/com/google/gerrit/server/restapi/account/DeleteWatchedProjects.java b/java/com/google/gerrit/server/restapi/account/DeleteWatchedProjects.java index 0e2edb9e38..deb70fe8fd 100644 --- a/java/com/google/gerrit/server/restapi/account/DeleteWatchedProjects.java +++ b/java/com/google/gerrit/server/restapi/account/DeleteWatchedProjects.java @@ -76,8 +76,7 @@ public class DeleteWatchedProjects accountId, u -> u.deleteProjectWatches( - input - .stream() + input.stream() .filter(Objects::nonNull) .map(w -> ProjectWatchKey.create(new Project.NameKey(w.project), w.filter)) .collect(toList()))); diff --git a/java/com/google/gerrit/server/restapi/account/GetEmails.java b/java/com/google/gerrit/server/restapi/account/GetEmails.java index ed3347fc97..8c21536ed3 100644 --- a/java/com/google/gerrit/server/restapi/account/GetEmails.java +++ b/java/com/google/gerrit/server/restapi/account/GetEmails.java @@ -48,9 +48,7 @@ public class GetEmails implements RestReadView<AccountResource> { if (!self.get().hasSameAccountId(rsrc.getUser())) { permissionBackend.currentUser().check(GlobalPermission.MODIFY_ACCOUNT); } - return rsrc.getUser() - .getEmailAddresses() - .stream() + return rsrc.getUser().getEmailAddresses().stream() .filter(Objects::nonNull) .map(e -> toEmailInfo(rsrc, e)) .sorted(comparing((EmailInfo e) -> e.email)) diff --git a/java/com/google/gerrit/server/restapi/account/GetWatchedProjects.java b/java/com/google/gerrit/server/restapi/account/GetWatchedProjects.java index 61021be73c..ba8c72a65d 100644 --- a/java/com/google/gerrit/server/restapi/account/GetWatchedProjects.java +++ b/java/com/google/gerrit/server/restapi/account/GetWatchedProjects.java @@ -65,10 +65,7 @@ public class GetWatchedProjects implements RestReadView<AccountResource> { Account.Id accountId = rsrc.getUser().getAccountId(); AccountState account = accounts.get(accountId).orElseThrow(ResourceNotFoundException::new); - return account - .getProjectWatches() - .entrySet() - .stream() + return account.getProjectWatches().entrySet().stream() .map(e -> toProjectWatchInfo(e.getKey(), e.getValue())) .sorted( comparing((ProjectWatchInfo pwi) -> pwi.project) diff --git a/java/com/google/gerrit/server/restapi/account/PutPreferred.java b/java/com/google/gerrit/server/restapi/account/PutPreferred.java index a8289878f4..265bf530ec 100644 --- a/java/com/google/gerrit/server/restapi/account/PutPreferred.java +++ b/java/com/google/gerrit/server/restapi/account/PutPreferred.java @@ -93,8 +93,7 @@ public class PutPreferred implements RestModifyView<AccountResource.Email, Input // check if the user has a matching email String matchingEmail = null; for (String email : - a.getExternalIds() - .stream() + a.getExternalIds().stream() .map(ExternalId::email) .filter(Objects::nonNull) .collect(toSet())) { @@ -121,8 +120,7 @@ public class PutPreferred implements RestModifyView<AccountResource.Email, Input + " by the following account(s): %s", preferredEmail, user.getAccountId(), - existingExtIdsWithThisEmail - .stream() + existingExtIdsWithThisEmail.stream() .map(ExternalId::accountId) .collect(toList())); exception.set( diff --git a/java/com/google/gerrit/server/restapi/change/CherryPickChange.java b/java/com/google/gerrit/server/restapi/change/CherryPickChange.java index 6399cdec6d..b0ebd2b7f1 100644 --- a/java/com/google/gerrit/server/restapi/change/CherryPickChange.java +++ b/java/com/google/gerrit/server/restapi/change/CherryPickChange.java @@ -389,9 +389,7 @@ public class CherryPickChange { if (!cherryPickCommit.getFilesWithGitConflicts().isEmpty()) { stringBuilder.append("\n\nThe following files contain Git conflicts:\n"); - cherryPickCommit - .getFilesWithGitConflicts() - .stream() + cherryPickCommit.getFilesWithGitConflicts().stream() .sorted() .forEach(filePath -> stringBuilder.append("* ").append(filePath).append("\n")); } diff --git a/java/com/google/gerrit/server/restapi/change/GetRelated.java b/java/com/google/gerrit/server/restapi/change/GetRelated.java index 30fbf39386..3eea73671d 100644 --- a/java/com/google/gerrit/server/restapi/change/GetRelated.java +++ b/java/com/google/gerrit/server/restapi/change/GetRelated.java @@ -127,9 +127,7 @@ public class GetRelated implements RestReadView<RevisionResource> { @VisibleForTesting public static Set<String> getAllGroups(ChangeNotes notes, ReviewDb db, PatchSetUtil psUtil) throws OrmException { - return psUtil - .byChange(db, notes) - .stream() + return psUtil.byChange(db, notes).stream() .flatMap(ps -> ps.getGroups().stream()) .collect(toSet()); } diff --git a/java/com/google/gerrit/server/restapi/change/ListChangeMessages.java b/java/com/google/gerrit/server/restapi/change/ListChangeMessages.java index 39c12f7579..9ce21574bb 100644 --- a/java/com/google/gerrit/server/restapi/change/ListChangeMessages.java +++ b/java/com/google/gerrit/server/restapi/change/ListChangeMessages.java @@ -53,8 +53,7 @@ public class ListChangeMessages implements RestReadView<ChangeResource> { List<ChangeMessage> messages = changeMessagesUtil.byChange(dbProvider.get(), resource.getNotes()); List<ChangeMessageInfo> messageInfos = - messages - .stream() + messages.stream() .map(m -> createChangeMessageInfo(m, accountLoader)) .collect(Collectors.toList()); accountLoader.fill(); diff --git a/java/com/google/gerrit/server/restapi/change/PostReview.java b/java/com/google/gerrit/server/restapi/change/PostReview.java index d06766dba0..845f584578 100644 --- a/java/com/google/gerrit/server/restapi/change/PostReview.java +++ b/java/com/google/gerrit/server/restapi/change/PostReview.java @@ -806,8 +806,7 @@ public class PostReview private static void ensureRangesDoNotOverlap( String commentPath, List<FixReplacementInfo> fixReplacementInfos) throws BadRequestException { List<Range> sortedRanges = - fixReplacementInfos - .stream() + fixReplacementInfos.stream() .map(fixReplacementInfo -> fixReplacementInfo.range) .sorted() .collect(toList()); @@ -1078,17 +1077,13 @@ public class PostReview } private Set<CommentSetEntry> readExistingComments(ChangeContext ctx) throws OrmException { - return commentsUtil - .publishedByChange(ctx.getDb(), ctx.getNotes()) - .stream() + return commentsUtil.publishedByChange(ctx.getDb(), ctx.getNotes()).stream() .map(CommentSetEntry::create) .collect(toSet()); } private Set<CommentSetEntry> readExistingRobotComments(ChangeContext ctx) throws OrmException { - return commentsUtil - .robotCommentsByChange(ctx.getNotes()) - .stream() + return commentsUtil.robotCommentsByChange(ctx.getNotes()).stream() .map(CommentSetEntry::create) .collect(toSet()); } @@ -1313,8 +1308,7 @@ public class PostReview if (!reduced.isEmpty()) { throw new ResourceConflictException( "Cannot reduce vote on labels for closed change: " - + reduced - .stream() + + reduced.stream() .map(PatchSetApproval::getLabel) .distinct() .sorted() diff --git a/java/com/google/gerrit/server/restapi/change/ReviewerRecommender.java b/java/com/google/gerrit/server/restapi/change/ReviewerRecommender.java index d88489ea85..ece52bf08f 100644 --- a/java/com/google/gerrit/server/restapi/change/ReviewerRecommender.java +++ b/java/com/google/gerrit/server/restapi/change/ReviewerRecommender.java @@ -195,9 +195,7 @@ public class ReviewerRecommender { // Sort results Stream<Entry<Account.Id, MutableDouble>> sorted = - reviewerScores - .entrySet() - .stream() + reviewerScores.entrySet().stream() .sorted(Collections.reverseOrder(Map.Entry.comparingByValue())); List<Account.Id> sortedSuggestions = sorted.map(Map.Entry::getKey).collect(toList()); logger.atFine().log("Sorted suggestions: %s", sortedSuggestions); diff --git a/java/com/google/gerrit/server/restapi/change/ReviewersUtil.java b/java/com/google/gerrit/server/restapi/change/ReviewersUtil.java index f7959c82ce..1c97431de2 100644 --- a/java/com/google/gerrit/server/restapi/change/ReviewersUtil.java +++ b/java/com/google/gerrit/server/restapi/change/ReviewersUtil.java @@ -247,9 +247,7 @@ public class ReviewersUtil { ImmutableSet.of(AccountField.ID.getName()))) .readRaw(); List<Account.Id> matches = - result - .toList() - .stream() + result.toList().stream() .map(f -> new Account.Id(f.getValue(AccountField.ID).intValue())) .collect(toList()); logger.atFine().log("Matches: %s", matches); @@ -310,8 +308,7 @@ public class ReviewersUtil { try (Timer0.Context ctx = metrics.loadAccountsLatency.start()) { List<SuggestedReviewerInfo> reviewer = - accountIds - .stream() + accountIds.stream() .map(accountLoader::get) .filter(Objects::nonNull) .map( @@ -431,8 +428,7 @@ public class ReviewersUtil { } private static String formatSuggestedReviewers(List<SuggestedReviewerInfo> suggestedReviewers) { - return suggestedReviewers - .stream() + return suggestedReviewers.stream() .map( r -> { if (r.account != null) { diff --git a/java/com/google/gerrit/server/restapi/config/ListTasks.java b/java/com/google/gerrit/server/restapi/config/ListTasks.java index f77cda4a59..7402c15b21 100644 --- a/java/com/google/gerrit/server/restapi/config/ListTasks.java +++ b/java/com/google/gerrit/server/restapi/config/ListTasks.java @@ -106,9 +106,7 @@ public class ListTasks implements RestReadView<ConfigResource> { } private List<TaskInfo> getTasks() { - return workQueue - .getTaskInfos(TaskInfo::new) - .stream() + return workQueue.getTaskInfos(TaskInfo::new).stream() .sorted( comparing((TaskInfo t) -> t.state.ordinal()) .thenComparing(t -> t.delay) diff --git a/java/com/google/gerrit/server/restapi/config/ReloadConfig.java b/java/com/google/gerrit/server/restapi/config/ReloadConfig.java index cab07e3ae0..0685a5862e 100644 --- a/java/com/google/gerrit/server/restapi/config/ReloadConfig.java +++ b/java/com/google/gerrit/server/restapi/config/ReloadConfig.java @@ -54,10 +54,7 @@ public class ReloadConfig implements RestModifyView<ConfigResource, Input> { if (updates.isEmpty()) { return Collections.emptyMap(); } - return updates - .asMap() - .entrySet() - .stream() + return updates.asMap().entrySet().stream() .collect( Collectors.toMap( e -> e.getKey().name().toLowerCase(), e -> toEntryInfos(e.getValue()))); @@ -65,8 +62,7 @@ public class ReloadConfig implements RestModifyView<ConfigResource, Input> { private static List<ConfigUpdateEntryInfo> toEntryInfos( Collection<ConfigUpdateEntry> updateEntries) { - return updateEntries - .stream() + return updateEntries.stream() .map(ReloadConfig::toConfigUpdateEntryInfo) .collect(toImmutableList()); } diff --git a/java/com/google/gerrit/server/restapi/group/ListGroups.java b/java/com/google/gerrit/server/restapi/group/ListGroups.java index 968a7dd733..8d8dc3dafb 100644 --- a/java/com/google/gerrit/server/restapi/group/ListGroups.java +++ b/java/com/google/gerrit/server/restapi/group/ListGroups.java @@ -308,8 +308,7 @@ public class ListGroups implements RestReadView<TopLevelResource> { private Stream<GroupReference> getAllExistingGroups() throws IOException, ConfigInvalidException { if (!projects.isEmpty()) { - return projects - .stream() + return projects.stream() .map(ProjectState::getAllGroups) .flatMap(Collection::stream) .distinct(); diff --git a/java/com/google/gerrit/server/restapi/project/DeleteRef.java b/java/com/google/gerrit/server/restapi/project/DeleteRef.java index 9a9ead3cc1..5df102c074 100644 --- a/java/com/google/gerrit/server/restapi/project/DeleteRef.java +++ b/java/com/google/gerrit/server/restapi/project/DeleteRef.java @@ -204,8 +204,7 @@ public class DeleteRef { ImmutableSet<String> refs = prefix == null ? refsToDelete - : refsToDelete - .stream() + : refsToDelete.stream() .map(ref -> ref.startsWith(R_REFS) ? ref : prefix + ref) .collect(toImmutableSet()); for (String ref : refs) { diff --git a/java/com/google/gerrit/server/restapi/project/GetAccess.java b/java/com/google/gerrit/server/restapi/project/GetAccess.java index a6b9404df8..3f7d406ccc 100644 --- a/java/com/google/gerrit/server/restapi/project/GetAccess.java +++ b/java/com/google/gerrit/server/restapi/project/GetAccess.java @@ -275,9 +275,7 @@ public class GetAccess implements RestReadView<ProjectResource> { info.configVisible = canReadConfig || canWriteConfig; info.groups = - groups - .entrySet() - .stream() + groups.entrySet().stream() .filter(e -> e.getValue() != null) .collect(toMap(e -> e.getKey().get(), Map.Entry::getValue)); diff --git a/java/com/google/gerrit/server/restapi/project/ListChildProjects.java b/java/com/google/gerrit/server/restapi/project/ListChildProjects.java index cfeec5a4e1..ea54a4a217 100644 --- a/java/com/google/gerrit/server/restapi/project/ListChildProjects.java +++ b/java/com/google/gerrit/server/restapi/project/ListChildProjects.java @@ -85,12 +85,7 @@ public class ListChildProjects implements RestReadView<ProjectResource> { private List<ProjectInfo> directChildProjects(Project.NameKey parent) throws OrmException, RestApiException { PermissionBackend.WithUser currentUser = permissionBackend.currentUser(); - return queryProvider - .get() - .withQuery("parent:" + parent.get()) - .withLimit(limit) - .apply() - .stream() + return queryProvider.get().withQuery("parent:" + parent.get()).withLimit(limit).apply().stream() .filter( p -> currentUser diff --git a/java/com/google/gerrit/server/restapi/project/ListProjects.java b/java/com/google/gerrit/server/restapi/project/ListProjects.java index c3dec09d04..eccf29e975 100644 --- a/java/com/google/gerrit/server/restapi/project/ListProjects.java +++ b/java/com/google/gerrit/server/restapi/project/ListProjects.java @@ -364,12 +364,7 @@ public class ListProjects implements RestReadView<TopLevelResource> { private SortedMap<String, ProjectInfo> applyAsQuery(String query) throws BadRequestException { try { - return queryProjectsProvider - .get() - .withQuery(query) - .withStart(start) - .withLimit(limit) - .apply() + return queryProjectsProvider.get().withQuery(query).withStart(start).withLimit(limit).apply() .stream() .collect( ImmutableSortedMap.toImmutableSortedMap( @@ -663,9 +658,7 @@ public class ListProjects implements RestReadView<TopLevelResource> { return projectCache.byName(matchPrefix).stream(); } else if (matchSubstring != null) { checkMatchOptions(matchPrefix == null && matchRegex == null); - return projectCache - .all() - .stream() + return projectCache.all().stream() .filter( p -> p.get().toLowerCase(Locale.US).contains(matchSubstring.toLowerCase(Locale.US))); } else if (matchRegex != null) { diff --git a/java/com/google/gerrit/server/rules/DefaultSubmitRule.java b/java/com/google/gerrit/server/rules/DefaultSubmitRule.java index 65ac88fa99..b70858d2c7 100644 --- a/java/com/google/gerrit/server/rules/DefaultSubmitRule.java +++ b/java/com/google/gerrit/server/rules/DefaultSubmitRule.java @@ -124,8 +124,7 @@ public final class DefaultSubmitRule implements SubmitRule { private static List<PatchSetApproval> getApprovalsForLabel( List<PatchSetApproval> approvals, LabelType t) { - return approvals - .stream() + return approvals.stream() .filter(input -> input.getLabel().equals(t.getLabelId().get())) .collect(toImmutableList()); } diff --git a/java/com/google/gerrit/server/rules/IgnoreSelfApprovalRule.java b/java/com/google/gerrit/server/rules/IgnoreSelfApprovalRule.java index b9ddbc6b63..f7c25a488f 100644 --- a/java/com/google/gerrit/server/rules/IgnoreSelfApprovalRule.java +++ b/java/com/google/gerrit/server/rules/IgnoreSelfApprovalRule.java @@ -154,8 +154,7 @@ public class IgnoreSelfApprovalRule implements SubmitRule { @VisibleForTesting static Collection<PatchSetApproval> filterOutPositiveApprovalsOfUser( Collection<PatchSetApproval> approvals, Account.Id user) { - return approvals - .stream() + return approvals.stream() .filter(input -> input.getValue() < 0 || !input.getAccountId().equals(user)) .collect(toImmutableList()); } @@ -163,8 +162,7 @@ public class IgnoreSelfApprovalRule implements SubmitRule { @VisibleForTesting static Collection<PatchSetApproval> filterApprovalsByLabel( Collection<PatchSetApproval> approvals, LabelType t) { - return approvals - .stream() + return approvals.stream() .filter(input -> input.getLabelId().get().equals(t.getLabelId().get())) .collect(toImmutableList()); } diff --git a/java/com/google/gerrit/server/schema/GroupBundle.java b/java/com/google/gerrit/server/schema/GroupBundle.java index 26cd96ada3..4b8bdcc032 100644 --- a/java/com/google/gerrit/server/schema/GroupBundle.java +++ b/java/com/google/gerrit/server/schema/GroupBundle.java @@ -139,17 +139,13 @@ abstract class GroupBundle { return create( Source.NOTE_DB, accountGroup, - internalGroup - .getMembers() - .stream() + internalGroup.getMembers().stream() .map( accountId -> new AccountGroupMember(new AccountGroupMember.Key(accountId, groupId))) .collect(toImmutableSet()), auditLogReader.getMembersAudit(repo, uuid), - internalGroup - .getSubgroups() - .stream() + internalGroup.getSubgroups().stream() .map( subgroupUuid -> new AccountGroupById(new AccountGroupById.Key(groupId, subgroupUuid))) @@ -518,8 +514,7 @@ abstract class GroupBundle { private static ListMultimap<String, AuditEntry> toMemberAuditEntriesByMemberId( ImmutableSet<AccountGroupMemberAudit> memberAudits) { - return memberAudits - .stream() + return memberAudits.stream() .flatMap(GroupBundle::toAuditEntries) .collect( Multimaps.toMultimap( @@ -550,8 +545,7 @@ abstract class GroupBundle { private static ListMultimap<String, AuditEntry> toByIdAuditEntriesById( ImmutableSet<AccountGroupByIdAud> byIdAudits) { - return byIdAudits - .stream() + return byIdAudits.stream() .flatMap(GroupBundle::toAuditEntries) .collect( Multimaps.toMultimap( @@ -587,15 +581,11 @@ abstract class GroupBundle { ListMultimap<String, AuditEntry> noteDbMemberAuditsByTarget) { for (String target : reviewDbMemberAuditsByTarget.keySet()) { ImmutableList<AuditEntry> reviewDbAuditEntries = - reviewDbMemberAuditsByTarget - .get(target) - .stream() + reviewDbMemberAuditsByTarget.get(target).stream() .sorted(AUDIT_ENTRY_COMPARATOR) .collect(toImmutableList()); ImmutableSet<AuditEntry> noteDbAuditEntries = - noteDbMemberAuditsByTarget - .get(target) - .stream() + noteDbMemberAuditsByTarget.get(target).stream() .sorted(AUDIT_ENTRY_COMPARATOR) .collect(toImmutableSet()); diff --git a/java/com/google/gerrit/server/schema/GroupRebuilder.java b/java/com/google/gerrit/server/schema/GroupRebuilder.java index 0157025a87..0b4fd0299a 100644 --- a/java/com/google/gerrit/server/schema/GroupRebuilder.java +++ b/java/com/google/gerrit/server/schema/GroupRebuilder.java @@ -229,16 +229,12 @@ class GroupRebuilder { return b -> b.setMemberModification( in -> - bundle - .members() - .stream() + bundle.members().stream() .map(AccountGroupMember::getAccountId) .collect(toImmutableSet())) .setSubgroupModification( in -> - bundle - .byId() - .stream() + bundle.byId().stream() .map(AccountGroupById::getIncludeUUID) .collect(toImmutableSet())); } diff --git a/java/com/google/gerrit/server/schema/Schema_135.java b/java/com/google/gerrit/server/schema/Schema_135.java index 66224c2915..df3dcaf92b 100644 --- a/java/com/google/gerrit/server/schema/Schema_135.java +++ b/java/com/google/gerrit/server/schema/Schema_135.java @@ -76,11 +76,8 @@ public class Schema_135 extends SchemaVersion { Set<GroupReference> groups = Stream.concat( - config - .getAccessSection(AccessSection.GLOBAL_CAPABILITIES, true) - .getPermission(GlobalCapability.ADMINISTRATE_SERVER, true) - .getRules() - .stream() + config.getAccessSection(AccessSection.GLOBAL_CAPABILITIES, true) + .getPermission(GlobalCapability.ADMINISTRATE_SERVER, true).getRules().stream() .map(PermissionRule::getGroup), Stream.of(systemGroupBackend.getGroup(PROJECT_OWNERS))) .filter(g -> createRefsMetaConfigPermission.getRule(g) == null) diff --git a/java/com/google/gerrit/server/schema/Schema_147.java b/java/com/google/gerrit/server/schema/Schema_147.java index c507fa65a4..d93daa1ca5 100644 --- a/java/com/google/gerrit/server/schema/Schema_147.java +++ b/java/com/google/gerrit/server/schema/Schema_147.java @@ -55,9 +55,7 @@ public class Schema_147 extends SchemaVersion { try (Repository repo = repoManager.openRepository(allUsersName)) { Set<Account.Id> accountIdsFromReviewDb = scanAccounts(db); Set<Account.Id> accountIdsFromUserBranches = - repo.getRefDatabase() - .getRefsByPrefix(RefNames.REFS_USERS) - .stream() + repo.getRefDatabase().getRefsByPrefix(RefNames.REFS_USERS).stream() .map(r -> Account.Id.fromRef(r.getName())) .filter(Objects::nonNull) .collect(toSet()); diff --git a/java/com/google/gerrit/server/schema/Schema_154.java b/java/com/google/gerrit/server/schema/Schema_154.java index fab1693133..11fa89e653 100644 --- a/java/com/google/gerrit/server/schema/Schema_154.java +++ b/java/com/google/gerrit/server/schema/Schema_154.java @@ -125,9 +125,7 @@ public class Schema_154 extends SchemaVersion { JdbcSchema schema = (JdbcSchema) db; Connection connection = schema.getConnection(); Set<String> columns = schema.getDialect().listColumns(connection, TABLE); - return ACCOUNT_FIELDS_MAP - .entrySet() - .stream() + return ACCOUNT_FIELDS_MAP.entrySet().stream() .filter(e -> columns.contains(e.getKey())) .collect(toMap(Map.Entry::getKey, Map.Entry::getValue)); } diff --git a/java/com/google/gerrit/server/schema/Schema_161.java b/java/com/google/gerrit/server/schema/Schema_161.java index 3077720ef0..70010f830d 100644 --- a/java/com/google/gerrit/server/schema/Schema_161.java +++ b/java/com/google/gerrit/server/schema/Schema_161.java @@ -77,9 +77,7 @@ public class Schema_161 extends SchemaVersion { starRef.labels(), StarredChangesUtil.UNREVIEWED_LABEL); List<String> newLabels = - starRef - .labels() - .stream() + starRef.labels().stream() .map( l -> { if (l.startsWith(MUTE_LABEL)) { diff --git a/java/com/google/gerrit/server/submit/CommitMergeStatus.java b/java/com/google/gerrit/server/submit/CommitMergeStatus.java index 3c7b986165..3163bd21e9 100644 --- a/java/com/google/gerrit/server/submit/CommitMergeStatus.java +++ b/java/com/google/gerrit/server/submit/CommitMergeStatus.java @@ -105,8 +105,7 @@ public enum CommitMergeStatus { commit, otherCommit, cd.getId().get()); } Optional<PatchSet> patchSet = - cd.patchSets() - .stream() + cd.patchSets().stream() .filter(ps -> ps.getRevision().get().equals(otherCommit)) .findAny(); if (patchSet.isPresent()) { diff --git a/java/com/google/gerrit/server/submit/MergeOp.java b/java/com/google/gerrit/server/submit/MergeOp.java index e27863f993..572da0bdca 100644 --- a/java/com/google/gerrit/server/submit/MergeOp.java +++ b/java/com/google/gerrit/server/submit/MergeOp.java @@ -339,9 +339,7 @@ public class MergeOp implements AutoCloseable { blockingConditions.add(describeLabels(cd, record.labels)); } if (record.requirements != null) { - record - .requirements - .stream() + record.requirements.stream() .map(SubmitRequirement::fallbackText) .forEach(blockingConditions::add); } diff --git a/java/com/google/gerrit/server/submit/SubmoduleOp.java b/java/com/google/gerrit/server/submit/SubmoduleOp.java index 50be62afb8..d3a578f44c 100644 --- a/java/com/google/gerrit/server/submit/SubmoduleOp.java +++ b/java/com/google/gerrit/server/submit/SubmoduleOp.java @@ -456,9 +456,7 @@ public class SubmoduleOp { int count = 0; List<SubmoduleSubscription> subscriptions = - targets - .get(subscriber) - .stream() + targets.get(subscriber).stream() .sorted(comparing(SubmoduleSubscription::getPath)) .collect(toList()); for (SubmoduleSubscription s : subscriptions) { diff --git a/java/com/google/gerrit/server/update/NoteDbBatchUpdate.java b/java/com/google/gerrit/server/update/NoteDbBatchUpdate.java index d881b0fe85..a0c425f480 100644 --- a/java/com/google/gerrit/server/update/NoteDbBatchUpdate.java +++ b/java/com/google/gerrit/server/update/NoteDbBatchUpdate.java @@ -139,8 +139,7 @@ public class NoteDbBatchUpdate extends BatchUpdate { // Fire ref update events only after all mutations are finished, since callers may assume a // patch set ref being created means the change was created, or a branch advancing meaning // some changes were closed. - updates - .stream() + updates.stream() .filter(u -> u.batchRefUpdate != null) .forEach( u -> u.gitRefUpdated.fire(u.project, u.batchRefUpdate, u.getAccount().orElse(null))); diff --git a/java/com/google/gerrit/server/update/RepoView.java b/java/com/google/gerrit/server/update/RepoView.java index 6b1ffa558a..9ce842f792 100644 --- a/java/com/google/gerrit/server/update/RepoView.java +++ b/java/com/google/gerrit/server/update/RepoView.java @@ -137,9 +137,7 @@ public class RepoView { */ public Map<String, ObjectId> getRefs(String prefix) throws IOException { Map<String, ObjectId> result = - repo.getRefDatabase() - .getRefsByPrefix(prefix) - .stream() + repo.getRefDatabase().getRefsByPrefix(prefix).stream() .collect(toMap(r -> r.getName().substring(prefix.length()), Ref::getObjectId)); // First, overwrite any cached reads from the underlying RepoRefCache. If any of these differ, diff --git a/java/com/google/gerrit/server/update/ReviewDbBatchUpdate.java b/java/com/google/gerrit/server/update/ReviewDbBatchUpdate.java index c06447d337..c67ee8a35a 100644 --- a/java/com/google/gerrit/server/update/ReviewDbBatchUpdate.java +++ b/java/com/google/gerrit/server/update/ReviewDbBatchUpdate.java @@ -284,8 +284,7 @@ public class ReviewDbBatchUpdate extends BatchUpdate { // Fire ref update events only after all mutations are finished, since callers may assume a // patch set ref being created means the change was created, or a branch advancing meaning // some changes were closed. - updates - .stream() + updates.stream() .filter(u -> u.batchRefUpdate != null) .forEach( u -> u.gitRefUpdated.fire(u.project, u.batchRefUpdate, u.getAccount().orElse(null))); diff --git a/java/com/google/gerrit/sshd/commands/SetMembersCommand.java b/java/com/google/gerrit/sshd/commands/SetMembersCommand.java index 9d7f2d93f0..324257b93a 100644 --- a/java/com/google/gerrit/sshd/commands/SetMembersCommand.java +++ b/java/com/google/gerrit/sshd/commands/SetMembersCommand.java @@ -132,8 +132,7 @@ public class SetMembersCommand extends SshCommand { String action, GroupResource group, List<Account.Id> accountIdList) throws UnsupportedEncodingException, IOException { String names = - accountIdList - .stream() + accountIdList.stream() .map( accountId -> { Optional<AccountState> accountState = accountCache.get(accountId); @@ -152,8 +151,7 @@ public class SetMembersCommand extends SshCommand { String action, GroupResource group, List<AccountGroup.UUID> groupUuidList) throws UnsupportedEncodingException, IOException { String names = - groupUuidList - .stream() + groupUuidList.stream() .map(uuid -> groupCache.get(uuid).map(InternalGroup::getName)) .flatMap(Streams::stream) .collect(joining(", ")); diff --git a/java/com/google/gerrit/sshd/commands/ShowConnections.java b/java/com/google/gerrit/sshd/commands/ShowConnections.java index 0faf8030ad..d579ef68a7 100644 --- a/java/com/google/gerrit/sshd/commands/ShowConnections.java +++ b/java/com/google/gerrit/sshd/commands/ShowConnections.java @@ -91,10 +91,7 @@ final class ShowConnections extends SshCommand { } final ImmutableList<IoSession> list = - acceptor - .getManagedSessions() - .values() - .stream() + acceptor.getManagedSessions().values().stream() .sorted( (arg0, arg1) -> { if (arg0 instanceof MinaSession) { diff --git a/java/com/google/gerrit/testing/FakeEmailSender.java b/java/com/google/gerrit/testing/FakeEmailSender.java index e81d0f45b1..dbb83c086c 100644 --- a/java/com/google/gerrit/testing/FakeEmailSender.java +++ b/java/com/google/gerrit/testing/FakeEmailSender.java @@ -150,8 +150,7 @@ public class FakeEmailSender implements EmailSender { public List<Message> getMessages(String changeId, String type) { final String idFooter = "\n" + MailHeader.CHANGE_ID.withDelimiter() + changeId + "\n"; final String typeFooter = "\n" + MailHeader.MESSAGE_TYPE.withDelimiter() + type + "\n"; - return getMessages() - .stream() + return getMessages().stream() .filter(in -> in.body().contains(idFooter) && in.body().contains(typeFooter)) .collect(toList()); } diff --git a/java/com/google/gerrit/testing/IndexVersions.java b/java/com/google/gerrit/testing/IndexVersions.java index fde93b24f1..3281ffc71f 100644 --- a/java/com/google/gerrit/testing/IndexVersions.java +++ b/java/com/google/gerrit/testing/IndexVersions.java @@ -131,8 +131,7 @@ public class IndexVersions { List<Integer> schemaVersions, String testSuiteNamePrefix, Config baseConfig) { - return schemaVersions - .stream() + return schemaVersions.stream() .collect( toMap( i -> testSuiteNamePrefix + i, diff --git a/javatests/com/google/gerrit/acceptance/api/accounts/AccountIT.java b/javatests/com/google/gerrit/acceptance/api/accounts/AccountIT.java index 83c180956c..775bfcf0a0 100644 --- a/javatests/com/google/gerrit/acceptance/api/accounts/AccountIT.java +++ b/javatests/com/google/gerrit/acceptance/api/accounts/AccountIT.java @@ -912,10 +912,7 @@ public class AccountIT extends AbstractDaemonTest { gApi.accounts().id(foo.id.hashCode()).addEmail(input); assertThat( - gApi.accounts() - .id(foo.id.get()) - .getEmails() - .stream() + gApi.accounts().id(foo.id.get()).getEmails().stream() .map(e -> e.email) .collect(toSet())) .containsExactly(email, secondaryEmail); @@ -2494,10 +2491,7 @@ public class AccountIT extends AbstractDaemonTest { assertThat(bgCounterA1.get()).isEqualTo(0); assertThat(bgCounterA2.get()).isEqualTo(0); assertThat( - gApi.accounts() - .id(accountId.get()) - .getExternalIds() - .stream() + gApi.accounts().id(accountId.get()).getExternalIds().stream() .map(i -> i.identity) .collect(toSet())) .containsExactly(extIdA1.key().get()); @@ -2527,10 +2521,7 @@ public class AccountIT extends AbstractDaemonTest { assertThat(updatedAccount.get().getExternalIds()).containsExactly(extIdB2); assertThat(accounts.get(accountId).get().getExternalIds()).containsExactly(extIdB2); assertThat( - gApi.accounts() - .id(accountId.get()) - .getExternalIds() - .stream() + gApi.accounts().id(accountId.get()).getExternalIds().stream() .map(i -> i.identity) .collect(toSet())) .containsExactly(extIdB2.key().get()); @@ -2757,11 +2748,7 @@ public class AccountIT extends AbstractDaemonTest { setApiUser(testAccount); for (ChangeInfo changeInfo : gApi.changes().query("has:draft").get()) { for (CommentInfo c : - gApi.changes() - .id(changeInfo.id) - .drafts() - .values() - .stream() + gApi.changes().id(changeInfo.id).drafts().values().stream() .flatMap(List::stream) .collect(toImmutableList())) { gApi.changes().id(changeInfo.id).revision(c.patchSet).draft(c.id).delete(); @@ -2849,9 +2836,7 @@ public class AccountIT extends AbstractDaemonTest { Iterable<String> expectedFps = expected.transform(k -> BaseEncoding.base16().encode(k.getPublicKey().getFingerprint())); Iterable<String> actualFps = - externalIds - .byAccount(currAccountId, SCHEME_GPGKEY) - .stream() + externalIds.byAccount(currAccountId, SCHEME_GPGKEY).stream() .map(e -> e.key().id()) .collect(toSet()); assertThat(actualFps).named("external IDs in database").containsExactlyElementsIn(expectedFps); diff --git a/javatests/com/google/gerrit/acceptance/api/change/ChangeIT.java b/javatests/com/google/gerrit/acceptance/api/change/ChangeIT.java index da513e90ba..be4b2e147d 100644 --- a/javatests/com/google/gerrit/acceptance/api/change/ChangeIT.java +++ b/javatests/com/google/gerrit/acceptance/api/change/ChangeIT.java @@ -3872,9 +3872,7 @@ public class ChangeIT extends AbstractDaemonTest { throws Exception { ChangeInfo c = gApi.changes().id(changeId).get(DETAILED_LABELS); Set<ReviewerState> states = - c.reviewers - .entrySet() - .stream() + c.reviewers.entrySet().stream() .filter(e -> e.getValue().stream().anyMatch(a -> a._accountId == accountId.get())) .map(Map.Entry::getKey) .collect(toSet()); diff --git a/javatests/com/google/gerrit/acceptance/api/project/CheckProjectIT.java b/javatests/com/google/gerrit/acceptance/api/project/CheckProjectIT.java index 6c6ad3d23c..3b2df797c9 100644 --- a/javatests/com/google/gerrit/acceptance/api/project/CheckProjectIT.java +++ b/javatests/com/google/gerrit/acceptance/api/project/CheckProjectIT.java @@ -78,10 +78,7 @@ public class CheckProjectIT extends AbstractDaemonTest { CheckProjectResultInfo checkResult = gApi.projects().name(project.get()).check(checkProjectInputForAutoCloseableCheck(branch)); assertThat( - checkResult - .autoCloseableChangesCheckResult - .autoCloseableChanges - .stream() + checkResult.autoCloseableChangesCheckResult.autoCloseableChanges.stream() .map(i -> i._number) .collect(toList())) .containsExactly(change._number); @@ -106,10 +103,7 @@ public class CheckProjectIT extends AbstractDaemonTest { input.autoCloseableChangesCheck.fix = true; CheckProjectResultInfo checkResult = gApi.projects().name(project.get()).check(input); assertThat( - checkResult - .autoCloseableChangesCheckResult - .autoCloseableChanges - .stream() + checkResult.autoCloseableChangesCheckResult.autoCloseableChanges.stream() .map(i -> i._number) .collect(toSet())) .containsExactly(change._number); @@ -132,10 +126,7 @@ public class CheckProjectIT extends AbstractDaemonTest { CheckProjectResultInfo checkResult = gApi.projects().name(project.get()).check(checkProjectInputForAutoCloseableCheck(branch)); assertThat( - checkResult - .autoCloseableChangesCheckResult - .autoCloseableChanges - .stream() + checkResult.autoCloseableChangesCheckResult.autoCloseableChanges.stream() .map(i -> i._number) .collect(toSet())) .containsExactly(r.getChange().getId().get()); @@ -159,10 +150,7 @@ public class CheckProjectIT extends AbstractDaemonTest { input.autoCloseableChangesCheck.fix = true; CheckProjectResultInfo checkResult = gApi.projects().name(project.get()).check(input); assertThat( - checkResult - .autoCloseableChangesCheckResult - .autoCloseableChanges - .stream() + checkResult.autoCloseableChangesCheckResult.autoCloseableChanges.stream() .map(i -> i._number) .collect(toSet())) .containsExactly(r.getChange().getId().get()); @@ -196,10 +184,7 @@ public class CheckProjectIT extends AbstractDaemonTest { input.autoCloseableChangesCheck.maxCommits = 2; checkResult = gApi.projects().name(project.get()).check(input); assertThat( - checkResult - .autoCloseableChangesCheckResult - .autoCloseableChanges - .stream() + checkResult.autoCloseableChangesCheckResult.autoCloseableChanges.stream() .map(i -> i._number) .collect(toSet())) .containsExactly(r.getChange().getId().get()); @@ -233,10 +218,7 @@ public class CheckProjectIT extends AbstractDaemonTest { input.autoCloseableChangesCheck.skipCommits = 1; checkResult = gApi.projects().name(project.get()).check(input); assertThat( - checkResult - .autoCloseableChangesCheckResult - .autoCloseableChanges - .stream() + checkResult.autoCloseableChangesCheckResult.autoCloseableChanges.stream() .map(i -> i._number) .collect(toSet())) .containsExactly(r.getChange().getId().get()); diff --git a/javatests/com/google/gerrit/acceptance/api/revision/RevisionIT.java b/javatests/com/google/gerrit/acceptance/api/revision/RevisionIT.java index 86908cbb97..b058d5e7bf 100644 --- a/javatests/com/google/gerrit/acceptance/api/revision/RevisionIT.java +++ b/javatests/com/google/gerrit/acceptance/api/revision/RevisionIT.java @@ -225,11 +225,7 @@ public class RevisionIT extends AbstractDaemonTest { setApiUser(admin); gApi.changes().id(changeId).reviewer(user.username).deleteVote("Code-Review"); Optional<ApprovalInfo> crUser = - get(changeId, DETAILED_LABELS) - .labels - .get("Code-Review") - .all - .stream() + get(changeId, DETAILED_LABELS).labels.get("Code-Review").all.stream() .filter(a -> a._accountId == user.id.get()) .findFirst(); assertThat(crUser).isPresent(); @@ -244,13 +240,7 @@ public class RevisionIT extends AbstractDaemonTest { revision(r).review(in); ApprovalInfo cr = - gApi.changes() - .id(changeId) - .get(DETAILED_LABELS) - .labels - .get("Code-Review") - .all - .stream() + gApi.changes().id(changeId).get(DETAILED_LABELS).labels.get("Code-Review").all.stream() .filter(a -> a._accountId == user.getId().get()) .findFirst() .get(); diff --git a/javatests/com/google/gerrit/acceptance/api/revision/RobotCommentsIT.java b/javatests/com/google/gerrit/acceptance/api/revision/RobotCommentsIT.java index cd20765940..dfd25e25cb 100644 --- a/javatests/com/google/gerrit/acceptance/api/revision/RobotCommentsIT.java +++ b/javatests/com/google/gerrit/acceptance/api/revision/RobotCommentsIT.java @@ -1140,8 +1140,7 @@ public class RobotCommentsIT extends AbstractDaemonTest { private static List<String> getFixIds(List<RobotCommentInfo> robotComments) { assertThatList(robotComments).isNotNull(); - return robotComments - .stream() + return robotComments.stream() .map(robotCommentInfo -> robotCommentInfo.fixSuggestions) .filter(Objects::nonNull) .flatMap(List::stream) diff --git a/javatests/com/google/gerrit/acceptance/git/AbstractPushForReview.java b/javatests/com/google/gerrit/acceptance/git/AbstractPushForReview.java index 015dd31028..12266614c2 100644 --- a/javatests/com/google/gerrit/acceptance/git/AbstractPushForReview.java +++ b/javatests/com/google/gerrit/acceptance/git/AbstractPushForReview.java @@ -590,8 +590,7 @@ public abstract class AbstractPushForReview extends AbstractDaemonTest { ChangeInfo ci = get(r.getChangeId(), DETAILED_LABELS); ImmutableList<AccountInfo> ccs = - firstNonNull(ci.reviewers.get(ReviewerState.CC), ImmutableList.<AccountInfo>of()) - .stream() + firstNonNull(ci.reviewers.get(ReviewerState.CC), ImmutableList.<AccountInfo>of()).stream() .sorted(comparing((AccountInfo a) -> a.email)) .collect(toImmutableList()); assertThat(ccs).hasSize(2); @@ -2059,9 +2058,7 @@ public abstract class AbstractPushForReview extends AbstractDaemonTest { assertThat(getLastMessage(r.getChangeId())).isEqualTo("Uploaded patch set 3.\n\n(3 comments)"); List<String> messages = - sender - .getMessages() - .stream() + sender.getMessages().stream() .map(Message::body) .sorted(Comparator.comparingInt(m -> m.contains("reexamine") ? 0 : 1)) .collect(toList()); @@ -2330,11 +2327,7 @@ public abstract class AbstractPushForReview extends AbstractDaemonTest { } private Collection<CommentInfo> getPublishedComments(String changeId) throws Exception { - return gApi.changes() - .id(changeId) - .comments() - .values() - .stream() + return gApi.changes().id(changeId).comments().values().stream() .flatMap(Collection::stream) .collect(toList()); } diff --git a/javatests/com/google/gerrit/acceptance/git/PushPermissionsIT.java b/javatests/com/google/gerrit/acceptance/git/PushPermissionsIT.java index 907ad7f2b6..30e179d31d 100644 --- a/javatests/com/google/gerrit/acceptance/git/PushPermissionsIT.java +++ b/javatests/com/google/gerrit/acceptance/git/PushPermissionsIT.java @@ -340,8 +340,7 @@ public class PushPermissionsIT extends AbstractDaemonTest { } private static void removeAllBranchPermissions(ProjectConfig cfg, String... permissions) { - cfg.getAccessSections() - .stream() + cfg.getAccessSections().stream() .filter( s -> s.getName().startsWith("refs/heads/") diff --git a/javatests/com/google/gerrit/acceptance/pgm/AbstractReindexTests.java b/javatests/com/google/gerrit/acceptance/pgm/AbstractReindexTests.java index c166acfb85..c07d512946 100644 --- a/javatests/com/google/gerrit/acceptance/pgm/AbstractReindexTests.java +++ b/javatests/com/google/gerrit/acceptance/pgm/AbstractReindexTests.java @@ -76,11 +76,7 @@ public abstract class AbstractReindexTests extends StandaloneSiteTest { .containsExactly(adminId.get()); // Query group index assertThat( - gApi.groups() - .query("Group") - .withOption(MEMBERS) - .get() - .stream() + gApi.groups().query("Group").withOption(MEMBERS).get().stream() .flatMap(g -> g.members.stream()) .map(a -> a._accountId)) .containsExactly(adminId.get()); @@ -271,10 +267,7 @@ public abstract class AbstractReindexTests extends StandaloneSiteTest { private void assertWriteVersions(ServerContext ctx, Integer... expected) { assertThat( - ctx.getInjector() - .getInstance(ChangeIndexCollection.class) - .getWriteIndexes() - .stream() + ctx.getInjector().getInstance(ChangeIndexCollection.class).getWriteIndexes().stream() .map(i -> i.getSchema().getVersion())) .named("write versions") .containsExactlyElementsIn(ImmutableSet.copyOf(expected)); diff --git a/javatests/com/google/gerrit/acceptance/rest/ChangesRestApiBindingsIT.java b/javatests/com/google/gerrit/acceptance/rest/ChangesRestApiBindingsIT.java index 59c0903452..c00c2aad40 100644 --- a/javatests/com/google/gerrit/acceptance/rest/ChangesRestApiBindingsIT.java +++ b/javatests/com/google/gerrit/acceptance/rest/ChangesRestApiBindingsIT.java @@ -499,8 +499,7 @@ public class ChangesRestApiBindingsIT extends AbstractRestApiBindingsTest { private static List<String> getFixIds(List<RobotCommentInfo> robotComments) { assertThatList(robotComments).isNotNull(); - return robotComments - .stream() + return robotComments.stream() .map(robotCommentInfo -> robotCommentInfo.fixSuggestions) .filter(Objects::nonNull) .flatMap(List::stream) diff --git a/javatests/com/google/gerrit/acceptance/rest/ConfigRestApiBindingsIT.java b/javatests/com/google/gerrit/acceptance/rest/ConfigRestApiBindingsIT.java index 508d407edf..4a2c81b6aa 100644 --- a/javatests/com/google/gerrit/acceptance/rest/ConfigRestApiBindingsIT.java +++ b/javatests/com/google/gerrit/acceptance/rest/ConfigRestApiBindingsIT.java @@ -99,8 +99,7 @@ public class ConfigRestApiBindingsIT extends AbstractRestApiBindingsTest { r.consume(); Optional<String> id = - result - .stream() + result.stream() .filter(t -> "Log File Compressor".equals(t.command)) .map(t -> t.id) .findFirst(); diff --git a/javatests/com/google/gerrit/acceptance/rest/change/SuggestReviewersIT.java b/javatests/com/google/gerrit/acceptance/rest/change/SuggestReviewersIT.java index 4d499f0c4a..b0a89c35a0 100644 --- a/javatests/com/google/gerrit/acceptance/rest/change/SuggestReviewersIT.java +++ b/javatests/com/google/gerrit/acceptance/rest/change/SuggestReviewersIT.java @@ -530,8 +530,7 @@ public class SuggestReviewersIT extends AbstractDaemonTest { List<TestAccount> expectedUsers, List<InternalGroup> expectedGroups) { List<Integer> actualAccountIds = - actual - .stream() + actual.stream() .filter(i -> i.account != null) .map(i -> i.account._accountId) .collect(toList()); diff --git a/javatests/com/google/gerrit/acceptance/rest/config/KillTaskIT.java b/javatests/com/google/gerrit/acceptance/rest/config/KillTaskIT.java index c19f5d021c..2a891aad0a 100644 --- a/javatests/com/google/gerrit/acceptance/rest/config/KillTaskIT.java +++ b/javatests/com/google/gerrit/acceptance/rest/config/KillTaskIT.java @@ -36,8 +36,7 @@ public class KillTaskIT extends AbstractDaemonTest { r.consume(); Optional<String> id = - result - .stream() + result.stream() .filter(t -> "Log File Compressor".equals(t.command)) .map(t -> t.id) .findFirst(); diff --git a/javatests/com/google/gerrit/acceptance/server/change/CommentsIT.java b/javatests/com/google/gerrit/acceptance/server/change/CommentsIT.java index 736b7659c8..e9d2611143 100644 --- a/javatests/com/google/gerrit/acceptance/server/change/CommentsIT.java +++ b/javatests/com/google/gerrit/acceptance/server/change/CommentsIT.java @@ -960,9 +960,7 @@ public class CommentsIT extends AbstractDaemonTest { } private List<CommentInfo> getRevisionComments(String changeId, String revId) throws Exception { - return getPublishedComments(changeId, revId) - .values() - .stream() + return getPublishedComments(changeId, revId).values().stream() .flatMap(List::stream) .collect(toList()); } diff --git a/javatests/com/google/gerrit/acceptance/server/change/PatchListCacheIT.java b/javatests/com/google/gerrit/acceptance/server/change/PatchListCacheIT.java index 580b5decd8..18925665a7 100644 --- a/javatests/com/google/gerrit/acceptance/server/change/PatchListCacheIT.java +++ b/javatests/com/google/gerrit/acceptance/server/change/PatchListCacheIT.java @@ -296,9 +296,7 @@ public class PatchListCacheIT extends AbstractDaemonTest { private static PatchListEntry getEntryFor(PatchList patchList, String filePath) { Optional<PatchListEntry> patchListEntry = - patchList - .getPatches() - .stream() + patchList.getPatches().stream() .filter(entry -> entry.getNewName().equals(filePath)) .findAny(); return patchListEntry.orElseThrow( diff --git a/javatests/com/google/gerrit/acceptance/server/notedb/ChangeRebuilderIT.java b/javatests/com/google/gerrit/acceptance/server/notedb/ChangeRebuilderIT.java index 29f1b7dfc3..5ebfa9e926 100644 --- a/javatests/com/google/gerrit/acceptance/server/notedb/ChangeRebuilderIT.java +++ b/javatests/com/google/gerrit/acceptance/server/notedb/ChangeRebuilderIT.java @@ -1412,11 +1412,7 @@ public class ChangeRebuilderIT extends AbstractDaemonTest { CommentInfo draftInfo = putDraft(user, id, 1, "draft comment", null, Side.PARENT); putComment(user, id, 1, "published comment", null, Side.PARENT); CommentInfo commentInfo = - gApi.changes() - .id(id.get()) - .comments() - .values() - .stream() + gApi.changes().id(id.get()).comments().values().stream() .flatMap(List::stream) .findFirst() .get(); diff --git a/javatests/com/google/gerrit/acceptance/server/notedb/NoteDbOnlyIT.java b/javatests/com/google/gerrit/acceptance/server/notedb/NoteDbOnlyIT.java index 8d6fecdfc4..f4cedbb957 100644 --- a/javatests/com/google/gerrit/acceptance/server/notedb/NoteDbOnlyIT.java +++ b/javatests/com/google/gerrit/acceptance/server/notedb/NoteDbOnlyIT.java @@ -295,11 +295,7 @@ public class NoteDbOnlyIT extends AbstractDaemonTest { } private List<String> getMessages(Change.Id id) throws Exception { - return gApi.changes() - .id(id.get()) - .get(MESSAGES) - .messages - .stream() + return gApi.changes().id(id.get()).get(MESSAGES).messages.stream() .map(m -> m.message) .collect(toList()); } diff --git a/javatests/com/google/gerrit/acceptance/server/notedb/NoteDbPrimaryIT.java b/javatests/com/google/gerrit/acceptance/server/notedb/NoteDbPrimaryIT.java index 26d546184a..486a0de55a 100644 --- a/javatests/com/google/gerrit/acceptance/server/notedb/NoteDbPrimaryIT.java +++ b/javatests/com/google/gerrit/acceptance/server/notedb/NoteDbPrimaryIT.java @@ -267,8 +267,7 @@ public class NoteDbPrimaryIT extends AbstractDaemonTest { fail("expected read-only exception"); } catch (RestApiException e) { Optional<Throwable> oe = - Throwables.getCausalChain(e) - .stream() + Throwables.getCausalChain(e).stream() .filter(x -> x instanceof OrmRuntimeException) .findFirst(); assertThat(oe).named("OrmRuntimeException in causal chain of " + e).isPresent(); @@ -511,12 +510,7 @@ public class NoteDbPrimaryIT extends AbstractDaemonTest { } private List<Account.Id> getReviewers(Change.Id id) throws Exception { - return gApi.changes() - .id(id.get()) - .get() - .reviewers - .values() - .stream() + return gApi.changes().id(id.get()).get().reviewers.values().stream() .flatMap(Collection::stream) .map(a -> new Account.Id(a._accountId)) .collect(toList()); diff --git a/javatests/com/google/gerrit/server/index/change/ChangeFieldTest.java b/javatests/com/google/gerrit/server/index/change/ChangeFieldTest.java index d3792b73bb..758c304822 100644 --- a/javatests/com/google/gerrit/server/index/change/ChangeFieldTest.java +++ b/javatests/com/google/gerrit/server/index/change/ChangeFieldTest.java @@ -150,8 +150,7 @@ public class ChangeFieldTest extends GerritBaseTests { private static void assertStoredRecordRoundTrip(SubmitRecord... records) { List<SubmitRecord> recordList = ImmutableList.copyOf(records); List<String> stored = - ChangeField.storedSubmitRecords(recordList) - .stream() + ChangeField.storedSubmitRecords(recordList).stream() .map(s -> new String(s, UTF_8)) .collect(toList()); assertThat(ChangeField.parseSubmitRecords(stored)) diff --git a/javatests/com/google/gerrit/server/notedb/CommentJsonMigratorTest.java b/javatests/com/google/gerrit/server/notedb/CommentJsonMigratorTest.java index b9027bc175..dee61814c1 100644 --- a/javatests/com/google/gerrit/server/notedb/CommentJsonMigratorTest.java +++ b/javatests/com/google/gerrit/server/notedb/CommentJsonMigratorTest.java @@ -481,10 +481,7 @@ public class CommentJsonMigratorTest extends AbstractChangeNotesTest { reader, noteMap, status); - return revNoteMap - .revisionNotes - .values() - .stream() + return revNoteMap.revisionNotes.values().stream() .flatMap(crn -> crn.getComments().stream()) .collect(toImmutableMap(c -> c.key, c -> c.legacyFormat)); } diff --git a/javatests/com/google/gerrit/server/project/CommitsCollectionTest.java b/javatests/com/google/gerrit/server/project/CommitsCollectionTest.java index b39208a339..07f64a8cae 100644 --- a/javatests/com/google/gerrit/server/project/CommitsCollectionTest.java +++ b/javatests/com/google/gerrit/server/project/CommitsCollectionTest.java @@ -220,9 +220,7 @@ public class CommitsCollectionTest { .getAccessSection(AccessSection.GLOBAL_CAPABILITIES) .getPermission(GlobalCapability.ADMINISTRATE_SERVER); - return adminPermission - .getRules() - .stream() + return adminPermission.getRules().stream() .map(PermissionRule::getGroup) .map(GroupReference::getUUID) .collect(ImmutableList.toImmutableList()); diff --git a/javatests/com/google/gerrit/server/query/change/AbstractQueryChangesTest.java b/javatests/com/google/gerrit/server/query/change/AbstractQueryChangesTest.java index 7cf148d182..c01bf0438c 100644 --- a/javatests/com/google/gerrit/server/query/change/AbstractQueryChangesTest.java +++ b/javatests/com/google/gerrit/server/query/change/AbstractQueryChangesTest.java @@ -561,8 +561,7 @@ public abstract class AbstractQueryChangesTest extends GerritServerTests { // Convert AccountInfos to strings, either account ID or email. List<String> reviewerIds = - reviewers - .stream() + reviewers.stream() .map( ai -> { if (ai._accountId != null) { @@ -2102,10 +2101,7 @@ public abstract class AbstractQueryChangesTest extends GerritServerTests { gApi.groups().id(group).addMembers(user2.toString(), user3.toString()); List<String> members = - gApi.groups() - .id(group) - .members() - .stream() + gApi.groups().id(group).members().stream() .map(a -> a._accountId.toString()) .collect(toList()); assertThat(members).contains(user2.toString()); @@ -2515,8 +2511,7 @@ public abstract class AbstractQueryChangesTest extends GerritServerTests { expectedStates.add("All-Users:refs/draft-comments/" + cs + "/" + u); } assertThat( - cd.getRefStates() - .stream() + cd.getRefStates().stream() .map(String::new) // Omit SHA-1, we're just concerned with the project/ref names. .map(s -> s.substring(0, s.lastIndexOf(':'))) diff --git a/javatests/com/google/gerrit/server/query/project/AbstractQueryProjectsTest.java b/javatests/com/google/gerrit/server/query/project/AbstractQueryProjectsTest.java index 3855b03798..7872b444a4 100644 --- a/javatests/com/google/gerrit/server/query/project/AbstractQueryProjectsTest.java +++ b/javatests/com/google/gerrit/server/query/project/AbstractQueryProjectsTest.java @@ -210,10 +210,7 @@ public abstract class AbstractQueryProjectsTest extends GerritServerTests { public void byParentOfAllProjects() throws Exception { Set<String> excludedProjects = ImmutableSet.of(allProjects.get(), allUsers.get()); ProjectInfo[] projects = - gApi.projects() - .list() - .get() - .stream() + gApi.projects().list().get().stream() .filter(p -> !excludedProjects.contains(p.name)) .toArray(s -> new ProjectInfo[s]); assertQuery("parent:" + allProjects.get(), projects); diff --git a/javatests/com/google/gerrit/server/schema/Schema_159_to_160_Test.java b/javatests/com/google/gerrit/server/schema/Schema_159_to_160_Test.java index 0080f3f692..9bd20841b4 100644 --- a/javatests/com/google/gerrit/server/schema/Schema_159_to_160_Test.java +++ b/javatests/com/google/gerrit/server/schema/Schema_159_to_160_Test.java @@ -191,8 +191,7 @@ public class Schema_159_to_160_Test { VersionedAccountPreferences prefs = prefsSupplier.get(); prefs.load(allUsersName, repo); Config cfg = prefs.getConfig(); - return cfg.getSubsections(MY) - .stream() + return cfg.getSubsections(MY).stream() .collect(toImmutableMap(i -> i, i -> cfg.getString(MY, i, KEY_URL))); } } diff --git a/plugins/singleusergroup b/plugins/singleusergroup -Subproject 0f798f61c0c598c1499cbaacc1c609078c8bf0d +Subproject ae9a9ab370d8026ad809a73b4dae3fb7d79ad8a diff --git a/tools/setup_gjf.sh b/tools/setup_gjf.sh index c450811f62..119f9af3d7 100755 --- a/tools/setup_gjf.sh +++ b/tools/setup_gjf.sh @@ -17,7 +17,7 @@ set -eu # Keep this version in sync with dev-contributing.txt. -VERSION=${1:-1.6} +VERSION=${1:-1.7} case "$VERSION" in 1.3) |