diff options
author | Bob Foerster <robert@erafx.com> | 2012-02-02 16:50:08 -0500 |
---|---|---|
committer | Edwin Kempin <edwin.kempin@sap.com> | 2012-02-08 06:31:48 +0100 |
commit | 2330cf8ccd2491b8b6a09c653fac69b853c6c38b (patch) | |
tree | b26e0bd450ebe73f9b17f0082b6bf5a374070101 | |
parent | c5ce174647fecc4344e8ceab67108dfc64e9bea4 (diff) |
Fix ownerin and reviewerin searches
Update the ownerin and reviewerin searches to use AccountGroup.UUID as
required by commit e662fb3d4d7d0ad05791b8d2143ac5ce58117335.
Bug: Issue 1171
Change-Id: I0a1b44f522946b219413612d0050f55d4ed46bcf
3 files changed, 16 insertions, 16 deletions
diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ChangeQueryBuilder.java b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ChangeQueryBuilder.java index cbb15f7c2d..64a5d0798c 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ChangeQueryBuilder.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ChangeQueryBuilder.java @@ -397,7 +397,7 @@ public class ChangeQueryBuilder extends QueryBuilder<ChangeData> { if (g == null) { throw error("Group " + group + " not found"); } - return new OwnerinPredicate(args.dbProvider, args.userFactory, g.getId()); + return new OwnerinPredicate(args.dbProvider, args.userFactory, g.getGroupUUID()); } @Operator @@ -425,7 +425,7 @@ public class ChangeQueryBuilder extends QueryBuilder<ChangeData> { if (g == null) { throw error("Group " + group + " not found"); } - return new ReviewerinPredicate(args.dbProvider, args.userFactory, g.getId()); + return new ReviewerinPredicate(args.dbProvider, args.userFactory, g.getGroupUUID()); } @Operator diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/OwnerinPredicate.java b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/OwnerinPredicate.java index 4f6fe5a508..92890b7082 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/OwnerinPredicate.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/OwnerinPredicate.java @@ -25,18 +25,18 @@ import com.google.inject.Provider; class OwnerinPredicate extends OperatorPredicate<ChangeData> { private final Provider<ReviewDb> dbProvider; private final IdentifiedUser.GenericFactory userFactory; - private final AccountGroup.Id id; + private final AccountGroup.UUID uuid; OwnerinPredicate(Provider<ReviewDb> dbProvider, - IdentifiedUser.GenericFactory userFactory, AccountGroup.Id id) { - super(ChangeQueryBuilder.FIELD_OWNERIN, id.toString()); + IdentifiedUser.GenericFactory userFactory, AccountGroup.UUID uuid) { + super(ChangeQueryBuilder.FIELD_OWNERIN, uuid.toString()); this.dbProvider = dbProvider; this.userFactory = userFactory; - this.id = id; + this.uuid = uuid; } - AccountGroup.Id getAccountGroupId() { - return id; + AccountGroup.UUID getAccountGroupUUID() { + return uuid; } @Override @@ -47,7 +47,7 @@ class OwnerinPredicate extends OperatorPredicate<ChangeData> { } final IdentifiedUser owner = userFactory.create(dbProvider, change.getOwner()); - return owner.getEffectiveGroups().contains(id); + return owner.getEffectiveGroups().contains(uuid); } @Override diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ReviewerinPredicate.java b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ReviewerinPredicate.java index 1784d9a34a..ea4d7b6c4d 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ReviewerinPredicate.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ReviewerinPredicate.java @@ -25,18 +25,18 @@ import com.google.inject.Provider; class ReviewerinPredicate extends OperatorPredicate<ChangeData> { private final Provider<ReviewDb> dbProvider; private final IdentifiedUser.GenericFactory userFactory; - private final AccountGroup.Id id; + private final AccountGroup.UUID uuid; ReviewerinPredicate(Provider<ReviewDb> dbProvider, - IdentifiedUser.GenericFactory userFactory, AccountGroup.Id id) { - super(ChangeQueryBuilder.FIELD_REVIEWERIN, id.toString()); + IdentifiedUser.GenericFactory userFactory, AccountGroup.UUID uuid) { + super(ChangeQueryBuilder.FIELD_REVIEWERIN, uuid.toString()); this.dbProvider = dbProvider; this.userFactory = userFactory; - this.id = id; + this.uuid = uuid; } - AccountGroup.Id getAccountGroupId() { - return id; + AccountGroup.UUID getAccountGroupUUID() { + return uuid; } @Override @@ -44,7 +44,7 @@ class ReviewerinPredicate extends OperatorPredicate<ChangeData> { for (PatchSetApproval p : object.approvals(dbProvider)) { final IdentifiedUser reviewer = userFactory.create(dbProvider, p.getAccountId()); - if (reviewer.getEffectiveGroups().contains(id)) { + if (reviewer.getEffectiveGroups().contains(uuid)) { return true; } } |