summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEdwin Kempin <edwin.kempin@sap.com>2012-02-08 22:55:43 -0800
committergerrit code review <noreply-gerritcodereview@google.com>2012-02-08 22:55:44 -0800
commite5bc5d41e57de0d333fff46d1f7d5af347332cc2 (patch)
treedc38005077ec14aee3504e364ed6bba0b9d1d693
parentee6516f946a8e19ae2766e06f8ff8b58322b93bb (diff)
parent2330cf8ccd2491b8b6a09c653fac69b853c6c38b (diff)
Merge "Fix ownerin and reviewerin searches" into stable
-rw-r--r--gerrit-server/src/main/java/com/google/gerrit/server/query/change/ChangeQueryBuilder.java4
-rw-r--r--gerrit-server/src/main/java/com/google/gerrit/server/query/change/OwnerinPredicate.java14
-rw-r--r--gerrit-server/src/main/java/com/google/gerrit/server/query/change/ReviewerinPredicate.java14
3 files changed, 16 insertions, 16 deletions
diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ChangeQueryBuilder.java b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ChangeQueryBuilder.java
index cbb15f7c2d..64a5d0798c 100644
--- a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ChangeQueryBuilder.java
+++ b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ChangeQueryBuilder.java
@@ -397,7 +397,7 @@ public class ChangeQueryBuilder extends QueryBuilder<ChangeData> {
if (g == null) {
throw error("Group " + group + " not found");
}
- return new OwnerinPredicate(args.dbProvider, args.userFactory, g.getId());
+ return new OwnerinPredicate(args.dbProvider, args.userFactory, g.getGroupUUID());
}
@Operator
@@ -425,7 +425,7 @@ public class ChangeQueryBuilder extends QueryBuilder<ChangeData> {
if (g == null) {
throw error("Group " + group + " not found");
}
- return new ReviewerinPredicate(args.dbProvider, args.userFactory, g.getId());
+ return new ReviewerinPredicate(args.dbProvider, args.userFactory, g.getGroupUUID());
}
@Operator
diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/OwnerinPredicate.java b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/OwnerinPredicate.java
index 4f6fe5a508..92890b7082 100644
--- a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/OwnerinPredicate.java
+++ b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/OwnerinPredicate.java
@@ -25,18 +25,18 @@ import com.google.inject.Provider;
class OwnerinPredicate extends OperatorPredicate<ChangeData> {
private final Provider<ReviewDb> dbProvider;
private final IdentifiedUser.GenericFactory userFactory;
- private final AccountGroup.Id id;
+ private final AccountGroup.UUID uuid;
OwnerinPredicate(Provider<ReviewDb> dbProvider,
- IdentifiedUser.GenericFactory userFactory, AccountGroup.Id id) {
- super(ChangeQueryBuilder.FIELD_OWNERIN, id.toString());
+ IdentifiedUser.GenericFactory userFactory, AccountGroup.UUID uuid) {
+ super(ChangeQueryBuilder.FIELD_OWNERIN, uuid.toString());
this.dbProvider = dbProvider;
this.userFactory = userFactory;
- this.id = id;
+ this.uuid = uuid;
}
- AccountGroup.Id getAccountGroupId() {
- return id;
+ AccountGroup.UUID getAccountGroupUUID() {
+ return uuid;
}
@Override
@@ -47,7 +47,7 @@ class OwnerinPredicate extends OperatorPredicate<ChangeData> {
}
final IdentifiedUser owner = userFactory.create(dbProvider,
change.getOwner());
- return owner.getEffectiveGroups().contains(id);
+ return owner.getEffectiveGroups().contains(uuid);
}
@Override
diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ReviewerinPredicate.java b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ReviewerinPredicate.java
index 1784d9a34a..ea4d7b6c4d 100644
--- a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ReviewerinPredicate.java
+++ b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ReviewerinPredicate.java
@@ -25,18 +25,18 @@ import com.google.inject.Provider;
class ReviewerinPredicate extends OperatorPredicate<ChangeData> {
private final Provider<ReviewDb> dbProvider;
private final IdentifiedUser.GenericFactory userFactory;
- private final AccountGroup.Id id;
+ private final AccountGroup.UUID uuid;
ReviewerinPredicate(Provider<ReviewDb> dbProvider,
- IdentifiedUser.GenericFactory userFactory, AccountGroup.Id id) {
- super(ChangeQueryBuilder.FIELD_REVIEWERIN, id.toString());
+ IdentifiedUser.GenericFactory userFactory, AccountGroup.UUID uuid) {
+ super(ChangeQueryBuilder.FIELD_REVIEWERIN, uuid.toString());
this.dbProvider = dbProvider;
this.userFactory = userFactory;
- this.id = id;
+ this.uuid = uuid;
}
- AccountGroup.Id getAccountGroupId() {
- return id;
+ AccountGroup.UUID getAccountGroupUUID() {
+ return uuid;
}
@Override
@@ -44,7 +44,7 @@ class ReviewerinPredicate extends OperatorPredicate<ChangeData> {
for (PatchSetApproval p : object.approvals(dbProvider)) {
final IdentifiedUser reviewer = userFactory.create(dbProvider,
p.getAccountId());
- if (reviewer.getEffectiveGroups().contains(id)) {
+ if (reviewer.getEffectiveGroups().contains(uuid)) {
return true;
}
}