Call inserter.flush() when creating code review notes

Failing to do this can cause the notes blobs to not get written to
storage, particularly with JGit's DfsInserter.

Change-Id: I28168374ddf9f89f5107a91bfba44f345ef395cf

1 files changed, 2 insertions, 0 deletions

diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/CreateCodeReviewNotes.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/CreateCodeReviewNotes.java
index b067a4915d..9a0fe17e0c 100644
--- a/gerrit-server/src/main/java/com/google/gerrit/server/git/CreateCodeReviewNotes.java
+++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/CreateCodeReviewNotes.java
@@ -117,6 +117,7 @@ public class CreateCodeReviewNotes {
       NotesBranchUtil notesBranchUtil = notesBranchUtilFactory.create(db);
       notesBranchUtil.commitAllNotes(notes, REFS_NOTES_REVIEW, author,
           message.toString());
+      inserter.flush();
     } catch (IOException e) {
       throw new CodeReviewNoteCreationException(e);
     } catch (ConcurrentRefUpdateException e) {
@@ -151,6 +152,7 @@ public class CreateCodeReviewNotes {
       NotesBranchUtil notesBranchUtil = notesBranchUtilFactory.create(db);
       notesBranchUtil.commitAllNotes(notes, REFS_NOTES_REVIEW, author,
           commitMessage);
+      inserter.flush();
     } catch (ConcurrentRefUpdateException e) {
       throw new CodeReviewNoteCreationException(e);
     } finally {