summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorShawn Pearce <sop@google.com>2013-05-06 09:35:40 -0700
committerShawn Pearce <sop@google.com>2013-05-06 09:35:40 -0700
commit17ad1de4342229d94ef34a53f5306013bcf4b193 (patch)
treeed2a657d17b58a594496f51e1ea60df87a37f5af
parentf41e408c30cd0d364cbf6613b90d94028f877fcb (diff)
Log when notify = null during /review
The notify field should be omitted from JSON or set to one of the supported constants. Log a warning whenever the value is null. This message may help to identify a potential problem in the Gson library when parsing input for /review. Change-Id: I3678c596e9c4884dadf60781fff5352ce8690726
-rw-r--r--gerrit-server/src/main/java/com/google/gerrit/server/change/PostReview.java1
1 files changed, 1 insertions, 0 deletions
diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/change/PostReview.java b/gerrit-server/src/main/java/com/google/gerrit/server/change/PostReview.java
index 044e266e23..9c14bcbbae 100644
--- a/gerrit-server/src/main/java/com/google/gerrit/server/change/PostReview.java
+++ b/gerrit-server/src/main/java/com/google/gerrit/server/change/PostReview.java
@@ -132,6 +132,7 @@ public class PostReview implements RestModifyView<RevisionResource, Input> {
checkComments(input.comments);
}
if (input.notify == null) {
+ log.warn("notify = null; assuming notify = NONE");
input.notify = NotifyHandling.NONE;
}