summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorShawn Pearce <sop@google.com>2013-05-06 14:09:29 +0000
committerGerrit Code Review <noreply-gerritcodereview@google.com>2013-05-06 14:09:29 +0000
commit648300d8a493c1a6ba2a69eed54a70e92e363385 (patch)
treefdbd36bdaf5a5111bf9ec70a5d327b4fd3263a0d
parentcb0a36e6d3aa630913e2d63bf1a2e751c7219831 (diff)
parent45f1486f36831ed33700459b0493af33150f57cf (diff)
Merge "Re-add comment why connection pooling is turned off for MySQL" into stable-2.6
-rw-r--r--gerrit-server/src/main/java/com/google/gerrit/server/schema/MySql.java4
1 files changed, 4 insertions, 0 deletions
diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/schema/MySql.java b/gerrit-server/src/main/java/com/google/gerrit/server/schema/MySql.java
index 8c46732ef8..308cec8ec6 100644
--- a/gerrit-server/src/main/java/com/google/gerrit/server/schema/MySql.java
+++ b/gerrit-server/src/main/java/com/google/gerrit/server/schema/MySql.java
@@ -47,6 +47,10 @@ class MySql extends BaseDataSourceType {
@Override
public boolean usePool() {
+ // MySQL has given us trouble with the connection pool,
+ // sometimes the backend disconnects and the pool winds
+ // up with a stale connection. Fortunately opening up
+ // a new MySQL connection is usually very fast.
return false;
}
} \ No newline at end of file