Trim username in authentication request.

Remove leading and trailing whitespace in username when creating a request
to avoid incorrect login. Valid username and extra whitespace with valid
password causes creation of new Gerrit user that logs in. This is unwanted
behavior and because whitespace is invalid character to use in username it
can be safely removed.

Task-number: QTQAINFRA-456
Change-Id: I0315285a2cc5b349515ba57c0d96167044238996
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>
Reviewed-by: Ismo Haataja <ismo.haataja@digia.com>

1 files changed, 2 insertions, 2 deletions

diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/account/AuthRequest.java b/gerrit-server/src/main/java/com/google/gerrit/server/account/AuthRequest.java
index 35ab3af72f..be4fe40795 100644
--- a/gerrit-server/src/main/java/com/google/gerrit/server/account/AuthRequest.java
+++ b/gerrit-server/src/main/java/com/google/gerrit/server/account/AuthRequest.java
@@ -32,9 +32,9 @@ public class AuthRequest {
   /** Create a request for a local username, such as from LDAP. */
   public static AuthRequest forUser(final String username) {
     final AccountExternalId.Key i =
-        new AccountExternalId.Key(SCHEME_GERRIT, username);
+        new AccountExternalId.Key(SCHEME_GERRIT, username.trim());
     final AuthRequest r = new AuthRequest(i.get());
-    r.setUserName(username);
+    r.setUserName(username.trim());
     return r;
   }