diff options
| author | David Pursehouse <david.pursehouse@sonymobile.com> | 2014-04-15 18:56:54 +0900 |
|---|---|---|
| committer | David Pursehouse <david.pursehouse@sonymobile.com> | 2014-04-15 18:56:54 +0900 |
| commit | 6534b9eb477b35a8d2799a12e7e0c80e0c918f16 (patch) | |
| tree | 0907f2dc5bade04a5e5090d4430fcb3f3b3ef399 | |
| parent | 62096c7b030ed24f1561ef8163e28216cda764f9 (diff) | |
Don't show the submit button for draft patch sets
Currently the button is enabled for all open changes, but if
the patch set is a draft, pressing it results in an error.
Change-Id: I382fc9330b73d357c00ba0209f18d2c1584e9256
| -rw-r--r-- | gerrit-server/src/main/java/com/google/gerrit/server/change/Submit.java | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/change/Submit.java b/gerrit-server/src/main/java/com/google/gerrit/server/change/Submit.java index 33890317ad..cb411250d3 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/change/Submit.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/change/Submit.java @@ -150,7 +150,8 @@ public class Submit implements RestModifyView<RevisionResource, Input>, .setTitle(String.format( "Submit revision %d", resource.getPatchSet().getPatchSetId())) - .setVisible(resource.getChange().getStatus().isOpen() + .setVisible(!resource.getPatchSet().isDraft() + && resource.getChange().getStatus().isOpen() && resource.getPatchSet().getId().equals(current) && resource.getControl().canSubmit()); } |