Fix: wrongly throw 'commit already exists' exception

The reason is the ReplaceRequest.validate() should compare
to 'newCommit' of ReplaceRequest instance, else when
ReceiveCommits.autoCloseChanges() working on the second one
of a series of commits, the 'commit already exists(in the project)'
will be thrown wrongly.

Fixed.

Bug: issue 2607
Change-Id: Ib4db351d39f85d57ccf532da4d6422bdcbb88105

1 files changed, 1 insertions, 1 deletions

diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java
index 94d209b8e3..475e24a318 100644
--- a/gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java
+++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java
@@ -1714,7 +1714,7 @@ public class ReceiveCommits {
 
       for (final Ref r : rp.getRepository().getRefDatabase()
           .getRefs("refs/changes").values()) {
-        if (r.getObjectId().equals(inputCommand.getNewId())) {
+        if (r.getObjectId().equals(newCommit)) {
           reject(inputCommand, "commit already exists (in the project)");
           return false;
         }