diff options
author | David Pursehouse <david.pursehouse@sonymobile.com> | 2014-04-25 14:19:44 +0900 |
---|---|---|
committer | David Pursehouse <david.pursehouse@sonymobile.com> | 2014-04-25 14:19:44 +0900 |
commit | 91ccab5187dc48adf36179d64b7458e7d34b8242 (patch) | |
tree | bd793cf3e01676c33d2ea0fbc1f9fc2eb11127b5 | |
parent | 0503d412f4504e82e76459a354ffd7b4c8199e53 (diff) |
Use Provider for IdentifiedUser in CreateBranch constructor
This is the same fix that was already done for DeleteBranch's
constructor in If7fd7f4c38bcbc685d4f9451479da7a9ed432564.
Change-Id: Ied38df303eaf4ea1893527e947633445974e9d19
-rw-r--r-- | gerrit-server/src/main/java/com/google/gerrit/server/project/CreateBranch.java | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/project/CreateBranch.java b/gerrit-server/src/main/java/com/google/gerrit/server/project/CreateBranch.java index f854b58dc2..a53f617bc4 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/project/CreateBranch.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/project/CreateBranch.java @@ -32,6 +32,7 @@ import com.google.gerrit.server.project.CreateBranch.Input; import com.google.gerrit.server.project.ListBranches.BranchInfo; import com.google.gerrit.server.util.MagicBranch; import com.google.inject.Inject; +import com.google.inject.Provider; import com.google.inject.assistedinject.Assisted; import org.eclipse.jgit.errors.IncorrectObjectTypeException; @@ -64,14 +65,15 @@ public class CreateBranch implements RestModifyView<ProjectResource, Input> { CreateBranch create(String ref); } - private final IdentifiedUser identifiedUser; + private final Provider<IdentifiedUser> identifiedUser; private final GitRepositoryManager repoManager; private final GitReferenceUpdated referenceUpdated; private final ChangeHooks hooks; private String ref; @Inject - CreateBranch(IdentifiedUser identifiedUser, GitRepositoryManager repoManager, + CreateBranch(Provider<IdentifiedUser> identifiedUser, + GitRepositoryManager repoManager, GitReferenceUpdated referenceUpdated, ChangeHooks hooks, @Assisted String ref) { this.identifiedUser = identifiedUser; @@ -135,7 +137,7 @@ public class CreateBranch implements RestModifyView<ProjectResource, Input> { final RefUpdate u = repo.updateRef(ref); u.setExpectedOldObjectId(ObjectId.zeroId()); u.setNewObjectId(object.copy()); - u.setRefLogIdent(identifiedUser.newRefLogIdent()); + u.setRefLogIdent(identifiedUser.get().newRefLogIdent()); u.setRefLogMessage("created via REST from " + input.revision, false); final RefUpdate.Result result = u.update(rw); switch (result) { @@ -143,7 +145,7 @@ public class CreateBranch implements RestModifyView<ProjectResource, Input> { case NEW: case NO_CHANGE: referenceUpdated.fire(name.getParentKey(), u); - hooks.doRefUpdatedHook(name, u, identifiedUser.getAccount()); + hooks.doRefUpdatedHook(name, u, identifiedUser.get().getAccount()); break; case LOCK_FAILURE: if (repo.getRef(ref) != null) { |