Do not refresh group list if filter did not change

Every time key up event is raised in the group list filter box, the
group list was getting refreshed even if the filter did not change
(e.g. moving the cursor was refreshing the list).

Only call the refresh if the filter is changed or enter is pressed.

Change-Id: I64d24eeae08f35723b401fffd9a3e8ed84c8d00c

1 files changed, 7 insertions, 3 deletions

diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/GroupListScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/GroupListScreen.java
index bed6b4a2d0..cf9fb041f7 100644
--- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/GroupListScreen.java
+++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/GroupListScreen.java
@@ -34,7 +34,7 @@ import com.google.gwtexpui.globalkey.client.NpTextBox;
 public class GroupListScreen extends AccountScreen implements FilteredUserInterface {
   private GroupTable groups;
   private NpTextBox filterTxt;
-  private String subname;
+  private String subname = "";
 
   public GroupListScreen() {
   }
@@ -104,8 +104,12 @@ public class GroupListScreen extends AccountScreen implements FilteredUserInterf
     filterTxt.addKeyUpHandler(new KeyUpHandler() {
       @Override
       public void onKeyUp(KeyUpEvent event) {
-        subname = filterTxt.getValue();
-        refresh(event.getNativeEvent().getKeyCode() == KeyCodes.KEY_ENTER);
+        boolean enterPressed =
+            event.getNativeEvent().getKeyCode() == KeyCodes.KEY_ENTER;
+        if (enterPressed || !filterTxt.getValue().equals(subname)) {
+          subname = filterTxt.getValue();
+          refresh(enterPressed);
+        }
       }
     });
     hp.add(filterTxt);