summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHugo Arès <hugo.ares@ericsson.com>2014-04-07 09:15:02 -0400
committerDavid Pursehouse <david.pursehouse@sonymobile.com>2014-04-08 13:18:52 +0900
commitf79fd10f3bba60423e545139addbc79c101bc3bd (patch)
tree936f28438f16094b255f494d2cf56fbfe559410e
parent72bced0061a2fb2012d693d44a87a210fd68acc2 (diff)
Do not refresh project list if filter did not change
Every time key up event is raised in the project list filter text box, the project list was getting refreshed even if the filter did not change (e.g. moving the cursor was refreshing the list). Only call the refresh if the filter changed or if enter key is pressed. Change-Id: I2e608d89e16dbef0cfe1e503ac2feb4639c27f5d
-rw-r--r--gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectListScreen.java10
1 files changed, 7 insertions, 3 deletions
diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectListScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectListScreen.java
index 331afee920..2a8c497e84 100644
--- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectListScreen.java
+++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectListScreen.java
@@ -43,7 +43,7 @@ import com.google.gwtexpui.globalkey.client.NpTextBox;
public class ProjectListScreen extends Screen implements FilteredUserInterface {
private ProjectsTable projects;
private NpTextBox filterTxt;
- private String subname;
+ private String subname = "";
public ProjectListScreen() {
}
@@ -158,8 +158,12 @@ public class ProjectListScreen extends Screen implements FilteredUserInterface {
filterTxt.addKeyUpHandler(new KeyUpHandler() {
@Override
public void onKeyUp(KeyUpEvent event) {
- subname = filterTxt.getValue();
- refresh(event.getNativeEvent().getKeyCode() == KeyCodes.KEY_ENTER);
+ boolean enterPressed =
+ event.getNativeEvent().getKeyCode() == KeyCodes.KEY_ENTER;
+ if (enterPressed || !filterTxt.getValue().equals(subname)) {
+ subname = filterTxt.getValue();
+ refresh(enterPressed);
+ }
}
});
hp.add(filterTxt);