summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid Ostrovsky <david@ostrovsky.org>2020-07-06 19:55:01 +0200
committerDavid Ostrovsky <david@ostrovsky.org>2020-07-06 20:39:08 +0200
commitb415569a191331972c5244761908432f1736114a (patch)
tree05bb5564a7d48b05b68e336bcd2a4bd3cea045e2
parent6730fb7283ead75ccfe45778fc53d4923b981af9 (diff)
Switch off error prone ExpectedExceptionChecker bug pattern
In I4a774846ad the code was migrated to using assertThrows instead of ExpectedException. However this change was included only starting from stable-3.1 branch. Yet we would like to upgrade Bazel version to earliest supported version which is stable-3.0 branch. Given that Error Prone version had a major upgrade the existing ExpectedExceptionChecker check is correctly flagging the usage of ExpectedException and failing the build. To rectify, switch off the check for now, but omit it during the merge of the change to stable-3.1 branch and mention it in the commit message. Change-Id: I37d0a6752867936aa8a29d16a41b2ce46bdb162e
-rw-r--r--tools/BUILD2
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/BUILD b/tools/BUILD
index fb3ed434c6..9ccc0651f4 100644
--- a/tools/BUILD
+++ b/tools/BUILD
@@ -39,7 +39,7 @@ java_package_configuration(
"-Xep:ElementsCountedInLoop:WARN",
"-Xep:EqualsHashCode:WARN",
"-Xep:EqualsIncompatibleType:WARN",
- "-Xep:ExpectedExceptionChecker:ERROR",
+ "-Xep:ExpectedExceptionChecker:OFF",
"-Xep:Finally:WARN",
"-Xep:FloatingPointLiteralPrecision:WARN",
"-Xep:FragmentInjection:WARN",