diff options
author | Thomas Draebing <thomas.draebing@sap.com> | 2020-02-03 15:32:38 +0100 |
---|---|---|
committer | Thomas Dräbing <thomas.draebing@sap.com> | 2020-02-03 14:43:34 +0000 |
commit | 5a89a5594069442994dee59b021a37b525c5521b (patch) | |
tree | d8fe1991945b1b12e77f963981c78349a9345bf8 | |
parent | c9c27621607853b1f781b3a5a3a5d8e23e5282f5 (diff) |
Remove MessageOfTheDay extension
The message of the day functionality was heavily depended on
components of Gerrit core. In Gerrit-3.0 only the extension point was
left of this feature, but it wasn't used anywhere to actually display
the messages registered with it. While this feature was reenabled for
the PolyGerrit-UI in Gerrit 2.16, for compatibility reasons, it still
depended on the components in Gerrit core. It is planned to move this
functionality completely to the plugin. Since it was not usable with
the new UI for a long while, the functionality will be removed
completely until then.
Change-Id: If653e7042db981e55d08fa29e14dd9201fb22627
-rw-r--r-- | java/com/google/gerrit/extensions/systemstatus/MessageOfTheDay.java | 63 | ||||
-rw-r--r-- | java/com/google/gerrit/server/config/GerritGlobalModule.java | 2 |
2 files changed, 0 insertions, 65 deletions
diff --git a/java/com/google/gerrit/extensions/systemstatus/MessageOfTheDay.java b/java/com/google/gerrit/extensions/systemstatus/MessageOfTheDay.java deleted file mode 100644 index 180a0e6635..0000000000 --- a/java/com/google/gerrit/extensions/systemstatus/MessageOfTheDay.java +++ /dev/null @@ -1,63 +0,0 @@ -// Copyright (C) 2014 The Android Open Source Project -// -// Licensed under the Apache License, Version 2.0 (the "License"); -// you may not use this file except in compliance with the License. -// You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. - -package com.google.gerrit.extensions.systemstatus; - -import com.google.gerrit.extensions.annotations.ExtensionPoint; -import java.util.Calendar; -import java.util.Date; -import java.util.TimeZone; - -/** - * Supplies a message of the day when the page is first loaded. - * - * <pre> - * DynamicSet.bind(binder(), MessageOfTheDay.class).to(MyMessage.class); - * </pre> - */ -@ExtensionPoint -public abstract class MessageOfTheDay { - /** - * Retrieve the message of the day as an HTML fragment. - * - * @return message as an HTML fragment; null if no message is available. - */ - public abstract String getHtmlMessage(); - - /** - * Unique identifier for this message. - * - * <p>Messages with the same identifier will be hidden from the user until redisplay has occurred. - * - * @return unique message identifier. This identifier should be unique within the server. - */ - public abstract String getMessageId(); - - /** - * When should the message be displayed? - * - * <p>Default implementation returns {@code tomorrow at 00:00:00 GMT}. - * - * @return a future date after which the message should be redisplayed. - */ - public Date getRedisplay() { - Calendar cal = Calendar.getInstance(TimeZone.getTimeZone("GMT")); - cal.set(Calendar.HOUR_OF_DAY, 0); - cal.set(Calendar.MINUTE, 0); - cal.set(Calendar.SECOND, 0); - cal.set(Calendar.MILLISECOND, 0); - cal.add(Calendar.DAY_OF_MONTH, 1); - return cal.getTime(); - } -} diff --git a/java/com/google/gerrit/server/config/GerritGlobalModule.java b/java/com/google/gerrit/server/config/GerritGlobalModule.java index 59a55ab2e7..a5f25f99d3 100644 --- a/java/com/google/gerrit/server/config/GerritGlobalModule.java +++ b/java/com/google/gerrit/server/config/GerritGlobalModule.java @@ -61,7 +61,6 @@ import com.google.gerrit.extensions.events.WorkInProgressStateChangedListener; import com.google.gerrit.extensions.registration.DynamicItem; import com.google.gerrit.extensions.registration.DynamicMap; import com.google.gerrit.extensions.registration.DynamicSet; -import com.google.gerrit.extensions.systemstatus.MessageOfTheDay; import com.google.gerrit.extensions.webui.BranchWebLink; import com.google.gerrit.extensions.webui.DiffWebLink; import com.google.gerrit.extensions.webui.FileHistoryWebLink; @@ -352,7 +351,6 @@ public class GerritGlobalModule extends FactoryModule { DynamicItem.itemOf(binder(), AvatarProvider.class); DynamicSet.setOf(binder(), LifecycleListener.class); DynamicSet.setOf(binder(), TopMenu.class); - DynamicSet.setOf(binder(), MessageOfTheDay.class); DynamicMap.mapOf(binder(), DownloadScheme.class); DynamicMap.mapOf(binder(), DownloadCommand.class); DynamicMap.mapOf(binder(), CloneCommand.class); |