diff options
| author | Przemyslaw Waliszewski <pwaliszewski@gmail.com> | 2021-03-18 19:07:45 +0100 |
|---|---|---|
| committer | Luca Milanesio <luca.milanesio@gmail.com> | 2021-03-24 14:32:42 +0000 |
| commit | 5c0e72a43827597151544f4abfa1dc0dfa039b6e (patch) | |
| tree | 5bdd2c2d09cf2eca6280e49d4f1572afb8e7d31a | |
| parent | f1c7bb4aa9b8feaeaa585292b8b9c1925ada2692 (diff) | |
Fix empty TopMenu drop down list
Before this change, external plugin can add new Menu List without proper
menu link. Empty menu list generates "TypeError: this.$.cursor.target is
undefined" onClick.
Issue appears on any plugin extending TopMenu with url containing
${projectName} or with empty MenuItem list.
Bug: Issue 14257
Change-Id: I5d09a4f0bbd24fcff1dec0b65d9366bdb05249f3
| -rw-r--r-- | polygerrit-ui/app/elements/core/gr-main-header/gr-main-header.js | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/polygerrit-ui/app/elements/core/gr-main-header/gr-main-header.js b/polygerrit-ui/app/elements/core/gr-main-header/gr-main-header.js index 773ad68dc6..ab9b70e096 100644 --- a/polygerrit-ui/app/elements/core/gr-main-header/gr-main-header.js +++ b/polygerrit-ui/app/elements/core/gr-main-header/gr-main-header.js @@ -224,7 +224,7 @@ }); if (m.name in topMenuLinks) { items.forEach(link => { topMenuLinks[m.name].push(link); }); - } else { + } else if (items.length > 0) { links.push({ title: m.name, links: topMenuLinks[m.name] = items, |