summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFrederik Gladhorn <frederik.gladhorn@qt.io>2019-07-12 14:23:35 +0200
committerAlexandru Croitor <alexandru.croitor@qt.io>2020-09-22 11:32:20 +0000
commit02d6f44e6b060f59f49fd7f452bcb533cf8ddff3 (patch)
tree8a5db54826da8c9f2c921558f2a29b36d21382a6
parent3b6380cfaede69fa43ad0a8662ef5ebc127e327f (diff)
Fix state handling: integrating, staged and deferred must be closed
This is currently how we prevent making changes to them. Change-Id: I7ea146b66eb9f10a2936be89ffa943b71f1ef6c5 (cherry picked from commit b1a8d24cbf39ca79bc0899fee8fa3f714e99debd) Reviewed-by: Jukka Jokiniva <jukka.jokiniva@qt.io>
-rw-r--r--java/com/google/gerrit/entities/Change.java12
1 files changed, 11 insertions, 1 deletions
diff --git a/java/com/google/gerrit/entities/Change.java b/java/com/google/gerrit/entities/Change.java
index 954c9ff5ac..00bfd911e0 100644
--- a/java/com/google/gerrit/entities/Change.java
+++ b/java/com/google/gerrit/entities/Change.java
@@ -710,8 +710,18 @@ public final class Change {
return getStatus().equals(Status.ABANDONED);
}
+ public boolean isIntegrating() {
+ return getStatus().equals(Status.INTEGRATING);
+ }
+ public boolean isStaged() {
+ return getStatus().equals(Status.STAGED);
+ }
+ public boolean isDeferred() {
+ return getStatus().equals(Status.DEFERRED);
+ }
+
public boolean isClosed() {
- return isAbandoned() || isMerged();
+ return isAbandoned() || isMerged() || isStaged() || isIntegrating() || isDeferred();
}
public String getTopic() {