summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDhruv Srivastava <dhruvsri@google.com>2020-10-27 17:41:56 +0100
committerLuca Milanesio <luca.milanesio@gmail.com>2020-11-10 16:15:31 +0000
commit1a54019bb30ec52ddff9ea13cb71c6b4302d6a17 (patch)
treed3bc0e624b9d151a5e434704fa6d87cd4b641c29
parent829f5b37c1842e983d0606308532ebe36f983479 (diff)
Do not convert PatchSetNum type to string
-rw-r--r--polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.ts8
1 files changed, 4 insertions, 4 deletions
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.ts b/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.ts
index 90a9301372..ff34c96d1a 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.ts
+++ b/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.ts
@@ -938,18 +938,18 @@ export class GrDiffView extends KeyboardShortcutMixin(
for (const commitSha in this._change.revisions) {
if (!hasOwnProperty(this._change.revisions, commitSha)) continue;
const revision = this._change.revisions[commitSha];
- const patchNum = revision._number.toString();
- if (patchNum === this._patchRange.patchNum) {
+ const patchNum = revision._number;
+ if (patchNumEquals(patchNum, this._patchRange.patchNum)) {
commit = commitSha as CommitId;
const commitObj = revision.commit;
const parents = commitObj?.parents || [];
if (
- this._patchRange.basePatchNum === ParentPatchSetNum &&
+ patchNumEquals(this._patchRange.basePatchNum, ParentPatchSetNum) &&
parents.length
) {
baseCommit = parents[parents.length - 1].commit;
}
- } else if (patchNum === this._patchRange.basePatchNum) {
+ } else if (patchNumEquals(patchNum, this._patchRange.basePatchNum)) {
baseCommit = commitSha as CommitId;
}
}