summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEdwin Kempin <ekempin@google.com>2022-01-12 13:32:53 +0100
committerEdwin Kempin <ekempin@google.com>2022-02-11 07:55:14 +0000
commitcc38ab362a5b0a7828c4ba032f6f7216d880d8c9 (patch)
treeb2745739a67e3871f89d551cd402e709fb0b5759
parent7530360d9b8fa19d4e8bf239cbd2c2793cc3b5de (diff)
Test that endless loop on Prolog type error is fixed
The new test reproduced the endless loop that was fixed by change Ie922c8db1. Without the fix the change creation via push fails with an internal error due to the stack overflow. Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: I4112cfc455940d0f1a019f825b0dd85e8c6a221f Release-Notes: skip
-rw-r--r--javatests/com/google/gerrit/acceptance/server/rules/RulesIT.java6
1 files changed, 6 insertions, 0 deletions
diff --git a/javatests/com/google/gerrit/acceptance/server/rules/RulesIT.java b/javatests/com/google/gerrit/acceptance/server/rules/RulesIT.java
index 0585f74b92..6cb13c5863 100644
--- a/javatests/com/google/gerrit/acceptance/server/rules/RulesIT.java
+++ b/javatests/com/google/gerrit/acceptance/server/rules/RulesIT.java
@@ -164,6 +164,12 @@ public class RulesIT extends AbstractDaemonTest {
assertThat(statusForRuleRenamedFile()).isEqualTo(SubmitRecord.Status.OK);
}
+ @Test
+ public void typeError() throws Exception {
+ modifySubmitRules("user(1000000)."); // the trailing '.' triggers a type error
+ assertThat(statusForRuleAddFile("foo")).isEqualTo(SubmitRecord.Status.RULE_ERROR);
+ }
+
private SubmitRecord.Status statusForRule() throws Exception {
String oldHead = projectOperations.project(project).getHead("master").name();
PushOneCommit.Result result =