diff options
author | Milutin Kristofic <milutin@google.com> | 2022-05-11 15:39:10 +0200 |
---|---|---|
committer | Paladox none <thomasmulhall410@yahoo.com> | 2022-05-12 11:42:48 +0000 |
commit | de4d7170f7bbc0e242d8a0ff68fe98cf611ceb79 (patch) | |
tree | 0d3b5e3ccbfb8206e9bb59b1c469991f8189066c | |
parent | 4b59f3c317fc3e2bc5997722057ef4a021137da2 (diff) |
Fix file-list is not reloaded when clicking on change number
When user change patch range from patchset 1 -> patchset 2. File list
correctly shows file change between 1-2. When user clicks on change
number, patchset range is reset to base vs patchset 2. However
file list is not reloaded to show changes base vs 2.
This is caused because patchNum is undefined, which is first check
in file-list reload function. It works ok on first render, because
patch gr-patch-range-select set latest to patchNum.
Google-Bug-Id: b/230097909
Release-Notes: skip
Change-Id: Icb96b5d7d861adfb4c8a4d0e4b1209b4975ada13
(cherry picked from commit 025bf8fa9cafba9ec6ae2540e84beafaf75f289d)
-rw-r--r-- | polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.ts | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.ts b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.ts index 86ace101c0..d3f29fce7b 100644 --- a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.ts +++ b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.ts @@ -1284,6 +1284,10 @@ export class GrChangeView extends base { if (value.basePatchNum === undefined) value.basePatchNum = ParentPatchSetNum; + if (value.patchNum === undefined) { + value.patchNum = computeLatestPatchNum(this._allPatchSets); + } + const patchChanged = this.hasPatchRangeChanged(value); let patchNumChanged = this.hasPatchNumChanged(value); |