summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThomas Draebing <thomas.draebing@sap.com>2023-02-02 08:35:21 +0100
committerThomas Draebing <thomas.draebing@sap.com>2023-02-02 08:35:21 +0100
commit19574f4d5a5f21b184a1249b037a264de123cc27 (patch)
treefcee5eccc7b2901c51aae8b50079f4a439e90384
parentcef04d2c42ebfc354cbb471953fdcddb7543c08e (diff)
Fix rendering String input values in plugin project options
Plugins can provide project specific configuration options and Gerrit will render the forms to configure those in the project's general page. The input fields for entering Strings/numbers (`<input>`) had a bug that caused the configured value not to be shown. While configuring those values still worked as expected, seeing no value displayed after reloading the page was confusing. Bug: Issue 16644 Release-Notes: skip Change-Id: I1cca8e88a2cf14a92bed4698dd7e6e7265af9af3
-rw-r--r--polygerrit-ui/app/elements/admin/gr-repo-plugin-config/gr-repo-plugin-config.ts1
1 files changed, 1 insertions, 0 deletions
diff --git a/polygerrit-ui/app/elements/admin/gr-repo-plugin-config/gr-repo-plugin-config.ts b/polygerrit-ui/app/elements/admin/gr-repo-plugin-config/gr-repo-plugin-config.ts
index 9b2bf687da..bab7b15974 100644
--- a/polygerrit-ui/app/elements/admin/gr-repo-plugin-config/gr-repo-plugin-config.ts
+++ b/polygerrit-ui/app/elements/admin/gr-repo-plugin-config/gr-repo-plugin-config.ts
@@ -183,6 +183,7 @@ export class GrRepoPluginConfig extends LitElement {
) {
return html`
<iron-input
+ .bindValue=${option.info.value ?? ''}
@input=${this._handleStringChange}
data-option-key="${option._key}"
>