diff options
| author | Paladox none <thomasmulhall410@yahoo.com> | 2023-03-15 21:09:15 +0000 |
|---|---|---|
| committer | Paladox none <thomasmulhall410@yahoo.com> | 2023-03-16 17:58:53 +0000 |
| commit | ef48dff89ccd08409c9efeeacb066e34c400adde (patch) | |
| tree | 75e8b567171c3ca48b924298b9840c1bbbd3334c | |
| parent | 11579cf61553e501f161467717dd3bdc1b48e08e (diff) | |
Fix "showchange" plugin event being triggered twice on patchset change
We fix this by only calling sendShowChangeEvent() within performPostLoadTasks().
We don't need to call it as well when executing reloadPatchNumDependentResources promise
as it'll already be triggered when performPostLoadTasks() is called.
Bug: Issue 16072
Release-Notes: Fix "showchange" plugin event being triggered twice on patchset change
Change-Id: Icb159eaa75db12bc2027b9aa2c675829b72d2c0c
(cherry picked from commit 3dae088e8a866a6b28140a36adcbdbc189e39333)
| -rw-r--r-- | polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.ts | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.ts b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.ts index b253c03607..abddb0ffb1 100644 --- a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.ts +++ b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.ts @@ -2214,9 +2214,7 @@ export class GrChangeView extends LitElement { // existing diff is not requested. See Issue 125270 for more details. this.fileList?.resetFileState(); this.fileList?.collapseAllDiffs(); - this.reloadPatchNumDependentResources(patchNumChanged).then(() => { - this.sendShowChangeEvent(); - }); + this.reloadPatchNumDependentResources(patchNumChanged); } // If there is no change in patchset or changeNum, such as when user goes |