summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid Ostrovsky <david@ostrovsky.org>2022-05-06 06:44:56 +0200
committerDavid Ostrovsky <david.ostrovsky@gmail.com>2023-05-11 09:16:01 +0000
commit65ce9e4c14607a76587feb5afd0dae55fdbd6bdb (patch)
tree38d27bb6d9f99ec64858f1a6afb110a1fa253130
parente922684617edb0e6c144dc436b0a517c99bf06e1 (diff)
Fix SameNameButDifferent bug pattern flagged by error prone
Details: https://errorprone.info/bugpattern/SameNameButDifferent Release-Notes: skip Forward-Compatible: checked Change-Id: I9c963c4f96ca59ea7fe8afd7a309f3841c50a0ae
-rw-r--r--java/com/google/gerrit/entities/SubmitRecord.java4
-rw-r--r--java/com/google/gerrit/extensions/common/SubmitRecordInfo.java2
2 files changed, 3 insertions, 3 deletions
diff --git a/java/com/google/gerrit/entities/SubmitRecord.java b/java/com/google/gerrit/entities/SubmitRecord.java
index 95ad9f8c15..4142b427e3 100644
--- a/java/com/google/gerrit/entities/SubmitRecord.java
+++ b/java/com/google/gerrit/entities/SubmitRecord.java
@@ -70,7 +70,7 @@ public class SubmitRecord {
// Name of the rule that created this submit record, formatted as '$pluginName~$ruleName'
public String ruleName;
- public Status status;
+ public SubmitRecord.Status status;
public List<Label> labels;
public List<LegacySubmitRequirement> requirements;
public String errorMessage;
@@ -113,7 +113,7 @@ public class SubmitRecord {
}
public String label;
- public Status status;
+ public Label.Status status;
public Account.Id appliedBy;
/**
diff --git a/java/com/google/gerrit/extensions/common/SubmitRecordInfo.java b/java/com/google/gerrit/extensions/common/SubmitRecordInfo.java
index 09c98410f7..e591963e0d 100644
--- a/java/com/google/gerrit/extensions/common/SubmitRecordInfo.java
+++ b/java/com/google/gerrit/extensions/common/SubmitRecordInfo.java
@@ -36,7 +36,7 @@ public class SubmitRecordInfo {
}
public String label;
- public Status status;
+ public Label.Status status;
public AccountInfo appliedBy;
}