summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDhruv Srivastava <dhruvsri@google.com>2023-04-06 13:57:15 +0200
committerPaladox none <thomasmulhall410@yahoo.com>2023-04-06 13:41:48 +0000
commit8f0bbde29c4bad00ace7c57ccd8394ac46768663 (patch)
tree8727565fdaf2c222a5bd52b047e698074300f3a6
parent448a84e8dd4e6caa9acbff4ca000aae5be4aee56 (diff)
Pass along params when navigating between routes
Opening legacy change route with view params(such as tabState) redirects to the main change route. Without passing the params along the view params are not reflected. Google-bug-id: b/277077243 Release-Notes: skip Change-Id: Ic2ad4cb837bcb303c4d56018e2ae64efd37bca5f (cherry picked from commit 71067549eca363a17f8affdef44a3b8b579c032f)
-rw-r--r--polygerrit-ui/app/elements/core/gr-router/gr-router.ts11
1 files changed, 9 insertions, 2 deletions
diff --git a/polygerrit-ui/app/elements/core/gr-router/gr-router.ts b/polygerrit-ui/app/elements/core/gr-router/gr-router.ts
index 1b377e8afa..902616eac0 100644
--- a/polygerrit-ui/app/elements/core/gr-router/gr-router.ts
+++ b/polygerrit-ui/app/elements/core/gr-router/gr-router.ts
@@ -1237,7 +1237,11 @@ export class GrRouter implements Finalizable, NavigationService {
}
handleChangeNumberLegacyRoute(ctx: PageContext) {
- this.redirect('/c/' + ctx.params[0]);
+ this.redirect(
+ '/c/' +
+ ctx.params[0] +
+ (ctx.querystring.length > 0 ? `?${ctx.querystring}` : '')
+ );
}
handleChangeRoute(ctx: PageContext) {
@@ -1396,7 +1400,10 @@ export class GrRouter implements Finalizable, NavigationService {
this.show404();
return;
}
- this.redirect(`/c/${project}/+/${changeNum}/${ctx.params[1]}`);
+ this.redirect(
+ `/c/${project}/+/${changeNum}/${ctx.params[1]}` +
+ (ctx.querystring.length > 0 ? `?${ctx.querystring}` : '')
+ );
});
}