summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKaushik Lingarkar <kaushik.lingarkar@linaro.org>2022-08-11 17:04:41 -0700
committerPaladox none <thomasmulhall410@yahoo.com>2023-04-06 19:07:46 +0000
commitbaef2e1833df05fb469a416b871375d2cc8fe541 (patch)
treeefd1f694d3d8baec965e2e57adf5c0c4818fee4d
parent02e31974e4a601ce2e0df9a3197a75a7ae3e7c0b (diff)
Limit index query results in Move Change REST API
Perform the index query to determine if a change already exists on the destination with a limit of 1 as it should be sufficient for change existence check. Release-Notes: skip Change-Id: I08c355f5e4edea0e81a721ef2a39ebad0ed3614d (cherry picked from commit ab7fe2fd44615a938e029f126bcdf4c2389824b5)
-rw-r--r--java/com/google/gerrit/server/restapi/change/Move.java3
1 files changed, 2 insertions, 1 deletions
diff --git a/java/com/google/gerrit/server/restapi/change/Move.java b/java/com/google/gerrit/server/restapi/change/Move.java
index 94f9b8d5c4..5e6f024899 100644
--- a/java/com/google/gerrit/server/restapi/change/Move.java
+++ b/java/com/google/gerrit/server/restapi/change/Move.java
@@ -216,7 +216,8 @@ public class Move implements RestModifyView<ChangeResource, MoveInput>, UiAction
}
Change.Key changeKey = change.getKey();
- if (!asChanges(queryProvider.get().byBranchKey(newDestKey, changeKey)).isEmpty()) {
+ if (!asChanges(queryProvider.get().setLimit(1).byBranchKey(newDestKey, changeKey))
+ .isEmpty()) {
throw new ResourceConflictException(
"Destination "
+ newDestKey.shortName()