summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJukka Jokiniva <jukka.jokiniva@qt.io>2022-06-06 11:45:49 +0300
committerJukka Jokiniva <jukka.jokiniva@qt.io>2023-12-21 13:00:21 +0000
commit7390975270b3af8b63b957138ec1473d05435419 (patch)
treef3a109279581257b9b1f6fb6224987d9ebda62e4
parentdb5c6a601e91e39265a5de8eb724e3198c994d2a (diff)
Fix issue of some changes not loading
After v3.5.2 version update the changes that had once failed an integration were not loading. This was because qt gerrit plugin has been using TAG_REVERTED when adding comment messages to failed builds, and the new Gerrit version is expecting a certain message structure on the comment. Change-Id: I752c323d6de8be4bdd99d8408804091895e8aebb (cherry picked from commit 86bdbbc48133b6ab07a44bef47a4785d504d7f09) Reviewed-by: Jukka Jokiniva <jukka.jokiniva@qt.io>
-rw-r--r--polygerrit-ui/app/utils/message-util.ts11
1 files changed, 8 insertions, 3 deletions
diff --git a/polygerrit-ui/app/utils/message-util.ts b/polygerrit-ui/app/utils/message-util.ts
index 5acdf33006..254112b820 100644
--- a/polygerrit-ui/app/utils/message-util.ts
+++ b/polygerrit-ui/app/utils/message-util.ts
@@ -14,7 +14,12 @@ function getRevertChangeIdFromMessage(msg: ChangeMessageInfo): ChangeId {
}
export function getRevertCreatedChangeIds(messages: ChangeMessageInfo[]) {
- return messages
- .filter(m => m.tag === MessageTag.TAG_REVERT)
- .map(m => getRevertChangeIdFromMessage(m));
+ try {
+ return messages
+ .filter(m => m.tag === MessageTag.TAG_REVERT)
+ .map(m => getRevertChangeIdFromMessage(m));
+ }
+ catch(err) {
+ return [];
+ }
}