diff options
author | Luca Milanesio <luca.milanesio@gmail.com> | 2023-10-20 13:08:24 +0000 |
---|---|---|
committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2023-10-20 13:08:24 +0000 |
commit | 598949526df50ff7f463c26e16fc93a09e533d19 (patch) | |
tree | 4e92fed695a40adc97b5d57b797709d146a4ee2d | |
parent | f9d7ae915f031499d5bf1e55798cadf0a1e34d35 (diff) | |
parent | b4c5aa9cc6756f78794c8ae0b50bcd912d9cea98 (diff) |
Merge "Fix OperatorPrecedence bug pattern flagged by error prone"
5 files changed, 12 insertions, 10 deletions
diff --git a/java/com/google/gerrit/extensions/common/EmailInfo.java b/java/com/google/gerrit/extensions/common/EmailInfo.java index 184a89f883..96e8adf946 100644 --- a/java/com/google/gerrit/extensions/common/EmailInfo.java +++ b/java/com/google/gerrit/extensions/common/EmailInfo.java @@ -20,6 +20,6 @@ public class EmailInfo { public Boolean pendingConfirmation; public void preferred(String e) { - this.preferred = e != null && e.equals(email) ? true : null; + this.preferred = (e != null && e.equals(email)) ? true : null; } } diff --git a/java/com/google/gerrit/server/restapi/project/CreateBranch.java b/java/com/google/gerrit/server/restapi/project/CreateBranch.java index 412559bf5a..ae9b1a88e3 100644 --- a/java/com/google/gerrit/server/restapi/project/CreateBranch.java +++ b/java/com/google/gerrit/server/restapi/project/CreateBranch.java @@ -208,8 +208,8 @@ public class CreateBranch info.canDelete = null; } else { info.canDelete = - permissionBackend.currentUser().ref(name).testOrFalse(RefPermission.DELETE) - && rsrc.getProjectState().statePermitsWrite() + (permissionBackend.currentUser().ref(name).testOrFalse(RefPermission.DELETE) + && rsrc.getProjectState().statePermitsWrite()) ? true : null; } diff --git a/java/com/google/gerrit/server/restapi/project/ListBranches.java b/java/com/google/gerrit/server/restapi/project/ListBranches.java index 1327319a6e..3cb412a50c 100644 --- a/java/com/google/gerrit/server/restapi/project/ListBranches.java +++ b/java/com/google/gerrit/server/restapi/project/ListBranches.java @@ -348,8 +348,8 @@ public class ListBranches implements RestReadView<ProjectResource> { info.canDelete = null; } else { info.canDelete = - perm.ref(ref.getName()).testOrFalse(RefPermission.DELETE) - && projectState.statePermitsWrite() + (perm.ref(ref.getName()).testOrFalse(RefPermission.DELETE) + && projectState.statePermitsWrite()) ? true : null; } @@ -415,9 +415,9 @@ public class ListBranches implements RestReadView<ProjectResource> { info.canDelete = null; } else { info.canDelete = - !targets.contains(ref.getName()) + (!targets.contains(ref.getName()) && perm.testOrFalse(RefPermission.DELETE) - && projectState.statePermitsWrite() + && projectState.statePermitsWrite()) ? true : null; } diff --git a/java/com/google/gerrit/server/restapi/project/ListTags.java b/java/com/google/gerrit/server/restapi/project/ListTags.java index 31e4be5a08..83d29de075 100644 --- a/java/com/google/gerrit/server/restapi/project/ListTags.java +++ b/java/com/google/gerrit/server/restapi/project/ListTags.java @@ -181,7 +181,9 @@ public class ListTags implements RestReadView<ProjectResource> { if (!isConfigRef(ref.getName())) { // Never allow to delete the meta config branch. canDelete = - perm.testOrFalse(RefPermission.DELETE) && projectState.statePermitsWrite() ? true : null; + (perm.testOrFalse(RefPermission.DELETE) && projectState.statePermitsWrite()) + ? true + : null; } ImmutableList<WebLinkInfo> webLinks = links.getTagLinks(projectState.getName(), ref.getName()); diff --git a/javatests/com/google/gerrit/acceptance/rest/account/ExternalIdIT.java b/javatests/com/google/gerrit/acceptance/rest/account/ExternalIdIT.java index a76bf47611..749ca792ca 100644 --- a/javatests/com/google/gerrit/acceptance/rest/account/ExternalIdIT.java +++ b/javatests/com/google/gerrit/acceptance/rest/account/ExternalIdIT.java @@ -1083,9 +1083,9 @@ public class ExternalIdIT extends AbstractDaemonTest { info.emailAddress = extId.email(); info.canDelete = !extId.isScheme(SCHEME_USERNAME) ? true : null; info.trusted = - extId.isScheme(SCHEME_MAILTO) + (extId.isScheme(SCHEME_MAILTO) || extId.isScheme(SCHEME_UUID) - || extId.isScheme(SCHEME_USERNAME) + || extId.isScheme(SCHEME_USERNAME)) ? true : null; return info; |