diff options
| author | Edwin Kempin <ekempin@google.com> | 2023-11-09 13:26:04 +0000 |
|---|---|---|
| committer | Luca Milanesio <luca.milanesio@gmail.com> | 2023-11-10 18:38:39 +0000 |
| commit | 4d82d64510e1902440e790475450f72bc62ec4fd (patch) | |
| tree | 3d6a49803f1a4e766b0a95be6433619df89f10c3 | |
| parent | 86c61b4de9bb6115fb71c87e97508d903ae6b327 (diff) | |
RequestInfo.Builder: Annotate addHeader method with @CanIgnoreReturnValue
This method returns the Builder instance to allow chaining calls, but
ignoring the return value is fine.
Release-Notes: skip
Change-Id: I93dcf6768cfb7739f7c7a9005c3f60dbd02242e4
Signed-off-by: Edwin Kempin <ekempin@google.com>
(cherry picked from commit 2ea69de48b033f17c62c76987ff06f28b03d7bcc)
| -rw-r--r-- | java/com/google/gerrit/server/RequestInfo.java | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/java/com/google/gerrit/server/RequestInfo.java b/java/com/google/gerrit/server/RequestInfo.java index e1a5148ca0..927985d8a6 100644 --- a/java/com/google/gerrit/server/RequestInfo.java +++ b/java/com/google/gerrit/server/RequestInfo.java @@ -21,6 +21,7 @@ import com.google.auto.value.AutoValue; import com.google.auto.value.extension.memoized.Memoized; import com.google.common.base.Splitter; import com.google.common.collect.ImmutableList; +import com.google.errorprone.annotations.CanIgnoreReturnValue; import com.google.gerrit.common.UsedAt; import com.google.gerrit.entities.Project; import com.google.gerrit.server.logging.TraceContext; @@ -184,6 +185,7 @@ public abstract class RequestInfo { abstract ImmutableList.Builder<String> headersBuilder(); /** Adds a header. */ + @CanIgnoreReturnValue public Builder addHeader(String headerName, String headerValue) { headersBuilder().add(headerName + "=" + headerValue); return this; |