diff options
author | Thiago Perrotta <tperrotta@google.com> | 2023-11-07 16:25:07 +0100 |
---|---|---|
committer | Luca Milanesio <luca.milanesio@gmail.com> | 2023-11-10 18:36:29 +0000 |
commit | 86c61b4de9bb6115fb71c87e97508d903ae6b327 (patch) | |
tree | 2c2fe55a40a385caf36ef0a68c9c40946c6faeb1 | |
parent | a1b9e776304008163cb0305e901f60b37eef379b (diff) |
UX: "Your Turn" -> "Your turn"
All other sections in the Gerrit UI homepage only capitalize the first
letter, e.g. "Incoming reviews", "Recently closed".
Make "Your turn" follow suit for consistency.
Release-Notes: skip
Bug: Google b/199148117
Change-Id: I69cab02dafeecec6fbe3b18b439e05387b71e9c5
(cherry picked from commit f17c09fd4e4ff9414921133cea0e05d72bbe3bf2)
-rw-r--r-- | Documentation/user-attention-set.txt | 8 | ||||
-rw-r--r-- | polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.ts | 4 | ||||
-rw-r--r-- | polygerrit-ui/app/utils/dashboard-util.ts | 2 |
3 files changed, 7 insertions, 7 deletions
diff --git a/Documentation/user-attention-set.txt b/Documentation/user-attention-set.txt index ad3d65c3d3..9825478a5f 100644 --- a/Documentation/user-attention-set.txt +++ b/Documentation/user-attention-set.txt @@ -97,21 +97,21 @@ uploader) to the attention set, if it comes along with a negative vote. === Dashboard -The default *dashboard* contains a new section at the top called "Your Turn". It +The default *dashboard* contains a new section at the top called "Your turn". It lists all changes where the logged-in user is in the attention set. When you are a reviewer, the change is highlighted and is shown at the top of the section. The "Waiting" column indicates how long the owner has already been waiting for you to act. -image::images/user-attention-set-dashboard.png["dashboard with Your Turn section", align="center"] +image::images/user-attention-set-dashboard.png["dashboard with Your turn section", align="center"] As an active developer, one of your daily goals will be to iterate over this list and clear it. -image::images/user-attention-set-dashboard-empty.png["dashboard with empty Your Turn section", align="center"] +image::images/user-attention-set-dashboard-empty.png["dashboard with empty Your turn section", align="center"] Note that you can also navigate to other users' dashboards to check their -"Your Turn" section. +"Your turn" section. === Emails diff --git a/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.ts b/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.ts index 00729fd4eb..ace2fb5063 100644 --- a/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.ts +++ b/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.ts @@ -488,7 +488,7 @@ export class GrDashboardView extends LitElement { /** * Usually we really want to stick to the sorting that the backend provides, - * but for the "Your Turn" section it is important to put the changes at the + * but for the "Your turn" section it is important to put the changes at the * top where the current user is a reviewer. Owned changes are less important. * And then we want to emphasize the changes where the waiting time is larger. */ @@ -505,7 +505,7 @@ export class GrDashboardView extends LitElement { const c1Owner = c1.owner._account_id === userId; const c2Owner = c2.owner._account_id === userId; if (c1Owner !== c2Owner) return c1Owner ? 1 : -1; - // Should never happen, because the change is in the 'Your Turn' + // Should never happen, because the change is in the 'Your turn' // section, so the userId should be found in the attention set of both. if (!c1.attention_set || !c1.attention_set[userId]) return 0; if (!c2.attention_set || !c2.attention_set[userId]) return 0; diff --git a/polygerrit-ui/app/utils/dashboard-util.ts b/polygerrit-ui/app/utils/dashboard-util.ts index caff6039d0..6087e2cc1e 100644 --- a/polygerrit-ui/app/utils/dashboard-util.ts +++ b/polygerrit-ui/app/utils/dashboard-util.ts @@ -40,7 +40,7 @@ const HAS_DRAFTS: DashboardSection = { export const YOUR_TURN: DashboardSection = { // Changes where the user is in the attention set. - name: 'Your Turn', + name: 'Your turn', query: 'attention:${user}', hideIfEmpty: false, suffixForDashboard: 'limit:25', |