summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThiago Perrotta <tperrotta@google.com>2023-11-07 16:20:11 +0100
committerLuca Milanesio <luca.milanesio@gmail.com>2023-11-10 15:03:50 +0000
commitd93874058236a38788d2d2a23df001e4c7a28705 (patch)
tree78365d6e1b23c44b58b84baebc333dc080993ba7
parent71abbe6ff04a31d33923d45c07846f4ea0256ca8 (diff)
Add 'm' alias for the 'message' search operator
This follows the precedent of other aliases e.g. "description" <-> "d" for "message". Release-Notes: Added 'm' alias for the 'message' operator Bug: Google b/303402734 Change-Id: I90c0483864bd2b6fe8f9064b02acc5880745fb5d (cherry picked from commit 4daf87e1b52aba1b51e37d693a1bc8c3940858d3)
-rw-r--r--Documentation/user-search.txt2
-rw-r--r--java/com/google/gerrit/server/query/change/ChangeQueryBuilder.java5
-rw-r--r--javatests/com/google/gerrit/server/query/change/AbstractQueryChangesTest.java10
3 files changed, 16 insertions, 1 deletions
diff --git a/Documentation/user-search.txt b/Documentation/user-search.txt
index cc020ada7a..0744dedf52 100644
--- a/Documentation/user-search.txt
+++ b/Documentation/user-search.txt
@@ -345,7 +345,7 @@ a review. See <<labels,labels>> below for more detail on the format
of the argument.
[[message]]
-message:'MESSAGE'::, description:'MESSAGE'::, d:'MESSAGE'::
+message:'MESSAGE'::, m:'MESSAGE'::, description:'MESSAGE'::, d:'MESSAGE'::
+
Changes that match 'MESSAGE' arbitrary string in the commit message body.
By default full text matching is used, but regular expressions can be
diff --git a/java/com/google/gerrit/server/query/change/ChangeQueryBuilder.java b/java/com/google/gerrit/server/query/change/ChangeQueryBuilder.java
index 9deedab26e..da14d45e31 100644
--- a/java/com/google/gerrit/server/query/change/ChangeQueryBuilder.java
+++ b/java/com/google/gerrit/server/query/change/ChangeQueryBuilder.java
@@ -1179,6 +1179,11 @@ public class ChangeQueryBuilder extends QueryBuilder<ChangeData, ChangeQueryBuil
}
@Operator
+ public Predicate<ChangeData> m(String text) throws QueryParseException {
+ return message(text);
+ }
+
+ @Operator
public Predicate<ChangeData> message(String text) throws QueryParseException {
if (text.startsWith("^")) {
checkFieldAvailable(
diff --git a/javatests/com/google/gerrit/server/query/change/AbstractQueryChangesTest.java b/javatests/com/google/gerrit/server/query/change/AbstractQueryChangesTest.java
index c7b1299596..841e0bc312 100644
--- a/javatests/com/google/gerrit/server/query/change/AbstractQueryChangesTest.java
+++ b/javatests/com/google/gerrit/server/query/change/AbstractQueryChangesTest.java
@@ -1117,6 +1117,11 @@ public abstract class AbstractQueryChangesTest extends GerritServerTests {
}
@Test
+ public void byMessageExact_byAlias_m() throws Exception {
+ byMessageExact("m:", "m_repo");
+ }
+
+ @Test
public void byMessageExact_byMainOperator() throws Exception {
byMessageExact("message:", "message_repo");
}
@@ -1147,6 +1152,11 @@ public abstract class AbstractQueryChangesTest extends GerritServerTests {
}
@Test
+ public void byMessageRegEx_byAlias_m() throws Exception {
+ byMessageRegEx("m:", "m_repo");
+ }
+
+ @Test
public void byMessageRegEx_byMainOperator() throws Exception {
byMessageRegEx("message:", "message_repo");
}