diff options
| author | Ismo Haataja <ismo.haataja@digia.com> | 2014-10-30 12:38:12 +0200 |
|---|---|---|
| committer | Ismo Haataja <ismo.haataja@digia.com> | 2015-01-13 14:12:11 +0100 |
| commit | 66522d326988614cbe544103f99be14e415e44bd (patch) | |
| tree | a0a9bcf2d434d6a84ca51afa2918f3910bee055b | |
| parent | f0d58169270d0947f8e048a59577549eda753fa2 (diff) | |
Fix NPE in one page review
Accessing the score list variable before it was created caused NPE (null
pointer exception). This was the origin for empty diff when no user
logged in.
Task-number: QTQAINFRA-905
Change-Id: Id453bbf4f95e278851a7a6a0ab1c69c460386709
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
Reviewed-by: Ismo Haataja <ismo.haataja@digia.com>
| -rw-r--r-- | gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/AllInOnePatchScreen.java | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/AllInOnePatchScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/AllInOnePatchScreen.java index d2d3c3c6ac..923dc99af0 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/AllInOnePatchScreen.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/AllInOnePatchScreen.java @@ -397,7 +397,9 @@ public class AllInOnePatchScreen extends AbstractPatchScreen implements files.clear(); diffs.clear(); keyNavigation.clear(); - approvalPanel.clear(); + if (approvalPanel != null) { + approvalPanel.clear(); + } loadDiffs(); CallbackGroup cbs = new CallbackGroup(); |