summaryrefslogtreecommitdiffstats
path: root/resources
diff options
context:
space:
mode:
authorWyatt Allen <wyatta@google.com>2018-06-19 19:45:35 +0000
committerGerrit Code Review <noreply-gerritcodereview@google.com>2018-06-19 19:45:35 +0000
commite1e25bc78b0b8900f9bbacb58898d60c459d4e6b (patch)
tree7c725b26d0f223b7280439dcda4aac18b2c62faa /resources
parent23d7a59533501c163eef5d990cfd350610290728 (diff)
parentd0c11c2bdef60058a48b9cab5c6a72a97f093fba (diff)
Merge "Insert space to prevent overagressive email linkification"
Diffstat (limited to 'resources')
-rw-r--r--resources/com/google/gerrit/server/mail/Comment.soy11
1 files changed, 9 insertions, 2 deletions
diff --git a/resources/com/google/gerrit/server/mail/Comment.soy b/resources/com/google/gerrit/server/mail/Comment.soy
index 31704483ff..f9a11cdc5b 100644
--- a/resources/com/google/gerrit/server/mail/Comment.soy
+++ b/resources/com/google/gerrit/server/mail/Comment.soy
@@ -39,7 +39,9 @@
{/if}
{for $group in $commentFiles}
- {$group.link}{\n}
+ // Insert a space before the newline so that Gmail does not mistakenly link
+ // the following line with the file link. See issue 9201.
+ {$group.link}{sp}{\n}
{$group.title}:{\n}
{\n}
@@ -53,7 +55,12 @@
{if isFirst($line)}
{if $comment.startLine != 0}
{$comment.link}
- {/if}{\n}
+ {/if}
+
+ // Insert a space before the newline so that Gmail does not mistakenly
+ // link the following line with the file link. See issue 9201.
+ {sp}{\n}
+
{$comment.linePrefix}
{else}
{$comment.linePrefixEmpty}