Bazel: Fix more buildifier warnings

This fixes buildifier warnings that were not fixed in automatic
mode:

  $ find . \( -name BUILD -o -name "*.bzl" \) -print \
      | xargs buildifier --lint=warn

* Remove unused variables
* Pattern `src/test/java/com/google/gerrit/server/project/Util.java`
  has no wildcard ('*')
* All calls to rules or macros should pass arguments by keyword
  (arg_name=value) syntax
* ctx.new_file is deprecated, used ctx.actions.declare_file instead

Change-Id: I1f8a04e8d576ab637ba8a46118720218ec486fff

1 files changed, 2 insertions, 4 deletions

diff --git a/tools/bzl/js.bzl b/tools/bzl/js.bzl
index 3a696ddd77..11f17baaff 100644
--- a/tools/bzl/js.bzl
+++ b/tools/bzl/js.bzl
@@ -307,10 +307,8 @@ Outputs:
 
 def _vulcanize_impl(ctx):
     # intermediate artifact.
-    vulcanized = ctx.new_file(
-        ctx.configuration.genfiles_dir,
-        ctx.outputs.html,
-        ".vulcanized.html",
+    vulcanized = ctx.actions.declare_file(
+        ctx.outputs.html.path + ".vulcanized.html",
     )
     destdir = ctx.outputs.html.path + ".dir"
     zips = [z for d in ctx.attr.deps for z in d.transitive_zipfiles]