diff options
-rw-r--r-- | polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view.js | 4 | ||||
-rw-r--r-- | polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view_test.html | 11 |
2 files changed, 4 insertions, 11 deletions
diff --git a/polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view.js b/polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view.js index d2ffa566fa..b766e7f903 100644 --- a/polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view.js +++ b/polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view.js @@ -184,9 +184,7 @@ class GrEditorView extends mixinBehaviors( [ } _viewEditInChangeView() { - const patch = this._successfulSave ? this.EDIT_NAME : this._patchNum; - GerritNav.navigateToChange(this._change, patch, null, - patch !== this.EDIT_NAME); + GerritNav.navigateToChange(this._change, undefined, undefined, true); } _getFileData(changeNum, path, patchNum) { diff --git a/polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view_test.html b/polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view_test.html index e385854f51..f353a1c31b 100644 --- a/polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view_test.html +++ b/polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view_test.html @@ -297,18 +297,13 @@ suite('gr-editor-view tests', () => { element._showAlert('test message'); }); - test('_viewEditInChangeView respects _patchNum', () => { + test('_viewEditInChangeView', () => { navigateStub.restore(); const navStub = sandbox.stub(GerritNav, 'navigateToChange'); element._patchNum = element.EDIT_NAME; element._viewEditInChangeView(); - assert.equal(navStub.lastCall.args[1], element.EDIT_NAME); - element._patchNum = '1'; - element._viewEditInChangeView(); - assert.equal(navStub.lastCall.args[1], '1'); - element._successfulSave = true; - element._viewEditInChangeView(); - assert.equal(navStub.lastCall.args[1], element.EDIT_NAME); + assert.equal(navStub.lastCall.args[1], undefined); + assert.equal(navStub.lastCall.args[3], true); }); suite('keyboard shortcuts', () => { |