diff options
Diffstat (limited to 'gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PatchSetsBlock.java')
-rw-r--r-- | gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PatchSetsBlock.java | 31 |
1 files changed, 8 insertions, 23 deletions
diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PatchSetsBlock.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PatchSetsBlock.java index e854cab8d0..7e659a1b46 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PatchSetsBlock.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PatchSetsBlock.java @@ -17,8 +17,8 @@ package com.google.gerrit.client.changes; import com.google.gerrit.client.Gerrit; import com.google.gerrit.common.PageLinks; import com.google.gerrit.common.data.ChangeDetail; -import com.google.gerrit.reviewdb.AccountGeneralPreferences; -import com.google.gerrit.reviewdb.PatchSet; +import com.google.gerrit.reviewdb.client.AccountGeneralPreferences; +import com.google.gerrit.reviewdb.client.PatchSet; import com.google.gwt.event.dom.client.ClickEvent; import com.google.gwt.event.dom.client.ClickHandler; import com.google.gwt.event.dom.client.KeyPressEvent; @@ -43,11 +43,9 @@ import java.util.Map; * that keyboard navigation to each changed file in all patch sets is possible. */ public class PatchSetsBlock extends Composite { - private final Map<PatchSet.Id, PatchSetComplexDisclosurePanel> patchSetPanels = new HashMap<PatchSet.Id, PatchSetComplexDisclosurePanel>(); - private final ChangeScreen parent; private final FlowPanel body; private HandlerRegistration regNavigation; @@ -65,8 +63,7 @@ public class PatchSetsBlock extends Composite { /** Patch sets on this change, in order. */ private List<PatchSet> patchSets; - PatchSetsBlock(final ChangeScreen parent) { - this.parent = parent; + PatchSetsBlock() { body = new FlowPanel(); initWidget(body); } @@ -79,12 +76,6 @@ public class PatchSetsBlock extends Composite { currentPatchSetId = currps.getId(); patchSets = detail.getPatchSets(); - final List<PatchSet.Id> changePatchSets = new ArrayList<PatchSet.Id>(); - - for (final PatchSet ps : patchSets) { - changePatchSets.add(ps.getId()); - } - if (Gerrit.isSignedIn()) { final AccountGeneralPreferences p = Gerrit.getUserAccount().getGeneralPreferences(); @@ -96,19 +87,13 @@ public class PatchSetsBlock extends Composite { patchSetPanelsList = new ArrayList<PatchSetComplexDisclosurePanel>(); for (final PatchSet ps : patchSets) { - final PatchSetComplexDisclosurePanel p; - if (ps == currps) { - p = new PatchSetComplexDisclosurePanel(parent, detail, detail - .getCurrentPatchSetDetail()); - if (diffBaseId != null) { - p.setDiffBaseId(diffBaseId); + final PatchSetComplexDisclosurePanel p = + new PatchSetComplexDisclosurePanel(ps, ps == currps); + if (diffBaseId != null) { + p.setDiffBaseId(diffBaseId); + if (ps == currps) { p.refresh(); } - } else { - p = new PatchSetComplexDisclosurePanel(parent, detail, ps); - if (diffBaseId != null) { - p.setDiffBaseId(diffBaseId); - } } add(p); patchSetPanelsList.add(p); |