diff options
Diffstat (limited to 'gerrit-pgm/src/main/java/com/google/gerrit/pgm/http/jetty/JettyServer.java')
-rw-r--r-- | gerrit-pgm/src/main/java/com/google/gerrit/pgm/http/jetty/JettyServer.java | 23 |
1 files changed, 14 insertions, 9 deletions
diff --git a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/http/jetty/JettyServer.java b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/http/jetty/JettyServer.java index 7ab8d30254..0a0a3cc6fd 100644 --- a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/http/jetty/JettyServer.java +++ b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/http/jetty/JettyServer.java @@ -19,14 +19,12 @@ import static java.util.concurrent.TimeUnit.SECONDS; import com.google.gerrit.launcher.GerritLauncher; import com.google.gerrit.lifecycle.LifecycleListener; -import com.google.gerrit.reviewdb.AuthType; -import com.google.gerrit.server.CurrentUser; +import com.google.gerrit.reviewdb.client.AuthType; import com.google.gerrit.server.config.ConfigUtil; import com.google.gerrit.server.config.GerritServerConfig; import com.google.gerrit.server.config.SitePaths; import com.google.inject.Inject; import com.google.inject.Injector; -import com.google.inject.Provider; import com.google.inject.Singleton; import com.google.inject.servlet.GuiceFilter; import com.google.inject.servlet.GuiceServletContextListener; @@ -107,7 +105,7 @@ public class JettyServer { @Inject JettyServer(@GerritServerConfig final Config cfg, final SitePaths site, - final JettyEnv env, final Provider<CurrentUser> userProvider) + final JettyEnv env) throws MalformedURLException, IOException { this.site = site; @@ -118,7 +116,7 @@ public class JettyServer { Handler app = makeContext(env, cfg); if (cfg.getBoolean("httpd", "requestlog", !reverseProxy)) { RequestLogHandler handler = new RequestLogHandler(); - handler.setRequestLog(new HttpLog(site, userProvider)); + handler.setRequestLog(new HttpLog(site, cfg)); handler.setHandler(app); app = handler; } @@ -143,7 +141,7 @@ public class JettyServer { final int acceptors = cfg.getInt("httpd", "acceptorThreads", 2); final AuthType authType = ConfigUtil.getEnum(cfg, "auth", null, "type", AuthType.OPENID); - reverseProxy = true; + reverseProxy = isReverseProxied(listenUrls); final Connector[] connectors = new Connector[listenUrls.length]; for (int idx = 0; idx < listenUrls.length; idx++) { final URI u = listenUrls[idx]; @@ -158,7 +156,6 @@ public class JettyServer { } if ("http".equals(u.getScheme())) { - reverseProxy = false; defaultPort = 80; c = new SelectChannelConnector(); } else if ("https".equals(u.getScheme())) { @@ -177,7 +174,6 @@ public class JettyServer { ssl.setNeedClientAuth(true); } - reverseProxy = false; defaultPort = 443; c = ssl; @@ -235,7 +231,16 @@ public class JettyServer { return connectors; } - private URI[] listenURLs(final Config cfg) { + static boolean isReverseProxied(final URI[] listenUrls) { + for (URI u : listenUrls) { + if ("http".equals(u.getScheme()) || "https".equals(u.getScheme())) { + return false; + } + } + return true; + } + + static URI[] listenURLs(final Config cfg) { String[] urls = cfg.getStringList("httpd", null, "listenurl"); if (urls.length == 0) { urls = new String[] {"http://*:8080/"}; |