summaryrefslogtreecommitdiffstats
path: root/gerrit-server/src/main/java/com/google/gerrit/server/account/GroupDetailFactory.java
diff options
context:
space:
mode:
Diffstat (limited to 'gerrit-server/src/main/java/com/google/gerrit/server/account/GroupDetailFactory.java')
-rw-r--r--gerrit-server/src/main/java/com/google/gerrit/server/account/GroupDetailFactory.java37
1 files changed, 18 insertions, 19 deletions
diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/account/GroupDetailFactory.java b/gerrit-server/src/main/java/com/google/gerrit/server/account/GroupDetailFactory.java
index 2e500bdb43..cade9c7c6f 100644
--- a/gerrit-server/src/main/java/com/google/gerrit/server/account/GroupDetailFactory.java
+++ b/gerrit-server/src/main/java/com/google/gerrit/server/account/GroupDetailFactory.java
@@ -20,7 +20,7 @@ import com.google.gerrit.common.data.GroupReference;
import com.google.gerrit.common.errors.NoSuchGroupException;
import com.google.gerrit.reviewdb.client.Account;
import com.google.gerrit.reviewdb.client.AccountGroup;
-import com.google.gerrit.reviewdb.client.AccountGroupInclude;
+import com.google.gerrit.reviewdb.client.AccountGroupIncludeByUuid;
import com.google.gerrit.reviewdb.client.AccountGroupMember;
import com.google.gerrit.reviewdb.server.ReviewDb;
import com.google.gwtorm.server.OrmException;
@@ -80,10 +80,11 @@ public class GroupDetailFactory implements Callable<GroupDetail> {
detail.setMembers(loadMembers());
detail.setIncludes(loadIncludes());
break;
+ case SYSTEM:
+ break;
}
detail.setAccounts(aic.create());
detail.setCanModify(control.isOwner());
- detail.setGroups(gic.create());
return detail;
}
@@ -121,36 +122,34 @@ public class GroupDetailFactory implements Callable<GroupDetail> {
return members;
}
- private List<AccountGroupInclude> loadIncludes() throws OrmException {
- List<AccountGroupInclude> groups = new ArrayList<AccountGroupInclude>();
+ private List<AccountGroupIncludeByUuid> loadIncludes() throws OrmException {
+ List<AccountGroupIncludeByUuid> groups = new ArrayList<AccountGroupIncludeByUuid>();
- for (final AccountGroupInclude m : db.accountGroupIncludes().byGroup(groupId)) {
- if (control.canSeeGroup(m.getIncludeId())) {
- gic.want(m.getIncludeId());
+ for (final AccountGroupIncludeByUuid m : db.accountGroupIncludesByUuid().byGroup(groupId)) {
+ if (control.canSeeGroup(m.getIncludeUUID())) {
+ gic.want(m.getIncludeUUID());
groups.add(m);
}
}
- Collections.sort(groups, new Comparator<AccountGroupInclude>() {
- public int compare(final AccountGroupInclude o1,
- final AccountGroupInclude o2) {
- final AccountGroup a = gic.get(o1.getIncludeId());
- final AccountGroup b = gic.get(o2.getIncludeId());
+ Collections.sort(groups, new Comparator<AccountGroupIncludeByUuid>() {
+ public int compare(final AccountGroupIncludeByUuid o1,
+ final AccountGroupIncludeByUuid o2) {
+ GroupDescription.Basic a = gic.get(o1.getIncludeUUID());
+ GroupDescription.Basic b = gic.get(o2.getIncludeUUID());
return n(a).compareTo(n(b));
}
- private String n(final AccountGroup a) {
- String n = a.getName();
- if (n != null && n.length() > 0) {
- return n;
+ private String n (GroupDescription.Basic a) {
+ if (a == null) {
+ return "";
}
- n = a.getDescription();
+ String n = a.getName();
if (n != null && n.length() > 0) {
return n;
}
-
- return a.getId().toString();
+ return a.getGroupUUID().get();
}
});