diff options
Diffstat (limited to 'gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchSetInfoFactory.java')
-rw-r--r-- | gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchSetInfoFactory.java | 33 |
1 files changed, 12 insertions, 21 deletions
diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchSetInfoFactory.java b/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchSetInfoFactory.java index 646d4ce427..f59dcc36a9 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchSetInfoFactory.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchSetInfoFactory.java @@ -14,18 +14,17 @@ package com.google.gerrit.server.patch; -import com.google.gerrit.reviewdb.Account; -import com.google.gerrit.reviewdb.Change; -import com.google.gerrit.reviewdb.PatchSet; -import com.google.gerrit.reviewdb.PatchSetInfo; -import com.google.gerrit.reviewdb.Project; -import com.google.gerrit.reviewdb.RevId; -import com.google.gerrit.reviewdb.ReviewDb; -import com.google.gerrit.reviewdb.UserIdentity; +import com.google.gerrit.reviewdb.client.Account; +import com.google.gerrit.reviewdb.client.Change; +import com.google.gerrit.reviewdb.client.PatchSet; +import com.google.gerrit.reviewdb.client.PatchSetInfo; +import com.google.gerrit.reviewdb.client.Project; +import com.google.gerrit.reviewdb.client.RevId; +import com.google.gerrit.reviewdb.client.UserIdentity; +import com.google.gerrit.reviewdb.server.ReviewDb; import com.google.gerrit.server.account.AccountByEmailCache; import com.google.gerrit.server.git.GitRepositoryManager; -import com.google.gwtorm.client.OrmException; -import com.google.gwtorm.client.SchemaFactory; +import com.google.gwtorm.server.OrmException; import com.google.inject.Inject; import com.google.inject.Singleton; @@ -49,15 +48,12 @@ import java.util.Set; @Singleton public class PatchSetInfoFactory { private final GitRepositoryManager repoManager; - private final SchemaFactory<ReviewDb> schemaFactory; private final AccountByEmailCache byEmailCache; @Inject public PatchSetInfoFactory(final GitRepositoryManager grm, - final SchemaFactory<ReviewDb> schemaFactory, final AccountByEmailCache byEmailCache) { this.repoManager = grm; - this.schemaFactory = schemaFactory; this.byEmailCache = byEmailCache; } @@ -67,16 +63,14 @@ public class PatchSetInfoFactory { info.setMessage(src.getFullMessage()); info.setAuthor(toUserIdentity(src.getAuthorIdent())); info.setCommitter(toUserIdentity(src.getCommitterIdent())); - + info.setRevId(src.getName()); return info; } - public PatchSetInfo get(PatchSet.Id patchSetId) - throws PatchSetInfoNotAvailableException { - ReviewDb db = null; + public PatchSetInfo get(ReviewDb db, PatchSet.Id patchSetId) + throws PatchSetInfoNotAvailableException { Repository repo = null; try { - db = schemaFactory.open(); final PatchSet patchSet = db.patchSets().get(patchSetId); final Change change = db.changes().get(patchSet.getId().getParentKey()); final Project.NameKey projectKey = change.getProject(); @@ -96,9 +90,6 @@ public class PatchSetInfoFactory { } catch (IOException e) { throw new PatchSetInfoNotAvailableException(e); } finally { - if (db != null) { - db.close(); - } if (repo != null) { repo.close(); } |