diff options
Diffstat (limited to 'java/com/google/gerrit/server/StarredChangesUtil.java')
-rw-r--r-- | java/com/google/gerrit/server/StarredChangesUtil.java | 27 |
1 files changed, 16 insertions, 11 deletions
diff --git a/java/com/google/gerrit/server/StarredChangesUtil.java b/java/com/google/gerrit/server/StarredChangesUtil.java index 9962c39153..035b3a5a1b 100644 --- a/java/com/google/gerrit/server/StarredChangesUtil.java +++ b/java/com/google/gerrit/server/StarredChangesUtil.java @@ -385,18 +385,23 @@ public class StarredChangesUtil { public static StarRef readLabels(Repository repo, String refName) throws IOException { try (TraceTimer traceTimer = TraceContext.newTimer("Read star labels from %s", refName)) { Ref ref = repo.exactRef(refName); - if (ref == null) { - return StarRef.MISSING; - } + return readLabels(repo, ref); + } + } - try (ObjectReader reader = repo.newObjectReader()) { - ObjectLoader obj = reader.open(ref.getObjectId(), Constants.OBJ_BLOB); - return StarRef.create( - ref, - Splitter.on(CharMatcher.whitespace()) - .omitEmptyStrings() - .split(new String(obj.getCachedBytes(Integer.MAX_VALUE), UTF_8))); - } + public static StarRef readLabels(Repository repo, Ref ref) throws IOException { + if (ref == null) { + return StarRef.MISSING; + } + try (TraceTimer traceTimer = + TraceContext.newTimer("Read star labels from %s (without ref lookup)", ref.getName()); + ObjectReader reader = repo.newObjectReader()) { + ObjectLoader obj = reader.open(ref.getObjectId(), Constants.OBJ_BLOB); + return StarRef.create( + ref, + Splitter.on(CharMatcher.whitespace()) + .omitEmptyStrings() + .split(new String(obj.getCachedBytes(Integer.MAX_VALUE), UTF_8))); } } |