diff options
Diffstat (limited to 'polygerrit-ui/app/elements/core/gr-main-header/gr-main-header_test.ts')
-rw-r--r-- | polygerrit-ui/app/elements/core/gr-main-header/gr-main-header_test.ts | 89 |
1 files changed, 48 insertions, 41 deletions
diff --git a/polygerrit-ui/app/elements/core/gr-main-header/gr-main-header_test.ts b/polygerrit-ui/app/elements/core/gr-main-header/gr-main-header_test.ts index 0f58ac0c2e..4dcb755d6f 100644 --- a/polygerrit-ui/app/elements/core/gr-main-header/gr-main-header_test.ts +++ b/polygerrit-ui/app/elements/core/gr-main-header/gr-main-header_test.ts @@ -33,29 +33,33 @@ const basicFixture = fixtureFromElement('gr-main-header'); suite('gr-main-header tests', () => { let element: GrMainHeader; - setup(() => { + setup(async () => { stubRestApi('probePath').returns(Promise.resolve(false)); - stub('gr-main-header', '_loadAccount').callsFake(() => Promise.resolve()); + stub('gr-main-header', 'loadAccount').callsFake(() => Promise.resolve()); element = basicFixture.instantiate(); + await element.updateComplete; }); - test('link visibility', () => { + test('link visibility', async () => { element.loading = true; + await element.updateComplete; assert.isTrue(isHidden(query(element, '.accountContainer'))); element.loading = false; element.loggedIn = false; + await element.updateComplete; assert.isFalse(isHidden(query(element, '.accountContainer'))); assert.isFalse(isHidden(query(element, '.loginButton'))); - assert.isFalse(isHidden(query(element, '.registerButton'))); - assert.isTrue(isHidden(query(element, '.registerDiv'))); + assert.isNotOk(query(element, '.registerDiv')); + assert.isNotOk(query(element, '.registerButton')); - element._account = createAccountDetailWithId(1); - flush(); + element.account = createAccountDetailWithId(1); + await element.updateComplete; assert.isTrue(isHidden(query(element, 'gr-account-dropdown'))); assert.isTrue(isHidden(query(element, '.settingsButton'))); element.loggedIn = true; + await element.updateComplete; assert.isTrue(isHidden(query(element, '.loginButton'))); assert.isTrue(isHidden(query(element, '.registerButton'))); assert.isFalse(isHidden(query(element, 'gr-account-dropdown'))); @@ -67,7 +71,7 @@ suite('gr-main-header tests', () => { [ {url: 'https://awesometown.com/#hashyhash', name: '', target: ''}, {url: 'url', name: '', target: '_blank'}, - ].map(element._createHeaderLink), + ].map(element.createHeaderLink), [ {url: 'https://awesometown.com/#hashyhash', name: ''}, {url: 'url', name: ''}, @@ -99,13 +103,13 @@ suite('gr-main-header tests', () => { name: 'Repos', url: '/repos', noBaseUrl: true, - view: null, + view: undefined, }, ]; // When no admin links are passed, it should use the default. assert.deepEqual( - element._computeLinks( + element.computeLinks( /* userLinks= */ [], adminLinks, /* topMenus= */ [], @@ -118,7 +122,7 @@ suite('gr-main-header tests', () => { }) ); assert.deepEqual( - element._computeLinks( + element.computeLinks( userLinks, adminLinks, /* topMenus= */ [], @@ -146,11 +150,11 @@ suite('gr-main-header tests', () => { }, ]; - assert.deepEqual(element._getDocLinks(null, docLinks), []); - assert.deepEqual(element._getDocLinks('', docLinks), []); - assert.deepEqual(element._getDocLinks('base', []), []); + assert.deepEqual(element.getDocLinks(null, docLinks), []); + assert.deepEqual(element.getDocLinks('', docLinks), []); + assert.deepEqual(element.getDocLinks('base', []), []); - assert.deepEqual(element._getDocLinks('base', docLinks), [ + assert.deepEqual(element.getDocLinks('base', docLinks), [ { name: 'Table of Contents', target: '_blank', @@ -158,7 +162,7 @@ suite('gr-main-header tests', () => { }, ]); - assert.deepEqual(element._getDocLinks('base/', docLinks), [ + assert.deepEqual(element.getDocLinks('base/', docLinks), [ { name: 'Table of Contents', target: '_blank', @@ -173,7 +177,7 @@ suite('gr-main-header tests', () => { name: 'Repos', url: '/repos', noBaseUrl: true, - view: null, + view: undefined, }, ]; const topMenus = [ @@ -189,7 +193,7 @@ suite('gr-main-header tests', () => { }, ]; assert.deepEqual( - element._computeLinks( + element.computeLinks( /* userLinks= */ [], adminLinks, topMenus, @@ -220,7 +224,7 @@ suite('gr-main-header tests', () => { name: 'Repos', url: '/repos', noBaseUrl: true, - view: null, + view: undefined, }, ]; const topMenus = [ @@ -241,7 +245,7 @@ suite('gr-main-header tests', () => { }, ]; assert.deepEqual( - element._computeLinks( + element.computeLinks( /* userLinks= */ [], adminLinks, topMenus, @@ -272,7 +276,7 @@ suite('gr-main-header tests', () => { name: 'Repos', url: '/repos', noBaseUrl: true, - view: null, + view: undefined, }, ]; const topMenus = [ @@ -298,7 +302,7 @@ suite('gr-main-header tests', () => { }, ]; assert.deepEqual( - element._computeLinks( + element.computeLinks( /* userLinks= */ [], adminLinks, topMenus, @@ -352,7 +356,7 @@ suite('gr-main-header tests', () => { }, ]; assert.deepEqual( - element._computeLinks( + element.computeLinks( /* userLinks= */ [], /* adminLinks= */ [], topMenus, @@ -398,7 +402,7 @@ suite('gr-main-header tests', () => { }, ]; assert.deepEqual( - element._computeLinks( + element.computeLinks( userLinks, /* adminLinks= */ [], topMenus, @@ -434,7 +438,7 @@ suite('gr-main-header tests', () => { name: 'Repos', url: '/repos', noBaseUrl: true, - view: null, + view: undefined, }, ]; const topMenus = [ @@ -450,7 +454,7 @@ suite('gr-main-header tests', () => { }, ]; assert.deepEqual( - element._computeLinks( + element.computeLinks( /* userLinks= */ [], adminLinks, topMenus, @@ -473,7 +477,7 @@ suite('gr-main-header tests', () => { }); test('shows feedback icon when URL provided', async () => { - assert.isEmpty(element._feedbackURL); + assert.isEmpty(element.feedbackURL); assert.isNotOk(query(element, '.feedbackButton > a')); const url = 'report_bug_url'; @@ -484,14 +488,14 @@ suite('gr-main-header tests', () => { report_bug_url: url, }, }; - element._retrieveFeedbackURL(config); - await flush(); + element.retrieveFeedbackURL(config); + await element.updateComplete; - assert.equal(element._feedbackURL, url); + assert.equal(element.feedbackURL, url); assert.ok(query(element, '.feedbackButton > a')); }); - test('register URL', () => { + test('register URL', async () => { assert.isTrue(isHidden(query(element, '.registerDiv'))); const config: ServerInfo = { ...createServerInfo(), @@ -501,19 +505,21 @@ suite('gr-main-header tests', () => { editable_account_fields: [], }, }; - element._retrieveRegisterURL(config); - assert.equal(element._registerURL, config.auth.register_url); - assert.equal(element._registerText, 'Sign up'); + element.retrieveRegisterURL(config); + await element.updateComplete; + assert.equal(element.registerURL, config.auth.register_url); + assert.equal(element.registerText, 'Sign up'); assert.isFalse(isHidden(query(element, '.registerDiv'))); config.auth.register_text = 'Create account'; - element._retrieveRegisterURL(config); - assert.equal(element._registerURL, config.auth.register_url); - assert.equal(element._registerText, config.auth.register_text); + element.retrieveRegisterURL(config); + await element.updateComplete; + assert.equal(element.registerURL, config.auth.register_url); + assert.equal(element.registerText, config.auth.register_text); assert.isFalse(isHidden(query(element, '.registerDiv'))); }); - test('register URL ignored for wrong auth type', () => { + test('register URL ignored for wrong auth type', async () => { const config: ServerInfo = { ...createServerInfo(), auth: { @@ -522,9 +528,10 @@ suite('gr-main-header tests', () => { editable_account_fields: [], }, }; - element._retrieveRegisterURL(config); - assert.equal(element._registerURL, ''); - assert.equal(element._registerText, 'Sign up'); + element.retrieveRegisterURL(config); + await element.updateComplete; + assert.equal(element.registerURL, ''); + assert.equal(element.registerText, 'Sign up'); assert.isTrue(isHidden(query(element, '.registerDiv'))); }); }); |