diff options
Diffstat (limited to 'polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.js')
-rw-r--r-- | polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.js | 32 |
1 files changed, 10 insertions, 22 deletions
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.js b/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.js index 095dc722c0..89ad2d2508 100644 --- a/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.js +++ b/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.js @@ -258,7 +258,9 @@ }, _getDiffPreferences() { - return this.$.restAPI.getDiffPreferences(); + return this.$.restAPI.getDiffPreferences().then(prefs => { + this._prefs = prefs; + }); }, _getPreferences() { @@ -457,7 +459,7 @@ this.modifierPressed(e)) { return; } e.preventDefault(); - this.$.diffPreferences.open(); + this.$.diffPreferencesDialog.open(); }, _handleToggleDiffMode(e) { @@ -608,10 +610,7 @@ const promises = []; - this._localPrefs = this.$.storage.getPreferences(); - promises.push(this._getDiffPreferences().then(prefs => { - this._prefs = prefs; - })); + promises.push(this._getDiffPreferences()); promises.push(this._getPreferences().then(prefs => { this._userPrefs = prefs; @@ -837,22 +836,7 @@ _handlePrefsTap(e) { e.preventDefault(); - this.$.diffPreferences.open(); - }, - - _handlePrefsSave(e) { - e.stopPropagation(); - const el = Polymer.dom(e).rootTarget; - el.disabled = true; - this.$.storage.savePreferences(this._localPrefs); - this._saveDiffPreferences().then(response => { - el.disabled = false; - if (!response.ok) { return response; } - - this.$.prefsOverlay.close(); - }).catch(err => { - el.disabled = false; - }); + this.$.diffPreferencesDialog.open(); }, /** @@ -1036,5 +1020,9 @@ (file === this._path || !this._reviewedFiles.has(file))); this._navToFile(this._path, unreviewedFiles, 1); }, + + _handleReloadingDiffPreference() { + this._getDiffPreferences(); + }, }); })(); |