summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | | | Set version to 3.10.0-SNAPSHOTLuca Milanesio2024-05-065-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Release-Notes: skip Change-Id: I5d43495aaa561c251ddc31975139917bbf28943e
* | | | | | | | | Set version to 3.10.0-rc6v3.10.0-rc6Luca Milanesio2024-05-065-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Release-Notes: skip Change-Id: I84c9b8123d71e3d96d54b55a6a7dfb1997d23d02
* | | | | | | | | Merge branch 'stable-3.9' into stable-3.10Jacek Centkowski2024-05-063-13/+24
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.9: Fix NPE upon Git clone Fix javadocs for deprecation of Changes#id(int) Release-Notes: skip Change-Id: Ib33c0d1c4f884cabba86f7d0d9c2929104d1a5da
| * | | | | | | | Merge branch 'stable-3.8' into stable-3.9Jacek Centkowski2024-05-061-1/+1
| |\| | | | | | | | | |/ / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.8: Fix NPE upon Git clone Release-Notes: skip Change-Id: Ifb06b484473eee96003db850f981a83348d1a85b
| | * | | | | | Fix NPE upon Git cloneLuca Milanesio2024-05-061-1/+1
| | |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Change.getServerid() is flagged as @Nullable and therefore could lead to a NPE when performing a permission check upon Gerrit clone. Bug: Issue 338826950 Release-Notes: Fix NPE during git clone Change-Id: I7d9978ceb8397c9dde5a41fa92af93bce54bf1d9
| * | | | | | Merge "Merge branch 'stable-3.8' into stable-3.9" into stable-3.9Luca Milanesio2024-05-036-16/+15
| |\ \ \ \ \ \
| * \ \ \ \ \ \ Merge "Fix javadocs for deprecation of Changes#id(int)" into stable-3.9Sven Selberg2024-05-032-12/+15
| |\ \ \ \ \ \ \
| | * | | | | | | Fix javadocs for deprecation of Changes#id(int)Sven Selberg2024-05-022-12/+15
| | | |_|_|/ / / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Release-Notes: skip Change-Id: If71cfac6b48e0ed11d3426fa9179a40ac1370ea5
* | | | | | | | Update plugins yarn lock file for @gerritcodereview/typescript-apipaladox2024-05-031-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Release-Notes: skip Change-Id: I7661b819d2b81303b06a21a4de0cb85e7e31ece3
* | | | | | | | Set version to 3.10.0-SNAPSHOTLuca Milanesio2024-05-036-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Release-Notes: skip Change-Id: I40a67f1cb3412d22721679f4afc9e1eb69fde4af
* | | | | | | | Set version to 3.10.0-rc5v3.10.0-rc5Luca Milanesio2024-05-035-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Release-Notes: skip Change-Id: Ic9489389899073552ad0ebcc88fd3b8c15948b0b
* | | | | | | | Update @gerritcodereview/typescript-api to 3.9.1Paladox none2024-05-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: Iee464deb00a49d4325f0f38a4c1f90e2ca37bfe8 Release-Notes: skip
* | | | | | | | Merge branch 'stable-3.9' into stable-3.10Luca Milanesio2024-05-038-21/+20
|\ \ \ \ \ \ \ \ | | |_|/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.9: Update @gerritcodereview/typescript-api to 3.9.1 Update git submodules Update git submodules Index Change: Remove misleading documentation ChangesByProjectCacheImpl: Update Change weigher Remove assignee config from docs gr-main-header: fix header to wrap the better gr-main-header: fix header to wrap the better Document introduction of `virtual_id_number` to `ChangeInfo` Add baseUrl to INITIAL_DATA in IndexHtmlUtil Add baseUrl to INITIAL_DATA in IndexHtmlUtil Fix clearing cache in gr-rest-api Fix clearing cache in gr-rest-api Remove reload-diff-preference unneeded event Remove reload-diff-preference unneeded event ServerPlugin: Fix buggy Optional.orElse() Fix buttons on header disappearing Fix buttons on header disappearing Set version to 3.9.5-SNAPSHOT Set version to 3.9.4 Set version to 3.8.6-SNAPSHOT Set version to 3.8.5 Fix endless loop when using "is:watched" in project watches Release-Notes: skip Change-Id: I1647c9c1273076e13f9cea85db344f9a1fc5ee2e
| * | | | | | | Merge branch 'stable-3.8' into stable-3.9Luca Milanesio2024-05-036-16/+15
| |\ \ \ \ \ \ \ | | |/ / / / / / | |/| | / / / / | | | |/ / / / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.8: Update git submodules Index Change: Remove misleading documentation ChangesByProjectCacheImpl: Update Change weigher Remove assignee config from docs gr-main-header: fix header to wrap the better Document introduction of `virtual_id_number` to `ChangeInfo` Add baseUrl to INITIAL_DATA in IndexHtmlUtil Fix clearing cache in gr-rest-api Remove reload-diff-preference unneeded event Fix buttons on header disappearing Set version to 3.8.6-SNAPSHOT Set version to 3.8.5 Fix endless loop when using "is:watched" in project watches Release-Notes: skip Change-Id: Ie29e2beda2f4052f2d15ea0ff39dd229f74c3288
| | * | | | | Merge branch 'stable-3.7' into stable-3.8Luca Milanesio2024-05-034-6/+11
| | |\ \ \ \ \ | | | | |/ / / | | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.7: Index Change: Remove misleading documentation Document introduction of `virtual_id_number` to `ChangeInfo` Release-Notes: skip Change-Id: I33df959e79da89bba2b0ee7215c17de7cbfbb8c6
| | | * | | | Index Change: Remove misleading documentationRikard Almgren2024-05-021-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It has not been possible for change owners to index their own changes for a while, but the documentation still claims that they can. Bug: Issue 337070245 Release-Notes: Skip Change-Id: I67a973da01b57c5cd779314132c7e586c92f6c9b
| | | * | | | Document introduction of `virtual_id_number` to `ChangeInfo`Jacek Centkowski2024-04-273-4/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Note that the underscore (`_`) has been removed from the variable name to avoid resemblance to the prefix `_` used in `_number`, which (according to the documentation) denotes deprecation. Follow-Up-To: I85c946ef Bug: Issue 325309573 Release-Notes: Add `virtual_id_number` to `ChangeInfo` Forward-Compatible: checked Change-Id: Iddf5dee45f80f863ec8dbc113e15e9499bfee757
| | * | | | | Update git submodulesPaladox none2024-05-021-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Update plugins/codemirror-editor from branch 'stable-3.8' to 6f916580c3f26ecfd9b2a10d96cb1c0530103bc6 - Fix xml mode Change-Id: Ib419a2fadea2eb321559269b8e23ed14c0c20f3b (cherry picked from commit 06719abee6c38d17008599f074050db5153bffa3) - Add missing javascript language support Whoops! Change-Id: I56a493db26eb785769cc0cb3058a566f5fc4c9f6 (cherry picked from commit 469f617ed3102be445615396f3047e7ba498d261)
| | * | | | | ChangesByProjectCacheImpl: Update Change weigherNasser Grainawi2024-04-301-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | assignee is no longer a member of Change, but serverId is. Also, revertOf and cherryPickOf can be null, so only count their weight when non-null. Change-Id: I7343670ccee83ef244a0fa6301980f2913c158e7 Release-Notes: skip
| | * | | | | Remove assignee config from docsNasser Grainawi2024-04-301-7/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was missed in 1fba739a5f317e75383500e06d94ce12091e986d. Change-Id: Ie84657e016bc69aa43b8602f6d9bd5a843c4f93c Release-Notes: Removed missed reference to assignee config in docs
| | * | | | | gr-main-header: fix header to wrap the betterPaladox none2024-04-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | By using `flex: 0 0 auto` it makes sure that the text doesn't get cut off. It's a little less ugly then it wrapping below. This is a better fix than [0]. Correct fix is still a mobile optimised header but that is a seperate change. [0] I9da124be1ecd911cb16803fe709fb23a0860cd9e Release-Notes: gr-main-header: fix header to wrap the better Change-Id: Id7ebb8def48f5f58e31b3e2e297128fbbc8d0443 (cherry picked from commit 14b349c60cb3a90307670c1069e3e82136b785e4)
| | * | | | | Add baseUrl to INITIAL_DATA in IndexHtmlUtilPaladox none2024-04-233-14/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Release-Notes: Add baseUrl to INITIAL_DATA in IndexHtmlUtil Change-Id: I6a74f06eb1bb04365784722704043cac1b79541d (cherry picked from commit b2b9d67de54218a3a45ea8bef3a12b95c602ed77)
| | * | | | | Fix clearing cache in gr-rest-apiPaladox none2024-04-222-21/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We include the base url in urlWithParams so we have to do the same inside gr-rest-api by calling getBaseUrl(). Also clear cache in savePreferences(). Release-Notes: Fix clearing cache in gr-rest-api Bug: 335613081 Change-Id: Ic0fb6af3316c8cd77bcaa64b802cd777cff339d7 (cherry picked from commit 6915b8aa40620176313ec3b55aef90e28a3e6936)
| | * | | | | Remove reload-diff-preference unneeded eventPaladox none2024-04-213-21/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We don't need to trigger this as the model already updates the diffPref config and triggers a refresh. Release-Notes: Remove reload-diff-preference unneeded event Bug: 335613081 Change-Id: I2413cee2169d7347c7354af6131db28411197251 (cherry picked from commit e81286c3421227ea1e2636c9cd97e8fd349130c6)
| | * | | | | Fix buttons on header disappearingPaladox none2024-04-151-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I'm not sure if there's a better fix to this (it's kinda ugly) but it at least prevents the buttons from disappearing. The login button was disappearing when the title was big enough. The correct fix would be to redesign the header to use a nav bar that works on mobile e.g. using a hamburger icon and having a menu that comes out. That's a bigger change. Release-Notes: Fix buttons on header disappearing Change-Id: I9da124be1ecd911cb16803fe709fb23a0860cd9e (cherry picked from commit 9debe8c497697f93abf4fb311789ac7bf4b2369c)
| | * | | | | Set version to 3.8.6-SNAPSHOTLuca Milanesio2024-04-125-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Release-Notes: skip Change-Id: Ie256fb5368cc1a3fcf900ed1c5bfdbb0d63c52bf
| | * | | | | Set version to 3.8.5v3.8.5Luca Milanesio2024-04-125-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Release-Notes: skip Change-Id: Ic8c6c64ac2d3ef994ffd60a9e4b8cfcc09caca66
| | * | | | | Fix endless loop when using "is:watched" in project watchesEdwin Kempin2024-04-124-11/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The "is:watched" predicate matches changes that are being watched. To match changes that are being watched the "is:watched" predicate is expanded to an OR query that has one "project:<watched-project> <project-watch-filter>" predicate per project watch ("project:<watched-project>" is omitted if the project watch is the All-Projects project, "<project-watch-filter>" is omitted if the project watch doesn't set a filter). This expansion happens when the IsWatchedByPredicate is instantiated. Expanding the query requires loading the project watches of the user and parsing the filter (to convert the filter string into Predicates). If the filter of a project watch used the "is:watched" predicate, querying changes by "is:watched" or checking whether a change matches the project watch triggered an endless loop: If "is:watched" is used ChangeQueryBuilder.parse creates an IsWatchedByPredicate instance (in the is(String) method), which is expanded to the OR query (in the IsWatchedByPredicate constructor), which requires parsing the project watch filters. Parsing the project watch filters was done by ChangeQueryBuilder.parse which creates another IsWatchedByPredicate instance (in the is(String) method), which is again expanded to the OR query (in the IsWatchedByPredicate constructor), which again requires parsing the project watch filters, starting the loop anew. To fix this we: 1. Disallow using "is:watched" in ProjectWatch.WatcherChangeQueryBuilder which is a subclass of ChangeQueryBuilder.parse used to check whether a change matches a project watch. 2. Change IsWatchedByPredicate to use ProjectWatch.WatcherChangeQueryBuilder to parse the project watch filters instead of ChangeQueryBuilder. Using ProjectWatch.WatcherChangeQueryBuilder in IsWatchedByPredicate makes the matching logic for project watches when a change is updated consistent with the matching logic for project watches when "is:watched" is used in a regular change query. By disallowing "is:watched" in ProjectWatch.WatcherChangeQueryBuilder project watches that use "is:watched" in their filter do not match any change now. Before this change they triggered an endless loop, affecting the stability of the service. Note, IsWatchedByPredicate did have a check to prevent an endless loop in this case, but it didn't work since the endless loop happened before this check was reached. Bug: Issue 321784734 Release-Notes: Fix endless loop when using "is:watched" in project watches Change-Id: Ie38535b2df123a62dfd6a6e4b4ee60a80b0254f3 Signed-off-by: Edwin Kempin <ekempin@google.com>
| * | | | | | Update @gerritcodereview/typescript-api to 3.9.1Paladox none2024-05-022-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: Iee464deb00a49d4325f0f38a4c1f90e2ca37bfe8 Release-Notes: skip
| * | | | | | Update git submodulesPaladox none2024-05-021-0/+0
| | |_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Update plugins/codemirror-editor from branch 'stable-3.9' to ce9838b8795338877f74c7f3b61c7c4526a279e6 - Fix xml mode Change-Id: Ib419a2fadea2eb321559269b8e23ed14c0c20f3b (cherry picked from commit 06719abee6c38d17008599f074050db5153bffa3) - Add missing javascript language support Whoops! Change-Id: I56a493db26eb785769cc0cb3058a566f5fc4c9f6 (cherry picked from commit 469f617ed3102be445615396f3047e7ba498d261)
| * | | | | gr-main-header: fix header to wrap the betterPaladox none2024-04-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | By using `flex: 0 0 auto` it makes sure that the text doesn't get cut off. It's a little less ugly then it wrapping below. This is a better fix than [0]. Correct fix is still a mobile optimised header but that is a seperate change. [0] I9da124be1ecd911cb16803fe709fb23a0860cd9e Release-Notes: gr-main-header: fix header to wrap the better Change-Id: Id7ebb8def48f5f58e31b3e2e297128fbbc8d0443 (cherry picked from commit 14b349c60cb3a90307670c1069e3e82136b785e4)
| * | | | | Add baseUrl to INITIAL_DATA in IndexHtmlUtilPaladox none2024-04-233-14/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Release-Notes: Add baseUrl to INITIAL_DATA in IndexHtmlUtil Change-Id: I6a74f06eb1bb04365784722704043cac1b79541d (cherry picked from commit b2b9d67de54218a3a45ea8bef3a12b95c602ed77)
| * | | | | Fix clearing cache in gr-rest-apiPaladox none2024-04-222-21/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We include the base url in urlWithParams so we have to do the same inside gr-rest-api by calling getBaseUrl(). Also clear cache in savePreferences(). Release-Notes: Fix clearing cache in gr-rest-api Bug: 335613081 Change-Id: Ic0fb6af3316c8cd77bcaa64b802cd777cff339d7 (cherry picked from commit 6915b8aa40620176313ec3b55aef90e28a3e6936)
| * | | | | Remove reload-diff-preference unneeded eventPaladox none2024-04-213-21/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We don't need to trigger this as the model already updates the diffPref config and triggers a refresh. Release-Notes: Remove reload-diff-preference unneeded event Bug: 335613081 Change-Id: I2413cee2169d7347c7354af6131db28411197251 (cherry picked from commit e81286c3421227ea1e2636c9cd97e8fd349130c6)
| * | | | | ServerPlugin: Fix buggy Optional.orElse()Nasser Grainawi2024-04-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix an issue with creating child injectors using a buggy Optional.orElse() pattern when creating the new root injector for a plugin. This was causing two new injectors to always be created for the ServerPluginInfoModule. This pattern was fixed elsewhere in change Icab4115998f and was fixed in ServerPlugin in the currently reverted change I8633083d97. This splits out the fix from the rest of change I8633083d97 so that it can be tested independently. Change-Id: I2e62662f5801e02bf8c2bc2ae0ca87dbe58b20f2 Release-Notes: Fix Optional.orElse() always causing creation of two injectors for ServerPluginInfoModule
| * | | | | Fix buttons on header disappearingPaladox none2024-04-151-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I'm not sure if there's a better fix to this (it's kinda ugly) but it at least prevents the buttons from disappearing. The login button was disappearing when the title was big enough. The correct fix would be to redesign the header to use a nav bar that works on mobile e.g. using a hamburger icon and having a menu that comes out. That's a bigger change. Release-Notes: Fix buttons on header disappearing Change-Id: I9da124be1ecd911cb16803fe709fb23a0860cd9e (cherry picked from commit 9debe8c497697f93abf4fb311789ac7bf4b2369c)
| * | | | | Set version to 3.9.5-SNAPSHOTLuca Milanesio2024-04-135-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Release-Notes: skip Change-Id: I20c8e19b41babd14a868758d2179e776540b0715
| * | | | | Set version to 3.9.4v3.9.4Luca Milanesio2024-04-135-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Release-Notes: skip Change-Id: I2eecaa0a5a2e919760f19fd2d02a9e211b021ec4
* | | | | | Bazel: Fix eclipse classpath generationDavid Ostrovsky2024-05-031-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since 7.0.0, Bazel uses --remote_download_toplevel by default which means intermediate outputs will not be downloaded during the build. However for Eclipse build to work, the intermediate outputs should also be downloaded. Release-Notes: skip Bug: Issue 324027370 Change-Id: I4c1432f84138544abd2b3fab2586ea2e7b57cb82
* | | | | | Merge "Fix inline editor" into stable-3.10Paladox none2024-05-021-1/+3
|\ \ \ \ \ \
| * | | | | | Fix inline editorPaladox none2024-05-021-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was broken with [0]. We do a similar fix to [1]. We check for if the status is 204 and if it is, we return early which prevents trying to parse the json, which would only throw. [0] I34b9e0cae7a4feeb987763396a145da0c04f8deb [1] I14bb51becb3a44d4bd32b4beadae5a50ec5e67f4 Release-Notes: Fix inline editor Change-Id: Ieddfd2946c80b7f08bcf8c3e9dffd519ff1583df (cherry picked from commit 5f7a43e31ae8ea22a4b6f680e3453bb9fcfea557)
* | | | | | | Update CodeMirror plugin to headPaladox none2024-05-021-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This includes a fix for xml, adds javascript and uses new go/yaml cm packages. Release-Notes: skip Change-Id: I5e358ed1a2ce9376b79c7b9c585faf0400a74021
* | | | | | | Update CodeMirrorpaladox2024-05-022-327/+364
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also add new go and yaml package (migrates from legacy mode). Have to do something similar to I59177f30738d6ceb5b59e2707970d4ee085d1223 otherwise the same problem happens. Release-Notes: Update CodeMirror Change-Id: Ic3990638f96872c72d5acb4bcb7a1a1f163ce085 (cherry picked from commit 633488cce1df32062ec262dd2210f7b2556aaf00)
* | | | | | | Upgrade yarn deps (April 2024)Milutin Kristofic2024-05-028-70/+107
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Similar to change 400697, process is: - rm -rf node_modules/ - yarn upgrade-interactive - update package.json with upgrade-interactive table - yarn install - yarn upgrade-interactive for check No issues were spotted by the tests and build commands Google-Bug-Id: b/283050673 Release-Notes: skip Change-Id: I2d88dbcecf4b2011aa0a1d7304e3fafe88c2daf5 (cherry picked from commit 7644f3e74f24686bc2c15177ee8e67cca6a019be)
* | | | | | Allow influence plugin load order from gerrit.configDariusz Luksza2024-05-014-6/+102
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In some complex deployments of Gerrit, the order of plugins' load during the startup time matters. Currently, the only way to influence it is to rename plugin JAR file in the `plugins/` directory. Which is a bit inconvenient and possibly error-prone. With this change, it's now possible to use `plugins.loadPriority` option of `gerrit.config` to influence the order of loading plugins during the startup. The `plugins.loadPriority` is a list configuration option, that accepts plugin names (as discovered by Gerrit from the `MANIFEST.MF` value of `Gerrit-PluginName` or plugin JAR file in `plugins/` directory). The earlier the plugin is defined in `gerrit.config` the sooner (or higher priority) it will have. Bug: Issue 335744331 Release-Notes: Change plugin load order using `plugins.loadPriority` Change-Id: Ie2e646ff8cdea8529f79084055ae2401d22e111c
* | | | | | Extract plugin load order comparator into separate classDariusz Luksza2024-05-013-40/+178
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To ensure proper plugin load order Gerrit used a private implementation of `java.util.Comparator` interface. The responsibility of that implementation is to ensure that: * plugins with `Gerrit-ApiModule` entry in `Manifest.mf` are first, * all other plugins are sorted in the natural order. As this is a crucial part of plugin loading and may be extended later (eg. by including load priority in `Manifest.mf`) it will be good to have at least basic testing for the current logic. This change is extracting this `Comparator` code into a standalone class and adding test coverage for it. Release-Notes: skip Change-Id: I5587d40bc53ffd47049dbccda550dfa9748677ef
* | | | | | Merge "WorkQueue: Refactor to call get() directly on Extension" into stable-3.10Nasser Grainawi2024-04-291-2/+2
|\ \ \ \ \ \
| * | | | | | WorkQueue: Refactor to call get() directly on ExtensionKaushik Lingarkar2024-04-261-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Release-Notes: skip Change-Id: I7c92cdfd6b2229522990ea4c59cf206f2920f6d5
* | | | | | | gr-main-header: fix header to wrap the betterPaladox none2024-04-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | By using `flex: 0 0 auto` it makes sure that the text doesn't get cut off. It's a little less ugly then it wrapping below. This is a better fix than [0]. Correct fix is still a mobile optimised header but that is a seperate change. [0] I9da124be1ecd911cb16803fe709fb23a0860cd9e Release-Notes: gr-main-header: fix header to wrap the better Change-Id: Id7ebb8def48f5f58e31b3e2e297128fbbc8d0443 (cherry picked from commit 14b349c60cb3a90307670c1069e3e82136b785e4)
* | | | | | | Drop support for Java 11Luca Milanesio2024-04-295-34/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Java 11 is EOL since September 2023 (see [1]) and Gerrit has been supporting Java 17 for many releases. Drop the support for building Gerrit using Java 11 and make Java 17 the default minimal supported version. Also set the IntelliJ language level to 17. [1] https://www.oracle.com/uk/java/technologies/java-se-support-roadmap.html Release-Notes: Drop support for Java 11 Change-Id: Id8bf939477d1bca74ee160b485d587d32a3f0eb8
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-08 10:52:11 +0000