summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Set version to 3.10.1-SNAPSHOTupstream/stable-3.10Luca Milanesio4 hours5-5/+5
| | | | | Release-Notes: skip Change-Id: Ie3642ce8b09243b62381bbbab20834f6bc246a48
* Set version to 3.10.0v3.10.0Luca Milanesio4 hours5-5/+5
| | | | | Release-Notes: skip Change-Id: Icf7e4ae94512e4656e1517432dd12cbd619ecdd9
* Merge branch 'stable-3.9' into stable-3.10Nasser Grainawi18 hours5-26/+28
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.9: Set version to 3.9.6-SNAPSHOT Set version to 3.9.5 WorkQueue: Improve task thread names Set version to 3.8-SNAPSHOT Set version to 3.8.6 Set version to 3.7.10-SNAPSHOT Set version to 3.7.9 Fix issues with account details filling Update Getting Started to Gerrit 3.8.5 Update Getting Started to Gerrit 3.9.4 Update Getting Started to Gerrit 3.7.8 Mention who owns the change in comment emails Change-Id: Ib003e049ca47c51522ee753cc42b9968963dcfee Release-Notes: skip
| * Merge "Merge branch 'stable-3.8' into stable-3.9" into stable-3.9upstream/stable-3.9Nasser Grainawi18 hours1-1/+1
| |\
| | * Merge branch 'stable-3.8' into stable-3.9Nasser Grainawi19 hours1-1/+1
| | |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.8: WorkQueue: Improve task thread names Change-Id: Ie2bdda689ff5bdfd24e243d9cf0783c9ed31b65a Release-Notes: skip
| | | * WorkQueue: Improve task thread namesupstream/stable-3.8Nasser Grainawi20 hours1-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The RunnableScheduledFuture task inside a Task has a few layers that don't help provide a meaningful thread name whereas the Task itself often has a toString() that does, so use the Task itself. Here's an example for a SendEmail thread. It's a similar result for Index-Interactive and other threads. Before (line breaks added by me): SendEmail-1[ java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask@57310449[ Not completed, task = java.util.concurrent.Executors$RunnableAdapter@3a7a2870[ Wrapped task = com.google.gerrit.server.logging.LoggingContextAwareRunnable@9252ca5 ] ] ] After: SendEmail-1[send-email comments] Change-Id: Iea78b6412b2259a968eed0a16744638f87796d91 Release-Notes: Improved WorkQueue task thread names (cherry picked from commit d4c1e0a6ed7eb2b8fffa078a7ccec0c0edb0e668)
| * | | Set version to 3.9.6-SNAPSHOTLuca Milanesio20 hours5-5/+5
| |/ / | | | | | | | | | | | | Release-Notes: skip Change-Id: Ieea2878b8e6702e25b414bb3c6d92aaebfbf4bcf
| * | Set version to 3.9.5Luca Milanesio20 hours5-5/+5
| | | | | | | | | | | | | | | Release-Notes: skip Change-Id: Ib268a4d2322bdf79c46ef0e018bffbd1aa46f244
| * | Merge branch 'stable-3.8' into stable-3.9Luca Milanesio24 hours0-0/+0
| |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.8: Set version to 3.8-SNAPSHOT Set version to 3.8.6 Set version to 3.7.10-SNAPSHOT Set version to 3.7.9 Update Getting Started to Gerrit 3.8.5 Update Getting Started to Gerrit 3.7.8 Release-Notes: skip Change-Id: Iaf50aa61cdae4c0cabeea56c7ea18fa69ed9d6ee
| | * Set version to 3.8-SNAPSHOTLuca Milanesio29 hours5-5/+5
| | | | | | | | | | | | | | | Release-Notes: skip Change-Id: I8f607aa6d7512bc6933662ed022b92f3cd5993c7
| | * Set version to 3.8.6v3.8.6Luca Milanesio30 hours5-5/+5
| | | | | | | | | | | | | | | Release-Notes: skip Change-Id: Iad3a38e786767a5ae1b0543f25eb40a424b899c2
| | * Merge branch 'stable-3.7' into stable-3.8Daniele Sassoli30 hours0-0/+0
| | |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.7: Set version to 3.7.10-SNAPSHOT Set version to 3.7.9 Update Getting Started to Gerrit 3.7.8 Release-Notes: skip Change-Id: Ice602304fe9c3703a735b6f1adc4e4923868304e
| | | * Set version to 3.7.10-SNAPSHOTupstream/stable-3.7Luca Milanesio2 days5-5/+5
| | | | | | | | | | | | | | | | | | | | Release-Notes: skip Change-Id: Ic99c0d13a99f9577f0762e3c8bd41ca2b798f744
| | | * Set version to 3.7.9v3.7.9Luca Milanesio2 days5-5/+5
| | | | | | | | | | | | | | | | | | | | Release-Notes: skip Change-Id: Id6feef84ad0578f2a09c0b97591d8be768293507
| | | * Merge "Update Getting Started to Gerrit 3.7.8" into stable-3.7Nasser Grainawi3 days1-2/+2
| | | |\
| | | | * Update Getting Started to Gerrit 3.7.8Daniele Sassoli3 days1-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: Id9ec22f0688adf290b27f32ffb71d63df3f6a763 Release-Notes: skip
| | * | | Update Getting Started to Gerrit 3.8.5Daniele Sassoli3 days1-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: Ie4bc10a1e760202296ff98007586eb9ea358918f Release-Notes: skip
| | * | | Merge "Merge branch 'stable-3.7' into stable-3.8" into stable-3.8Luca Milanesio4 days4-24/+26
| | |\ \ \
| * | | | | Fix issues with account details fillingBen Rohlfs2 days5-8/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Users have reported an issue with bogus account labels when the account label was trying to fill in the details. One issue was that the account (even the detailed one) does not have an `email` property set. So the underlying `isDetailedAccount()` utility was producing false return values and initiated the account to be looked up again and again. Another issue was that `Object.assign()` would actually modify the cached object in place and thus potentially mess up the account object for all subsequent callers. Release-Notes: Fix bogus account labels. Change-Id: Ib91fe57ad8026ef2a1daf61ddc2af5954ffd39ab (cherry picked from commit ac98b4d387004032658eb0a3e9e4152d82e32a8c)
| * | | | | Merge "Update Getting Started to Gerrit 3.9.4" into stable-3.9Nasser Grainawi3 days1-2/+2
| |\ \ \ \ \
| | * | | | | Update Getting Started to Gerrit 3.9.4Daniele Sassoli3 days1-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: Ibcf6a741eaf465fcfc8c004167d268fe360a3e54 Release-Notes: skip
| * | | | | | Merge branch 'stable-3.8' into stable-3.9Luca Milanesio4 days4-24/+26
| |\ \ \ \ \ \ | | | |_|/ / / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.8: Mention who owns the change in comment emails Release-Notes: skip Change-Id: I1e273ec0cf2314882bc3f4cb079456c1b307bd18
| | * | | | | Merge branch 'stable-3.7' into stable-3.8Luca Milanesio4 days4-24/+26
| | |\ \ \ \ \ | | | | |_|/ / | | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.7: Mention who owns the change in comment emails Release-Notes: skip Change-Id: I29535eb95eb23576567f06337c3657a25856418e
| | | * | | | Mention who owns the change in comment emailsAntoine Musso4 days4-24/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When receiving the email, knowing the change owner lets the receiver knows it is one of their change and might refine reviewing priority for some people. We had that customization for a few years now, and I felt like it can be upstreamed (ref: https://phabricator.wikimedia.org/T43608 ). Release-Notes: Emails notifications for comments now mentions who owns the change. Change-Id: If676e4f1b75bdbe2d39dcfe1fbe841520e81068f
* | | | | | | H2Cache: Set a name for disk cache pruning tasksNasser Grainawi46 hours2-2/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of an unintelligible thread name like: com.google.gerrit.server.cache.h2.H2CacheFactory$$Lambda$919/0x00007f6217af2040@17adeb0 use a name that indicates "Disk Cache Pruning" and the specific cache being pruned, like: Disk Cache Pruner (persisted_projects) Change-Id: I339b1ec5ba8563648265cd736f795953d757ca79 Release-Notes: Fixed unintelligible disk cache pruning thread/task names
* | | | | | | Fix issues with account details fillingBen Rohlfs2 days5-10/+57
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Users have reported an issue with bogus account labels when the account label was trying to fill in the details. One issue was that the account (even the detailed one) does not have an `email` property set. So the underlying `isDetailedAccount()` utility was producing false return values and initiated the account to be looked up again and again. Another issue was that `Object.assign()` would actually modify the cached object in place and thus potentially mess up the account object for all subsequent callers. Release-Notes: Fix bogus account labels. Change-Id: Ib91fe57ad8026ef2a1daf61ddc2af5954ffd39ab (cherry picked from commit ac98b4d387004032658eb0a3e9e4152d82e32a8c)
* | | | | | | Merge branch 'stable-3.9' into stable-3.10paladox4 days0-0/+0
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.9: Fix javadocs for deprecation of Changes#id(int) Release-Notes: skip Change-Id: I25c7d64ee3ec61e93c1567c78c6fb15015b50586
* \ \ \ \ \ \ \ Merge branch 'stable-3.9' into stable-3.10Nasser Grainawi7 days2-5/+12
|\ \ \ \ \ \ \ \ | | |/ / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.9: Fix vertical alignment of header icon and text Change-Id: Iebfb1e15155283599523dc7bd2f6e5bffd4d730e Release-Notes: skip
| * | | | | | | Merge branch 'stable-3.8' into stable-3.9Nasser Grainawi7 days2-5/+12
| |\ \ \ \ \ \ \ | | | |_|_|_|/ / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.8: Fix vertical alignment of header icon and text Change-Id: I3768226fba9b3ced95bf83c57a033f7c596ed0fb Release-Notes: skip
| | * | | | | | Fix vertical alignment of header icon and textBen Rohlfs7 days2-5/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There is generally a slight misalignment of icon and text as can be seen in this screenshot: https://imgur.com/a/tDUHGk0 It was also noted in the referenced bug that increasing the icon height is impossible, because then the alignment gets totally messed up. 3 problems contribute to this misalignment: 1. `.titleText` element being a span. This generally makes alignment of icons next to text very tricky. Let's use a flex element instead. 2. `vertical-align: text-bottom` for the icon is a very unusual choice for the vertical-align property and does not really make a lot of sense. Let's just use the `align-items: center` style for flex elements, see above. 3. `.bigTitle` has a custom font size, but not a custom line-height. That is generally problematic as can be seen here: The element will get a height of 20px as an inline element, but contains text with a 24.5px font. No surprise that we see misalignment. Let's make sure that the line-height and thus the height of the text element has a proper value. 1.2*font-size is what browsers would normally use. This was checked to behave well on gerrit-review, android-review and chromium-review. Release-Notes: skip Bug: Issue 337076005 Change-Id: Ia09bbe92158f7b4b1d6b88e599e0635fa9b15d5e (cherry picked from commit 06cfcb6ef54d78d7e68dfc0f17a15d30d6aae414)
* | | | | | | | Set version to 3.10.0-SNAPSHOTLuca Milanesio7 days5-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Release-Notes: skip Change-Id: I6f1bd2751d75c8cab8859789c1c1e75026727529
* | | | | | | | Set version to 3.10.0-rc7v3.10.0-rc7Luca Milanesio7 days5-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Release-Notes: skip Change-Id: I8d3b6985f3b2cc2ecc5067c21d910f26670e90a0
* | | | | | | | Merge branch 'stable-3.9' into stable-3.10Nasser Grainawi9 days2-5/+13
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.9: ChangesByProjectCacheImpl: Fix PATCH_SET_ID typo ChangesByProjectCacheImpl: Remove unused import ChangesByProjectCacheImpl: Fix typo with originalSubject Change: Consistently apply @Nullable Change-Id: Ia3e80a0a5f2177aaa940e0b0e7933abe2340708d Release-Notes: skip
| * | | | | | | Merge branch 'stable-3.8' into stable-3.9Nasser Grainawi10 days2-6/+13
| |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.8: ChangesByProjectCacheImpl: Fix PATCH_SET_ID typo ChangesByProjectCacheImpl: Remove unused import ChangesByProjectCacheImpl: Fix typo with originalSubject Change: Consistently apply @Nullable Change-Id: Ie02629188776259e2d93699861a363e7d401a8ba Release-Notes: skip
| | * | | | | | ChangesByProjectCacheImpl: Fix PATCH_SET_ID typoNasser Grainawi10 days1-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The variable was spelled PACTCH_SET_ID by accident. Change-Id: I96696ffaed79281611173e158ad5bec7a5e475e1 Release-Notes: skip
| | * | | | | | ChangesByProjectCacheImpl: Remove unused importNasser Grainawi10 days1-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Not sure why this wasn't caught by gjf earlier. Change-Id: I9b1306f51e6218364e8ae9f43274e12b520d4797 Release-Notes: skip
| | * | | | | | ChangesByProjectCacheImpl: Fix typo with originalSubjectNasser Grainawi10 days1-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was supposed to be using the length of the originalSubject when it was different from the subject, but a likely copy/paste error had it using the length of the subject again. Change-Id: I4dd18dfb9662e76b8e9fc85c29fdc022b6d58af3 Release-Notes: skip
| | * | | | | | Change: Consistently apply @NullableNasser Grainawi10 days1-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This annotation was not applied consistently to fields and methods, with some fields having it and their respective getters missing it and vice versa. Also fix the one instance where it was applied but formatted differently than in the rest of the code base. Change-Id: Ie4436fe64642affad7d775c59b10b6bacc0c4acd Release-Notes: skip Forward-Compatible: checked
* | | | | | | | Set version to 3.10.0-SNAPSHOTLuca Milanesio11 days5-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Release-Notes: skip Change-Id: I5d43495aaa561c251ddc31975139917bbf28943e
* | | | | | | | Set version to 3.10.0-rc6v3.10.0-rc6Luca Milanesio11 days5-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Release-Notes: skip Change-Id: I84c9b8123d71e3d96d54b55a6a7dfb1997d23d02
* | | | | | | | Merge branch 'stable-3.9' into stable-3.10Jacek Centkowski11 days3-13/+24
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.9: Fix NPE upon Git clone Fix javadocs for deprecation of Changes#id(int) Release-Notes: skip Change-Id: Ib33c0d1c4f884cabba86f7d0d9c2929104d1a5da
| * | | | | | | Merge branch 'stable-3.8' into stable-3.9Jacek Centkowski11 days1-1/+1
| |\| | | | | | | | |/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * stable-3.8: Fix NPE upon Git clone Release-Notes: skip Change-Id: Ifb06b484473eee96003db850f981a83348d1a85b
| | * | | | | Fix NPE upon Git cloneLuca Milanesio11 days1-1/+1
| | |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Change.getServerid() is flagged as @Nullable and therefore could lead to a NPE when performing a permission check upon Gerrit clone. Bug: Issue 338826950 Release-Notes: Fix NPE during git clone Change-Id: I7d9978ceb8397c9dde5a41fa92af93bce54bf1d9
| * | | | | Merge "Merge branch 'stable-3.8' into stable-3.9" into stable-3.9Luca Milanesio2024-05-036-16/+15
| |\ \ \ \ \
| * \ \ \ \ \ Merge "Fix javadocs for deprecation of Changes#id(int)" into stable-3.9Sven Selberg2024-05-032-12/+15
| |\ \ \ \ \ \
| | * | | | | | Fix javadocs for deprecation of Changes#id(int)Sven Selberg2024-05-022-12/+15
| | | |_|_|/ / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | Release-Notes: skip Change-Id: If71cfac6b48e0ed11d3426fa9179a40ac1370ea5
* | | | | | | Update plugins yarn lock file for @gerritcodereview/typescript-apipaladox14 days1-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Release-Notes: skip Change-Id: I7661b819d2b81303b06a21a4de0cb85e7e31ece3
* | | | | | | Set version to 3.10.0-SNAPSHOTLuca Milanesio2024-05-036-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Release-Notes: skip Change-Id: I40a67f1cb3412d22721679f4afc9e1eb69fde4af
* | | | | | | Set version to 3.10.0-rc5v3.10.0-rc5Luca Milanesio2024-05-035-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Release-Notes: skip Change-Id: Ic9489389899073552ad0ebcc88fd3b8c15948b0b
* | | | | | | Update @gerritcodereview/typescript-api to 3.9.1Paladox none2024-05-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: Iee464deb00a49d4325f0f38a4c1f90e2ca37bfe8 Release-Notes: skip
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-17 16:30:13 +0000