| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
| |
Change-Id: I402591be6be2522dfc750a38c19659efa9ab773d
|
| |
|
|
| |
Change-Id: I73ea2f271082cf74d70e3d590398f5378bc899c6
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Change-Id: Iffcd0fbd7 has involuntarily triggered the
creation of a new HTTP Session for every invocation a Git-over-HTTP
request.
All came from the mistake of tracing the HTTP session instead
of the Gerrit session in the audit record.
The HTTP Servlet API specs say that any attempt to access
the current session of an incoming request would result
in the creation of a brand-new session.
The session involuntarily created also had an expiry time
equal to zero, which prevented the session housekeeper
to reclaim them later on, even though they were unused.
The consequence of creating an empty session for every
Git-over-HTTP request isn't immediately tangible, because
the session is empty and doesn't occupy a significant
amount of memory. However, longer-term, the in-memory
hashtable that records all the sessions, each one using
750 bytes on average, will be causing the overload
of the JVM heap and the crash of the process because of
lack of available memory.
Use the correct Gerrit session-id, retrieving
from the Provider<WebSession> the proper session, if active
and logged in, and make sure in tests that no HTTP sessions
are created as a result of a Git-over-http request.
Bug: Issue 13858
Change-Id: I8c086fed54b196c3f46fa88ac78c127784524d30
|
| |\
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* stable-3.2:
Update git submodules
Update git submodules
AccountResolver: limit number of ambiguous accounts in error message
Update highlightjs to 10.5.0
Change-Id: Ic4f3ba0a8699a2d239956f212ad7400064f43efa
|
| | |\
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* stable-3.1:
Update git submodules
AccountResolver: limit number of ambiguous accounts in error message
Update highlightjs to 10.5.0
Change-Id: Ib49b3bb95a606db0d0418d9d2e467aadba330768
|
| | | |\ |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This upgrades currently used version 10.0.2 from May 2020.
Build process is amended to use terser minification, as it provides
better result as closure-compiler: [1]
Terser (5.3.8):
$ ls -all build/highlight.min.js
-rw-r--r-- 1 davido users 977775 Jan 10 10:04 build/highlight.min.js
Closure-Compiler (v20210106):
$ ls -all build/highlight.min.js
-rw-r--r-- 1 davido users 994034 Jan 9 12:10 build/highlight.min.js
So, terser produces minified build that is 16259 bytes smaller.
Moreover, in latest gerrit releases terser is also used for gr-app.js
minification, so it appears to be consistent to also use terser for
highlight.js minification.
[1] https://github.com/highlightjs/highlight.js/issues/2956
Change-Id: I3a67dc05eb9c4fdac1bf578eacd777dfefb2a360
|
| | | |\ \
| | | | |
| | | | |
| | | | | |
into stable-3.1
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Don't list more than 3 ambiguous accounts in error message of
UnresolvableAccountException in order to prevent flooding the log and
displaying a lot of sensitive account data in an error dialog.
Bug: Issue 13803
Change-Id: I95fe697988f3d900cce29ca93114a725b1c17ca6
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* Update plugins/replication from branch 'stable-3.1'
to 141f223240b15d3576f2d45525ed12b6ce7bc9bf
- Document that authGroup must have Access Database
Bug: Issue 13786
Change-Id: Iaf65252b25b9c40e5cfd1ac25d55fbf70536f83e
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* Update plugins/replication from branch 'stable-3.2'
to dedf422a7a0336096c5503d1f652f77873fbf11c
- Merge branch 'stable-3.1' into stable-3.2
* stable-3.1:
Document that authGroup must have Access Database
Change-Id: I09378f4288fd1335932bdf120bba8418fc8f51c7
- Document that authGroup must have Access Database
Bug: Issue 13786
Change-Id: Iaf65252b25b9c40e5cfd1ac25d55fbf70536f83e
|
| |\ \ \ \ \ |
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Bug: Issue 13929
Change-Id: I9ff32013f4fe243524f81f7dd93ef3ccbb8754bd
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* Update plugins/replication from branch 'stable-3.3'
to 975cb0edd7d994ebd3b86b27308f1e37cd7eb985
- Merge branch 'stable-3.2' into stable-3.3
* stable-3.2:
Document that authGroup must have Access Database
Change-Id: I6d7292dd7e604edbf4e2fd6b3c1615f43c1d1df4
- Merge branch 'stable-3.1' into stable-3.2
* stable-3.1:
Document that authGroup must have Access Database
Change-Id: I09378f4288fd1335932bdf120bba8418fc8f51c7
- Document that authGroup must have Access Database
Bug: Issue 13786
Change-Id: Iaf65252b25b9c40e5cfd1ac25d55fbf70536f83e
|
| |\ \ \ \ \ \
| |/ / / / /
|/| / / / /
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* stable-3.2:
Add shadow-selection-polyfill
Update jetty version to 9.4.35.v20201120
Add shadow-selection-polyfill
AliasConfig: Pass recursive=true into getNames() JGit methods
Update git submodules
Update git submodules
Revert "Upgrade soy to 2020-08-24"
Also disable tslint ban-ts-ignore rule because shadow-selection-polyfill
currently doesn't expose Typescript types.
Change-Id: I9e7ec8b0cf641d3133d49a33a8f13fc2855b50ac
|
| | |\| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* stable-3.1:
Update jetty version to 9.4.35.v20201120
Change-Id: I97edf8fb6c5f97df93aff2ef62b710cd08c780ef
|
| | | |/ /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Includes a fix for CVE-2020-27218 [1] that affects versions prior
to 9.4.35.v20201120.
As of: [2] new dependency was added to jetty-servlet: jetty-util-ajax.
[1] https://nvd.nist.gov/vuln/detail/CVE-2020-27218
[2] https://github.com/eclipse/jetty.project/issues/5539
Change-Id: I51549c9588f5748f36e145f8c4b347f97c08b4d8
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This is a backport of change 293242 to stable-3.2 branch and to
consume shadow-selection-polyfill module with npm.
Bug: Issue 11811
Change-Id: Iaf62137e48b7d119be3d8be96ad03a7f316a5e69
|
| | |\| |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The change:
96ccc2388 Add shadow-selection-polyfill
is reverted, as it will be migrated so that shadow-selection-polyfill
dependency is consumed as npm module.
* stable-3.1:
Add shadow-selection-polyfill
Update git submodules
Revert "Upgrade soy to 2020-08-24"
Change-Id: I0a863e9de9f35d4a9a77302e2a05d9850a2b3538
|
| | | |/
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The selection on shadow-DOM is not implemented
in Safari and the document.getSelection() fallback
is not suitable for use.
The GoogleChromeLabs provided a library to solve
the problem: shadow-selection-polyfill.
What the library does is to manage the selection
change events and calculate and cache the results
for the shadow root elements, creating a custom
event '-shadow-selectionchange' once the selection
has been completed.
There is one gotcha that makes things slightly
more complicated: what the library provides is a Range
and not a Selection object. There are a couple of
adjustments needed in gr-diff and gr-diff-highlight
to use the range directly instead of getting it
from the selection.
NOTE: Even though the shadow-selection-polyfill could
also manage Chrome and Firefox, keep the existing
logic to avoid any possible regression, which is not
desireable on a stable branch.
On stable-3.1, because of the problems related to the inclusion
of the dependency via Bower, shadow.js has been removed
from its exports and used as pure JS file included in the
gr-diff.html.
This change needs would not be applied to stable-3.2 where,
thanks to the npm package mangement, it would be consumed
from the NPM registry directly.
Bug: Issue 11811
Change-Id: I41c4e94343010972c8a9f0f1ba3a059ca7af5292
|
| | | |\ |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This reverts commit bcdbc45e85efe98ea820f5024c5ca566ba0576d5.
Han-Wen reported this soy version to show performance issues in Gerrit:
"Google is tracking this internally as b/176094888; hopefully we can get
it fixed in Soy proper.
The problem is that template rendering went from 9ms to 30ms. We render
quite a few templates for a single email, so adds ~120ms to each
operation that sends out an email.
It looks like this caused a significant slowdown on the benchmark under
contrib/benchmark-createchange.go (using reftable as refstorage)."
Hence reverting this update until it's fixed upstream.
See https://gerrit-review.googlesource.com/c/gerrit/+/280196
Change-Id: Id98a5d93e316268e086cf6aa2be514a586dd3eee
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* Update plugins/replication from branch 'stable-3.1'
to 22ca0b406a4efb9aebbbfcac8d2d986812423f01
- Split integration tests to different targets
Running all integration tests as part of one single 'replication_it'
target does not cope well with the addition of extra tests, because it
is bound to take longer and longer, eventually hitting any test timeout
threshold.
Splitting integration tests into different targets avoids timeout
failures and also provides additional benefits, such as:
- Better understanding of test failures
- More efficient utilization of bazel build outputs and remote caching,
effectively making tests execution faster.
Bug: Issue 13909
Change-Id: Ifc6cce9996d3a8a23ec2a66c377978205fb6680f
|
| | |\ \ \
| | | | |
| | | | |
| | | | | |
stable-3.2
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This change solves the operator/operand aliasing not finding content in
gerrit.config (it would only be found in secure.config).
Change-Id: I10b96225526dc355e668357715f5e60a9d3d9751
|
| | |\ \ \ \
| | |/ / /
| |/| | | |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* Update plugins/replication from branch 'stable-3.2'
to 99c822ebf3b72023f8b926444bbdf299fafb00df
- Merge branch 'stable-3.1' into stable-3.2
* stable-3.1:
Split integration tests to different targets
Don't check read permission when authgroup isn't set
Change-Id: Ic5c8f0468869476a01923b4d374f0188c271daf2
- Split integration tests to different targets
Running all integration tests as part of one single 'replication_it'
target does not cope well with the addition of extra tests, because it
is bound to take longer and longer, eventually hitting any test timeout
threshold.
Splitting integration tests into different targets avoids timeout
failures and also provides additional benefits, such as:
- Better understanding of test failures
- More efficient utilization of bazel build outputs and remote caching,
effectively making tests execution faster.
Bug: Issue 13909
Change-Id: Ifc6cce9996d3a8a23ec2a66c377978205fb6680f
- Don't check read permission when authgroup isn't set
It's unnecessary to check read permission when authGroup isn't set since
the then the user is a RemoteSiteUser that is-an InternalUser that has
read access to everything.
Change-Id: Ie6985250b0acb50c08fdcae75cc608222b1add35
|
| |\ \ \ \ \ |
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Bug: Issue 13760
Change-Id: Ic11c605d66add6d777115ae12300001148f8d148
|
| |\ \ \ \ \ \ |
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Now that the 3.3 release is out, let's not talk about that as an
"upcoming thing" anymore.
Change-Id: I3912c701ec06ffc5d27e5d1814a05dbb8a88a7b4
|
| |\ \ \ \ \ \ \
| |_|/ / / / /
|/| | | | | | |
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Revert "Adjust to changes in Gerrit core"
Revert submission 283559-currentuser-remove-cache-key
Reason for revert: Causes a latency regression for some hosts
Reverted Changes:
I76bfd3ebc:Adjust to changes in Gerrit core
If7ccfd9a4:Remove unused CurrentUser#cacheKey method
I1378ad083:Remove PerThreadCache
Change-Id: I2bfe41d8acc4b325bb59b3ae099661300d84454e
|
| |\ \ \ \ \ \ \ |
|
| | |\ \ \ \ \ \ \
| | | |_|_|/ / /
| | |/| | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
* stable-3.2:
Add script for incremental reindexing during upgrade
Add query option allowing administrators to skip visibility filtering
Change-Id: Iaaca54cd3ca811a7a45861c21ad4ef1f45753446
|
| | | |\ \ \ \ \ \
| | | |_|_|/ / /
| | |/| | | / /
| | | | |_|/ /
| | | |/| | |
| | | | | | |
| | | | | | |
| | | | | | | |
* stable-3.1:
Add script for incremental reindexing during upgrade
Add query option allowing administrators to skip visibility filtering
Change-Id: Iade61ce701a6efcbdcc12bf2a0dda6a9af32419e
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
In order to shorten the downtime needed to reindex changes during a
Gerrit upgrade the following strategy can be used:
- index preparation
- create a full consistent backup
- note down the timestamp when the backup was created (backup-time)
- create a complete copy of the production system from the backup
- upgrade this copy to the new Gerrit version
- online reindex this copy
- upgrade of the production system
- make system unavailable so that users can't reach it anymore
e.g. by changing port numbers (downtime starts)
- take a full backup
- run
$ ./reindex.py -u gerrit-url -s backup-time
to write the list of changes which have been created or modified
since the backup for the index preparation was created to a file
"changes-to-reindex.list"
- upgrade the production system to the new gerrit version skipping
reindexing
- copy the bulk of the new index from the copy system to the
production system
- run
$ ./reindex.py -u gerrit-url
this reindexes all changes which have been created or modified after
the backup was taken reading these changes from the file
"changes-to-reindex.list"
- smoketest the system
- make the production system available to the users again
(downtime ends)
Change-Id: Ie736e0dc32180329ca6ed31bcb49eb6b96bf2b91
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
If an administrator wants to reindex changes which were created or
updated in a given period based on a query for that period the
query results are subject to visibility filtering. This can have the
effect that e.g. private changes are missed.
Add a query option "skip-visibility" to allow administrators
to skip visibility filtering.
Change-Id: I66c13659587b9459eb7cc585697c1655926ceac3
|
| | |_|_|/ / /
|/| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* Update plugins/replication from branch 'stable-3.3'
to 011c577ef4ee2149d73db974e0ef2fcd3f66bfcf
- Merge branch 'stable-3.2' into stable-3.3
* stable-3.2:
Split integration tests to different targets
Don't check read permission when authgroup isn't set
Change-Id: I4a1e1be5c4323de1554091786c55ca9a84d391e5
- Merge branch 'stable-3.1' into stable-3.2
* stable-3.1:
Split integration tests to different targets
Don't check read permission when authgroup isn't set
Change-Id: Ic5c8f0468869476a01923b4d374f0188c271daf2
- Split integration tests to different targets
Running all integration tests as part of one single 'replication_it'
target does not cope well with the addition of extra tests, because it
is bound to take longer and longer, eventually hitting any test timeout
threshold.
Splitting integration tests into different targets avoids timeout
failures and also provides additional benefits, such as:
- Better understanding of test failures
- More efficient utilization of bazel build outputs and remote caching,
effectively making tests execution faster.
Bug: Issue 13909
Change-Id: Ifc6cce9996d3a8a23ec2a66c377978205fb6680f
- Don't check read permission when authgroup isn't set
It's unnecessary to check read permission when authGroup isn't set since
the then the user is a RemoteSiteUser that is-an InternalUser that has
read access to everything.
Change-Id: Ie6985250b0acb50c08fdcae75cc608222b1add35
|
| |/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Revert "Adjust to changes in Gerrit core"
Revert submission 283559-currentuser-remove-cache-key
Reason for revert: Causes a latency regression for some hosts
Reverted Changes:
I76bfd3ebc:Adjust to changes in Gerrit core
If7ccfd9a4:Remove unused CurrentUser#cacheKey method
I1378ad083:Remove PerThreadCache
Change-Id: Idd9eb9cb91bb531ee75aa2c2cde26a01ceb5ff0a
|
| |\| | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* stable-3.2:
Polygerrit: Wipe out license headers in minified gr-app.js
Fix 'is:submittable' query on multiple submit records
Fix 'is:submittable' query on multiple submit records
Update git submodules
Change-Id: I65c064e4d526a2cc466b7337207b6b8695728b0c
|
| | |\| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* stable-3.1:
Fix 'is:submittable' query on multiple submit records
Update git submodules
NOTE: No-op merge, the only commit needed was already cherry-picked
onto stable-3.1 and the replication plugin should stay on its
own stable-3.2 branch point.
Change-Id: I18813f4cbb79ed900eeecef54a4cc676c6fba13b
|
| | | | |/
| | |/|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
When a project has multiple submit rules, which produce
multiple submit records, the 'is:submittable' query stops
working as the documentation indicates it should. Rather
than returning changes that are ready to be submitted,
it returns any change where at least one submit record
is OK, despite the overall change not being submittable.
For example, with the code-owners plugin, which uses
a java-based submit rule, 'is:submittable' will return
changes that are passing owners checks, but might
have CodeReview:-2 or Verified:-1.
For projects with a single submit rule, the behavior
is exactly the same as before, since we simply check
that *any* of the submit records is OK, exactly as before,
AND that *none* of them are NOT_READY or RULE_ERROR.
Bug: Issue 13884
Change-Id: I4878ce13c6673852916d6891253d5e62b46f3db5
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* Update plugins/replication from branch 'stable-3.1'
to 0995fe0445f507279c05cb5ee60a9413671be400
- Don't check read permission when authgroup isn't set
It's unnecessary to check read permission when authGroup isn't set since
the then the user is a RemoteSiteUser that is-an InternalUser that has
read access to everything.
Change-Id: Ie6985250b0acb50c08fdcae75cc608222b1add35
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
By default terser keeps all licensing comments as many licenses require
you to keep a copy of the license in redistributed source: [1]
--comments [filter] Preserve copyright comments in the output. By
default this works like Google Closure, keeping
JSDoc-style comments that contain "@license" or
"@preserve". You can optionally pass one of the
following arguments to this flag:
- "all" to keep all comments
- `false` to omit comments in the output
- a valid JS RegExp like `/foo/` or `/^!/` to
keep only matching comments.
Note that currently not *all* comments can be
kept when compression is on, because of dead
code removal or cascading statements into
sequences.
In minified gr-app.js version we don't need to preserve license
information and can remove it. This saves ca. 300KB in gr-app.js size.
[1] https://github.com/terser/terser
Bug: Issue 13870
Change-Id: I2736879d252994200ad2f52e414e224ebe56b65d
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
When a project has multiple submit rules, which produce
multiple submit records, the 'is:submittable' query stops
working as the documentation indicates it should. Rather
than returning changes that are ready to be submitted,
it returns any change where at least one submit record
is OK, despite the overall change not being submittable.
For example, with the code-owners plugin, which uses
a java-based submit rule, 'is:submittable' will return
changes that are passing owners checks, but might
have CodeReview:-2 or Verified:-1.
For projects with a single submit rule, the behavior
is exactly the same as before, since we simply check
that *any* of the submit records is OK, exactly as before,
AND that *none* of them are NOT_READY or RULE_ERROR.
Bug: Issue 13884
Change-Id: I4878ce13c6673852916d6891253d5e62b46f3db5
|
| | |_|/
|/| |
| | |
| | |
| | |
| | |
| | |
| | | |
This is a follow-up of Ifc83162780. Avoid using secondary index also
in readChangesForReplace() because the project attribute is always
available.
Change-Id: I9d0cc632d24a631c128715b79f7a620da99f61eb
|
| | | |
| | |
| | |
| | | |
Change-Id: I6efd9b606390b83dd524301cc53115b79814cfdb
|
| | | |
| | |
| | |
| | | |
Change-Id: Ieece59a90de73b4ae138f0b387e8b8f23173a299
|
| |\| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* stable-3.2:
Set version to 3.2.7-SNAPSHOT
Set version to 3.2.6
Set version to 3.1.12-SNAPSHOT
Set version to 3.1.11
Fix httpcore dependency needed by httpclient
Revert "Add support for Elasticsearch version 7.9.*"
Revert "Add support for Elasticsearch version 7.10.*"
Change-Id: I5f4d056da058089cc65a4dab93dc6d1da4aded51
|
