summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Upgrade to gwtorm 1.0.1v2.0.1Shawn O. Pearce2009-02-021-1/+1
| | | | | | | This brings in bug fixes related to Key object's fromString not decoding enough steps before returning the data to the application. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Fix a minor formatting glitch in ContactPanelShawn O. Pearce2009-01-301-2/+2
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Enable the Save button on contacts panel when the email is modifiedShawn O. Pearce2009-01-301-0/+2
| | | | | | | If the user modifies their preferred email address, enable the save button so that they can actually save the change. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Display all open changes for a single projectShawn O. Pearce2009-01-3015-3/+177
| | | | | | | | | Change tables now display a hyperlink to view all open changes for that project, browsing them in the same order that the all open changes for the entire site would navigate them in. Bug: GERRIT-32 Signed-off-by: Shawn O. Pearce <sop@google.com>
* Generate "permalink" style new change links during receiveShawn O. Pearce2009-01-301-1/+1
| | | | | | | | | | | | | | | This style of link is better suited to copy and pasting into a longer term repository, like a bug tracking system. I keep finding myself copying change ids from Gerrit into Gerrit's own issue tracker, but I edit them by hand to be permalink style. Using that in the output just makes it easier on me and everyone else. I highly doubt the speed improvement of using the anchor form is a major issue for us, users copying links from a terminal are likely going to be opening a new browser tab/window for the link rather than recycling one that already has Gerrit open. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Gracefully handle unknown host exceptions during OpenID discoveryShawn O. Pearce2009-01-301-1/+11
| | | | | | | | | | We don't need these errors in our application server log. If the client has given us a hostname we can't resolve, trap the error and return an invalid discovery JSON payload to them instead. The user will see a message explaining its an unsupported/invalid URL and can try again. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Don't create editors in the line number column of a side-by-site diffShawn O. Pearce2009-01-301-2/+6
| | | | | | | Its horrible to construct an editor into the line number column; it completely throws off the UI layout of the entire window. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Ensure #mine signs-in the user if they aren't logged in yetShawn O. Pearce2009-01-291-0/+6
| | | | | | | Otherwise the dashboard is empty, and it looks stupid. Bug: GERRIT-49 Signed-off-by: Shawn O. Pearce <sop@google.com>
* Allow users to hide the site header if they want toShawn O. Pearce2009-01-298-3/+80
| | | | | | | | | | | Some users may want to automatically hide the site header/footer assets upon sign-in, as they might take up a lot of screen space. For example, the site header at http://review.source.android.com/ is 86 pixels tall. Bug: GERRIT-45 Signed-off-by: Shawn O. Pearce <sop@google.com>
* Don't log errors about CLAs in the server log during uploadsShawn O. Pearce2009-01-292-12/+25
| | | | | | | | | The server administrator really doesn't care about the text we are showing to the end-user to let them know the CLA is missing or expired. Bug: GERRIT-53 Signed-off-by: Shawn O. Pearce <sop@google.com>
* Silence org.apache.sshd.common debug messagesShawn O. Pearce2009-01-291-1/+1
| | | | | | | | | | | Messages like: 2009-01-28 13:21:56,884::DEBUG: org.apache.sshd.common.channel.Window - Increase server local window by 262263 up to 2088960 aren't that interesting to the server administrator. Bug: GERRIT-52 Signed-off-by: Shawn O. Pearce <sop@google.com>
* Display git pull download URLs on patch setsShawn O. Pearce2009-01-2911-8/+159
| | | | | | | | | | | | | | This change shows "git pull ..." command lines for fetching a patch set down off Gerrit using standard Git tools, rather than relying upon the "repo download" command. It also makes the usage of "repo download" more optional by not showing the repo download command line by default. If a project is not readable by anonymous users then we offer an SSH URL instead of an anonymous git:// URL. Bug: GERRIT-55 Signed-off-by: Shawn O. Pearce <sop@google.com>
* Fix typo in javadoc comment of SystemConfigShawn O. Pearce2009-01-291-1/+1
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Remove comment about sorting change dependenciesShawn O. Pearce2009-01-291-1/+0
| | | | | | | | Sorting by the quite stable change id is reasonable. On current Gerrit2 systems its sequential, due to having a single sequence generator assigning change ids in order. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Include X-Gerrit-ChangeId, X-Gerrit-Commit headers in emailsShawn O. Pearce2009-01-291-0/+14
| | | | | | | | | This may help automation tools to know the change id and the git commit associated with the message, without needing to run off to the Gerrit server's JSON interface, or rip apart the X-Change-URL header to obtain the id component from it. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Don't put the message type into the list id, it breaks threadingShawn O. Pearce2009-01-291-4/+8
| | | | | | | | | | | | | | | GMail (and probably a lot of other email clients) break a thread if the List-ID differs between the original message and any type of reply to that original message. This causes comments made on a change to come up in a different thread than the original notice message, which makes it harder to organize. We now put the message type into an X-Gerrit-MessageType header, in case a client wants to filter on it, and thus way we can keep the List-ID constant throughout the "thread". Bug: GERRIT-57 Signed-off-by: Shawn O. Pearce <sop@google.com>
* Don't auto-approve changes when they are uploadedShawn O. Pearce2009-01-291-28/+1
| | | | | | | | | | | The entire point of the code review systems is to have another party beyond the uploader review the changes to determine they are suitable for inclusion, and set the approval bits onto the change record. Automatically approving your own changes reduces the value of this 3rd party review. Bug: GERRIT-56 Signed-off-by: Shawn O. Pearce <sop@google.com>
* Insert two LFs after the approvals in a change messageShawn O. Pearce2009-01-291-1/+1
| | | | | | | | This way its formatted as a paragraph in both email clients and the web UI, which makes it look a lot nicer. Bug: GERRIT-58 Signed-off-by: Shawn O. Pearce <sop@google.com>
* Fix the subject column in change tables to truncate when too longShawn O. Pearce2009-01-291-1/+1
| | | | | | | | | | Because the text is actually inside a gwt Hyperlink object its down inside of a div, not the td directly. We need to apply the font controls onto the div, otherwise the div overrides them and we don't get the change subject to truncate nicely when its too long for the available screen space. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Add user level documentation to the main indexShawn O. Pearce2009-01-291-0/+7
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Fix the "Issues" hyperlink in the main indexShawn O. Pearce2009-01-291-1/+1
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Add user level documentation about how to upload changes over SSHShawn O. Pearce2009-01-291-0/+319
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Move documentation to gerrit.googlecode.com websiteShawn O. Pearce2009-01-294-65/+26
| | | | | | | | This makes it easier to store multiple editions of the documentation for Gerrit 2.0, 2.1, and so on. Google AppEngine has a 1,000 file limit, so storing more than a few editions online would be difficult. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Add SSH command "gerrit ls-projects" to show all visible projectsShawn O. Pearce2009-01-282-0/+67
| | | | | | | | | | | | | | This command evaluates through all known projects and outputs their name, one per line, if the current user account has Read access to that project. Its mostly useful for scripting applications such as mirroring what you can see: for p in $(ssh -p 29418 host gerrit ls-projects) do git clone git://mirror/$p.git done Signed-off-by: Shawn O. Pearce <sop@google.com>
* Refactor the project right tests in SSH commands to be more availableShawn O. Pearce2009-01-282-8/+25
| | | | | | | | This way we can add more commands to the SSH library and let them access the account group data for the current user, as well as test the user's access rights against projects. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Fix appjar POM to always ensure GerritVersion.properties is currentShawn O. Pearce2009-01-271-1/+1
| | | | | | | | The process-classes phase is too late in the lifecycle, Maven may have already embedded our old properties file with some previous version number in it. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Never all an approval category function to be nullShawn O. Pearce2009-01-271-1/+3
| | | | | | | If we do, we get null pointer exceptions while trying to evaluate the rules. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Add new project rights to allow direct branch updates over SSHShawn O. Pearce2009-01-274-3/+222
| | | | | | | | | | | | | | | | | Four new rights can be used to control access over the SSH server: * Push Annotated Tag (refs/tags/*) * Push Branch: (refs/heads/*) - Update Existing - Create New - Force Update (aka non-fast forward) ; Delete These can be granted on a per-group/per-project basis to permit users to remotely control branches over the Git SSH interface. Its mostly useful for groups that are used to having a standard Git server, where "anything goes" is permitted within the scope of the project. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Fix category value initialization to use the category's transactionShawn O. Pearce2009-01-271-4/+4
| | | | | | | I missed the ", txn" on each of these insert calls, allowing the category to possibly create without its range of values. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Refactor read access testing to reuse for other function typesShawn O. Pearce2009-01-272-8/+24
| | | | | | | | This paves the way for Git based SSH commands operating on a project to test other types of approval categories beyond the basic "READ" category used for coarse-grained access controls. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Push deletes to replicated repositories rather than failShawn O. Pearce2009-01-271-1/+4
| | | | | | | | | If a ref has been removed from the local repository but is in the push queue, the caller wants to remove it from the local repository and also from the replicated remotes. Rather than crash out with an IOException we now push the delete request. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Ensure all of our *.gwt.xml files are in the classpathShawn O. Pearce2009-01-271-1/+1
| | | | | | | Earlier I added UserAgent.gwt.xml but failed to ensure it would show up in the JAR produced by Maven. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Don't use <iframe> for sign-in on a mobile deviceShawn O. Pearce2009-01-273-11/+62
| | | | | | | | Trying to use the <iframe> based sign-in on an Android or an iPhone/iPod mobile device is very difficult. The total screen space is just too small to float the window onto. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Honor the claimed identity, not the delegateShawn O. Pearce2009-01-271-6/+6
| | | | | | | Users who login with a delegate OpenID want to record their claimed identity, not their delegate identity. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Fix Google Analytics page tracking example in documentationShawn O. Pearce2009-01-273-2/+28
| | | | | | | | Google Analytics won't track the anchor of a page, so we need to do a search-replace for '#' with '/', which is something that it will track. Thus tracked URLs would be "/Gerrit/change,1". Signed-off-by: Shawn O. Pearce <sop@google.com>
* Upgrade to gwtjsonrpc 1.0.1 to fix encoding issuesShawn O. Pearce2009-01-271-1/+1
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Remove unnecessary inherits of I18N moduleShawn O. Pearce2009-01-271-1/+0
| | | | | | This is automatically imported by the stock GWT User module. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Line wrap the side by side tables at 100 columnsShawn O. Pearce2009-01-273-10/+58
| | | | | | | | | | | | Excessively long lines force the file to be very hard to read in a side-by-side presentation as it makes one (or both) columns too wide for many common display devices, especially laptops. Forcing our own line wrapping at some reasonable limit (e.g. 100) ensures that even if the project's style standards permit very long lines the page is still at least readable on a smaller monitor. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Fix the suggestion service by picking a different max characterShawn O. Pearce2009-01-271-3/+5
| | | | | | | | | | | | | | | Suggestions were failing because PostgreSQL was treating \uffff as smaller than 'a', so we never selected the range of possible candidates and instead always wound up with an empty result set, unless we had the input string exactly equal to some existing record in the query. This max character of \u9fa5 was experimentally determined by loading all characters between \u0001 and \uffff into a single PostgreSQL table, then selecting the one record returned by the query "SELECT x FROM t ORDER BY x DESC LIMIT 1". Signed-off-by: Shawn O. Pearce <sop@google.com>
* Display "Anonymous Coward" in dashboards of users without namesShawn O. Pearce2009-01-271-3/+5
| | | | | | | This is slightly better than showing the name as "undefined", due to the full name field being Java null/JavaScript undefined. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Fix range based query for /r/$commitid redirect URLsShawn O. Pearce2009-01-261-6/+4
| | | | | | | | | Redirect URLs for /r/$commitid were not working correctly if the collate setting for the database is en_US.UTF-8. Using '~' does not produce the correct results as some hex digits may sort after the '~'. Instead use 'z' as this would never be a valid hex digit. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Don't include the footer "--" line in emails if the footer is emptyShawn O. Pearce2009-01-261-2/+2
| | | | | | | | | | | | We should only include the "--\n" line in an email sent from Gerrit if there will be content below that line. Otherwise its just noise and looks out of place in the message. Usually there is content below the line, as the canonical_url is set and thus we can make backlinks to ourselves. But this isn't always the case, so we should format a bit better when it isn't. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Don't render the "To unsubscribe" link in emails if we have no URLShawn O. Pearce2009-01-261-4/+6
| | | | | | | | If we don't have a URL with which to render links back to Gerrit (such as if system_config isn't set with a canonical_url) then we cannot append the settings URL, as it is "null". Signed-off-by: Shawn O. Pearce <sop@google.com>
* Automatically send email when new patch sets are uploadedShawn O. Pearce2009-01-262-53/+119
| | | | | | | | | | This way if a new reviewer was added by the "repo upload" tool they get notification of the change in their inbox. This also gives existing reviewers a "ping" to let them know that the uploader wants them to look at the change again. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Ensure any new reviewers for updated changes see it in their dashboardShawn O. Pearce2009-01-261-5/+18
| | | | | | | | | If a change is updated with a new patch set the caller may have given us additional reviewers to include on that change. Those should be added to the change just like if the change was new, so that those individuals can see the change in their dashboard. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Make newly created changes show up in reviewer dashboardsShawn O. Pearce2009-01-261-2/+11
| | | | | | | | | | | Aside from emailing a reviewer with a change notice we also want to ensure the change is visible in their dashboard, should they just visit the site directly without following a hyperlink. To do this we need to ensure at least one ChangeApproval has been created for the reviewer for this change. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Don't permit the same commit twice on the same changeShawn O. Pearce2009-01-262-0/+13
| | | | | | | | | | Repeated uses of "repo upload --replace" for the same change id and commit, without changing the commit SHA-1, would create more than one patch set with identical content. This is confusing to read and review. Disallowing it simplifies things for any reader. Caused-by: jbq Signed-off-by: Shawn O. Pearce <sop@google.com>
* Don't error out on upload if we are only replacing a patch setShawn O. Pearce2009-01-261-1/+1
| | | | | | | | | | | | | | The "repo upload" client always sends us a refs/for/$branch command, even if the client is only trying to add a new patch set to an already existing change entity. It does so because this simplifies the client logic from needing to handle the case of "replacing everything" vs. "replacing some, creating some". We shouldn't consider it an error if the client didn't ask us to make anything new, but did supply at least one patch set replace to us. Noticed-by: jbq Signed-off-by: Shawn O. Pearce <sop@google.com>
* Restore the 2.0-SNAPSHOT version numberShawn O. Pearce2009-01-264-5/+5
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Document the need to build our dependencies in dev-readme.txtShawn O. Pearce2009-01-261-0/+13
| | | | | | | | We covered this in the Eclipse specific setup, but not in the general setup case. Either way you need to make sure these packages are installed into your local Maven repository. Signed-off-by: Shawn O. Pearce <sop@google.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-14 00:25:53 +0000