summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* gerrit 2.0.12v2.0.12Shawn O. Pearce2009-05-181-1/+1
|
* Switch to tagged gwtexpui, gwtjsonrpc, gwtormShawn O. Pearce2009-05-181-3/+3
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Make escape in the search box abort the searchShawn O. Pearce2009-05-181-2/+8
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Add global jump navigation keys for the main menuShawn O. Pearce2009-05-184-0/+85
| | | | | | | | Most of the locations available on the main menu are now supported by 'g' then some other key. This is stolen from GMail's UI, where the combinations work well for keyboard centric navigation. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Minor cleanup to Gerrit module bootstrap code pathShawn O. Pearce2009-05-181-10/+7
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Automatically reposition/resize file browser if window changesShawn O. Pearce2009-05-181-5/+35
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Ensure the row pointer is visible before moving itShawn O. Pearce2009-05-182-0/+40
| | | | | | | | | If the user has manually scrolled the window by way of the scrollbar, when they push j/k to move the pointer we should reposition it onto the current viewport first, so the window stays roughly where the user has positioned it. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Move the comment editor actions into their own keyboard shortcut groupShawn O. Pearce2009-05-183-3/+25
| | | | | | The help text reads better this way. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Switch to gwtjsonrpc's new Handler based status update APIShawn O. Pearce2009-05-182-5/+13
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Use 'f' in a patch to browse the list of files in the patch setShawn O. Pearce2009-05-1620-132/+337
| | | | | | | | | | When the user presses 'f' inside of a patch viewer we now open up the list of patches from the same patch set, and let the user move through them with the keyboard. Selecting a file opens it in the viewer, but leaves the dialog open until they trigger it to close. Bug: GERRIT-136 Signed-off-by: Shawn O. Pearce <sop@google.com>
* Make n/p only honor comments on file adds/deletesShawn O. Pearce2009-05-163-1/+4
| | | | | | | | If there is exactly one edit region for the file, such as what happens when the file is added to the project, make n/p only match on comments as these are much more interesting. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Fix unused import in PatchScreenShawn O. Pearce2009-05-161-1/+0
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Switch all hyperlinks to be InlineHyperlinkShawn O. Pearce2009-05-164-14/+6
| | | | | | | | | This avoids an unnecessary <div> wrapper around the link element, saving a bit of DOM memory usage. We also really didn't want to see the block display format from the <div> and were overriding it with CSS. Its easier if its just not there. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Stop generating raw #target anchor tagsShawn O. Pearce2009-05-164-67/+76
| | | | | | | | These don't work well on MSIE 6, where we need to use History.newItem to ensure that the history system works correctly. Bug: GERRIT-86 Signed-off-by: Shawn O. Pearce <sop@google.com>
* Honor GWT 1.6's handleAsClick logic in DirectScreenLinkShawn O. Pearce2009-05-162-2/+4
| | | | | | | Since we completely override the Hyperlink code we should match whatever the core GWT version would do here. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Implement n/p keys to jump to next/previous diff chunk or commentShawn O. Pearce2009-05-165-1/+144
| | | | | | | | | In a large file displayed with context = Whole File these keyboard keys can be very useful to locate the next hunk or prior hunk and jump immediately to them. Bug: GERRIT-136 Signed-off-by: Shawn O. Pearce <sop@google.com>
* Fix all onLoad, onUnload methods to be protected access onlyShawn O. Pearce2009-05-1625-29/+29
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Change sign out handler to use GWT's HandlerManager supportShawn O. Pearce2009-05-167-73/+128
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Cleanup the name of the search focus key registrationShawn O. Pearce2009-05-161-6/+6
| | | | | | This is more consistent with the names we use in NavigationTable. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Put the "Use '?' for keyboard help" ahead of the versionShawn O. Pearce2009-05-161-4/+5
| | | | | | | | Users are more likely to be interested in this information than they are in the exact client version they are running, or the link back to our project site and documentation. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Clarify what the "known hosts entry" isShawn O. Pearce2009-05-162-2/+3
| | | | | | We now poing the user at the file the entry goes in. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Sort the RSA host key before the DSA host keyShawn O. Pearce2009-05-161-2/+26
| | | | | | | | | | The OpenSSH client appears to prefer the RSA host key if it is available from the server when updating ~/.ssh/known_hosts, so we should display that first if there are multiple keys, as it is what the end-user would likely try to match the fingerprint against when doing a visual key comparsion. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Allow users to control the number of results per pageShawn O. Pearce2009-05-169-22/+86
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Add keyboard bindings n/p for all change lists to paginateShawn O. Pearce2009-05-163-7/+37
| | | | | | | | | This makes it easier to browse through a very long list of changes, as you can use the keyboard keys n to move to the next page and p to move to the prior, along with the existing j/k/o to move around within the page, and open a record. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Allow users to disable clippy the flash movie if they don't like itShawn O. Pearce2009-05-167-6/+46
| | | | | | | | | | | | | I've found that although clippy is useful, it slows down the page rendering as the Flash plugin has to initialize on the host page every time we change the text we want to permit copying. It also doesn't work on every operating where flash is supported. Since CopyableLabel already supports some JavaScript based support we can just give the user a preference to turn off the flash UI, and fallback on the pure JavaScript based code. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Refactor account preferences modelShawn O. Pearce2009-05-1612-130/+192
| | | | | | | | | | | By breaking the account preferences into their own object we can offer a settings screen that does only one RPC to change any of the settings, updating them all en-mass on the server side. It makes it easier to add new settings to the code, because we will only need to modify the database and the model, and not the RPC interfaces or their service implementations. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Move the watched project list to its own tab in settingsShawn O. Pearce2009-05-164-20/+9
| | | | | | | This table can get rather large, and has little to do with the other user preferences on the main preferences tab. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Refactor how user preferences are applied to the UIShawn O. Pearce2009-05-162-4/+6
| | | | | | | We only need to update the show site header/footer once during module startup, after which point the menu bar can be left alone. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Remove pointless GWT.isClient calls in Gerrit moduleShawn O. Pearce2009-05-161-2/+2
| | | | | | | | The module entry point only runs on the client, and this code is about building the top menu bar for the client UI. The call is always true, and is just confusing to read in context. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Remove dead LoginService, SignInResult classesShawn O. Pearce2009-05-163-81/+0
| | | | | | | These were effectively killed when we changed the OpenID login process to use the main window, rather than an iframe. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Fix LinkMenuItem blur on older browsersShawn O. Pearce2009-05-161-3/+2
| | | | | | | We can't use FocusImpl because it assumes the blur should be on the first child of the anchor element, and the anchor has no child. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Blur menu item hyperlinks on activationShawn O. Pearce2009-05-162-1/+21
| | | | | | | This way the enter key is generally available for use as a navigation key, rather than triggering the last menu item you activated. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Fix warning about debug code in OpenIdServiceImplShawn O. Pearce2009-05-161-8/+13
| | | | | | | | | This code is here only for aid while debugging an OpenID exchange, which doesn't happen that often. Pulling it out to an isolated method and tagging it to ignore unchecked casts fixes a warning in this class. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Fix warnings about potential serialization problemsShawn O. Pearce2009-05-1661-1/+112
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Remove dead code, these aren't used anymoreShawn O. Pearce2009-05-163-7/+0
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Remove unnecessary warning supressionsShawn O. Pearce2009-05-151-2/+0
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Detect cases where system_config has too many rowsShawn O. Pearce2009-05-151-1/+12
| | | | | | | | | | Sometimes when setting up a new server a user can find a way to insert multiple rows into the system_config table. Instead of honoring one of them seemingly at ranodm (and ignoring the other rows that may have critical data in them) we now abort at startup with a description of the problem. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Always use NpTextBox or NpTextArea to prevent GlobalKey eventsShawn O. Pearce2009-05-1515-70/+64
| | | | | | | | Otherwise keystrokes like '/' or '?' in a text area register as actions in the global key event system, rather than as just input into the currently focused text box. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Rewrite the keyboard event handlers to use new GlobalKey moduleShawn O. Pearce2009-05-1540-828/+704
| | | | | | | | We now can show a screen describing the keyboard shortcuts, but we also have bindings that work everywhere, including the most difficult WebKit based browsers. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Delete dead CSS bundle codeShawn O. Pearce2009-05-152-65/+0
| | | | | | This was replaced when we switched to gwtexpui's CSS linker. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Fix change permalinks after breaking them during GWT 1.6 upgradeShawn O. Pearce2009-05-152-2/+2
| | | | | | | We have to use HostPageBaseURL here, not ModuleBaseURL, as the link is relative to the host page ('/16') and not the module ('/gerrit/16'). Signed-off-by: Shawn O. Pearce <sop@google.com>
* Put the link to the review inside the body instead of the signature.Cedric Beust2009-05-151-35/+26
| | | | Allow Gerrit to send email even in GWT hosted mode (the javax.mail.Session is apparently not necessary to create a MimeMessage).
* Actually deregister a command when it exitsShawn O. Pearce2009-05-141-1/+1
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Add a search box to quickly locate changes by change numberShawn O. Pearce2009-05-145-2/+123
| | | | | Bug: GERRIT-27 Signed-off-by: Shawn O. Pearce <sop@google.com>
* Replace the top menu bar with a tab panel and linksShawn O. Pearce2009-05-147-111/+171
| | | | | | | This removes the need for an implicit FocusPanel from the GWT library, but still allows the user to implement keyboard navigation. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Describe MySQL and H2 setup in jetty_gerrit.xml templateShawn O. Pearce2009-05-141-4/+14
| | | | | | | This makes it easier to configure Gerrit for MySQL or H2 database backends, if one of those is preferred by the end user. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Add admin command 'gerrit show-connections'Shawn O. Pearce2009-05-145-1/+181
| | | | | | | | | | | | | | | | | | | This command displays the current connection table within the SSH daemon, including connection start time, idle time, user name, IP address, and active command(s) running on that one connection. For example, Start Idle User Remote Host -------------------------------------------------------------- 12:21:17 00:00:01 sop my.laptop.dhcp.example.com [ git-upload-pack '/kernel/msm.git' ] 12:21:19 00:00:00 sop localhost [ gerrit-show-connections ] -- Signed-off-by: Shawn O. Pearce <sop@google.com>
* Enable SSH daemon cipher and MAC configurationShawn O. Pearce2009-05-142-11/+103
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Honor sshd.tcpKeepAlive for TCP keep alive controlsShawn O. Pearce2009-05-142-3/+18
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Bind our SSH daemon with SO_REUSEADDRShawn O. Pearce2009-05-143-53/+184
| | | | | | | | | | | | | This permits the daemon to come up even if there are connections stuck in TIME_WAIT or FIN_WAIT2 status within the kernel, which may happen on a busy server if the daemon is brought down and back up again quickly. Its potentially risky that you could run two Gerrit daemons on the same host on the same port and not realize it, so we'll just have to trust the administrator to not do this. Bug: GERRIT-164 Signed-off-by: Shawn O. Pearce <sop@google.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-07 00:47:40 +0000