summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* gerrit 2.0.13v2.0.13Shawn O. Pearce2009-06-021-1/+1
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Disable AES192CBC and AES256CBC if unlimited cryptography is missingShawn O. Pearce2009-06-021-4/+30
| | | | | | | | | | | If the JVM is missing the unlimited cryptography extension, we are unable to use the AES-192 and AES-256 key sizes. Don't install them in the server, as the server can't support them if a client requests it. Instead we log a warning to the server log, so the admin can troubleshoot the problem if they really require AES-192 or AES-256 for their organization's Gerrit installation. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Use mvn -offline mode when running ./to_hosted.shShawn O. Pearce2009-06-021-1/+1
| | | | | | | | | If we are setting up an area for the hosted development environment we probably are just switching from a normal target build to the weird hosted mode debugging. Rather than blocking on updates for plugins and so forth, just rely on what is in our repository. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Add sendemail.enable to disable email outputShawn O. Pearce2009-06-025-3/+42
| | | | | | | | | | | Some installations might be unable to connect to a SMTP relay, but are still useful through the web page UI, provided that reviewers check their dashboard periodically. In such cases we can't open a socket to a SMTP server, so we should bypass any email sending code paths to prevent errors from filling up the server logs. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Use gwtorm, gwtexpui 1.1.1 final versionsShawn O. Pearce2009-06-021-2/+2
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Automatically switch from empty side-by-side to unified viewShawn O. Pearce2009-06-011-5/+21
| | | | | | | | | | If the user visits a sidebyside view location, but we come up with no file hunks to display (e.g. because it really is binary) then we switch them to the unified viewer, which can show the headers from the diff. Bug: GERRIT-193 Signed-off-by: Shawn O. Pearce <sop@google.com>
* Block rcpt to addresses not on a whitelistShawn O. Pearce2009-06-013-0/+58
| | | | | | | | | This way test instances don't send spam emails, but also companies can configure the whitelist to contain only their corporate domain name and potentially avoid distributing emails outside of their corporate firewall. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Fix StackOverflowError during cherry-pick submitShawn O. Pearce2009-06-011-7/+29
| | | | | | | | | | | | | Using a regex pattern of "^(\n|.)*\n..." causes the Java regex package to recurse for each consideration of the first alternation, creating a very deep stack for a relatively short commit message. If the message is large enough, the thread stack overflows, and an exception is thrown. Instead we use a more customized parser, to examine the message end and determine if an LF should be appended, or not. Bug: GERRIT-207 Signed-off-by: Shawn O. Pearce <sop@google.com>
* Fix CSS styling on the history tableShawn O. Pearce2009-06-011-2/+1
| | | | | Bug: GERRIT-196 Signed-off-by: Shawn O. Pearce <sop@google.com>
* Document where the nextval_project_id function is for MySQLShawn O. Pearce2009-06-011-2/+2
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Switch from Java Mail to Apache Commons NET basic SMTP clientShawn O. Pearce2009-06-0128-304/+723
| | | | | | | | | | | | This removes the dependency on the encumbered Java Mail client made by Sun Microsystems, and replaces it with a very simple SMTP library under the Apache License. Configuration for the email client is now set in gerrit.config, by the same properties that "git send-email" would honor. Unfortunately we don't support TLS/SSL as a result of this move. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Move git_base_path to gerrit.configShawn O. Pearce2009-06-019-23/+30
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Move canonical_url, git_daemon_url to gerrit.configShawn O. Pearce2009-06-016-44/+44
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Move use_repo_download to gerrit.configShawn O. Pearce2009-06-015-13/+20
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Move gitwebUrl to gerrit.configShawn O. Pearce2009-06-016-32/+35
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Move authentication fields from system_config to gerrit.configShawn O. Pearce2009-06-016-166/+178
| | | | | | | The login type, login http header, email format and Google Account upgrade flags are now specified in gerrit.config. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Move gerrit_git_email,gerrit_git_name to gerrit.configShawn O. Pearce2009-06-015-39/+38
| | | | | | | Now we use user.name, user.email, and auto-detect the committer like git would normally do. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Move contact store configuration to gerrit.configShawn O. Pearce2009-06-016-98/+111
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Create a utility to export system_config to gerrit.configShawn O. Pearce2009-06-015-8/+97
| | | | | | | | | | This tool can be used to help an admin convert their system settings data over to the new format. Currently only sshd_port has been moved to sshd.listenAddress so that is the only property moved by the tool. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Create GerritConfig after parsing gerrit.config fileShawn O. Pearce2009-06-011-2/+7
| | | | | | Otherwise we may not have all of the property values we need. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Don't start background queues during command line toolsShawn O. Pearce2009-06-013-5/+12
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Delete now unnecessary ImportProjectSubmitTypesShawn O. Pearce2009-06-011-89/+0
| | | | | | | | | | | | | This was created for Gerrit 2.0.9 to support moving per-project configuration out of the project's ~/.git/config into the db, where it was more easily edited by the web UI. Since the per-project configuration was previously a hidden and undocumented feature, its likely nobody else used it except for me on review.source.android.com, and anyone who has used it has already upgraded past 2.0.9. So this is just dead code now. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Move sshd_port to gerrit.config as sshd.listenaddressShawn O. Pearce2009-05-3012-86/+269
| | | | | | | | | We now support not only the port to listen on, but also the IP address (or addresses) the daemon should listen on. This may help sites which host multiple installations on one system, by binding each SSHD onto a logical IP address. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Make SSH host key loading more consistent over timeShawn O. Pearce2009-05-302-11/+34
| | | | | | | | | | | | | | If the site starts out with a Java formatted "ssh_host_key" file, but later installs BouncyCastle Crypto, we should continue to use its existing Java formatted host key, to prevent needing to do a host key change. Only one host key (RSA or DSA) is actually required to load the server and make it functional for clients. Rather than try to require both keys at server startup we only load ones which are available on disk. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Allow MINA SSHD to log about host key creationShawn O. Pearce2009-05-301-0/+1
| | | | | | | | | If there is a problem writing the generated host key to disk, MINA logs it at level INFO. We should allow those messages, otherwise the administrator might not know about a problem. Bug: GERRIT-210 Signed-off-by: Shawn O. Pearce <sop@google.com>
* Add Next/Previous/Up links to the PatchScreenCedric Beust2009-05-308-50/+196
| | | | | | | | The main change is that PatchScreen now receives the list of all the file keys in this patch set instead of just the one that is being reviewed. Bug: GERRIT-59
* Remove spurious whitespace from blank lines in diff viewsShawn O. Pearce2009-05-292-24/+4
| | | | | | | | | | | We shouldn't put an &nbsp; entity into the line if the line is empty, as it shows a space when the user tries to select the line text. In theory I had put these here to preserve the line height, but that is already taken care of for us by the line numbers which appear in the same table row, using the same font. Bug: GERRIT-211 Signed-off-by: Shawn O. Pearce <sop@google.com>
* Document the other standard cachesShawn O. Pearce2009-05-281-0/+24
| | | | | | | Although not yet supported in Ehcache, at least they are now documented for use in `gerrit flush-caches` calls. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Put a link back to the index in every page footerShawn O. Pearce2009-05-2823-0/+94
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Document all server side command line toolsShawn O. Pearce2009-05-2811-8/+528
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Fix NPE in "gerrit replicate --all"Shawn O. Pearce2009-05-281-1/+2
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Mention 'git receive-pack' --cc/--reviewer argsShawn O. Pearce2009-05-281-3/+3
| | | | | | | | Since we switched to args4j for our parsing these options are available on both 'git receive-pack' and 'gerrit receive-pack'. We might as well just talk about it on 'git receive-pack' in the documentation. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Remove references in documentation to My>SettingsShawn O. Pearce2009-05-281-6/+6
| | | | | | | This item no longer exists in the menus. The Settings link is only in the right hand area of the menu bar. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Use gwtorm 1.1.1-SNAPSHOTShawn O. Pearce2009-05-281-1/+1
| | | | | | | | For MySQL in GMT+10 timezones we need to not supply a phony default value for TIMESTAMP columns in the database. gwtorm 1.1.1 has removed those defaults. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Schedule replication by remote, not by projectShawn O. Pearce2009-05-284-66/+85
| | | | | | | | | | | | We now create a thread pool for each [remote] block found inside of replication.config. All URLs within that remote block share the same pool of worker threads. By defining different remote blocks for each URL the administrator is able to isolate slow WAN links from faster local warm-spares, ensuring that the more local systems are able to stay current, even if the WAN gets really far behind. Bug: GERRIT-200 Signed-off-by: Shawn O. Pearce <sop@google.com>
* Use a HashSet for the active tasks, rather than a ListShawn O. Pearce2009-05-281-1/+3
| | | | | | | | We add and remove frequently, usually on a small number of items, the set should tend to perform better in terms of avoiding moving around the other active items in the list. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Fix treatment of symbolic refs in PushOpShawn O. Pearce2009-05-271-2/+2
| | | | | | | | | We need to use the symbolic ref name when mirroring, as we flatten it out to a normal ref on the remote site. This prevents cases where we needed to push both "HEAD" and "refs/heads/master" as the former was a symbolic-ref to the latter. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Allow replication.config to drive the thread pool largerShawn O. Pearce2009-05-272-2/+12
| | | | | | | | | We should (ideally) have a worker thread for each destination we will replicate too. This permits the thread pool to spawn each PushOp around on the threads, so the pushes get run in parallel and don't wind up going sequentially. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Correct the defaults for remote uploadpack, receivepackShawn O. Pearce2009-05-271-4/+2
| | | | | | | We still use the hypenated form, as that is what JGit is doing underneath for its defaults. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Document that remote.<name>.uploadpack is also supportedShawn O. Pearce2009-05-271-0/+8
| | | | | | | Now that sync everything tries to use what is effectively ls-remote to view the remote side refs, we have to do this here. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Don't attempt to replicate the magic "-- All Projects --"Shawn O. Pearce2009-05-271-1/+4
| | | | Signed-off-by: Shawn O. Pearce <sop@google.com>
* Allow replication to match only some hostsShawn O. Pearce2009-05-273-12/+40
| | | | | | | | | By supporting substring matches on URLs during "gerrit replicate" an administrator can reforce replication to a single remote system after network connectivity with that system is known to be working. Bug: GERRIT-110 Signed-off-by: Shawn O. Pearce <sop@google.com>
* Automatically replicate all projects at startupShawn O. Pearce2009-05-271-0/+5
| | | | | | | | | | | If replication is enabled, schedule all projects for replication when the daemon starts. This way if there is any inconsistency between the local repository and the remotes, it is fixed during startup. We can find such cases when a delayed push never finished, because the server was shutdown while it was still sleeping in the pending queue. Bug: GERRIT-110 Signed-off-by: Shawn O. Pearce <sop@google.com>
* Add remote.<name>.replicationdelay to control delayShawn O. Pearce2009-05-272-32/+61
| | | | | | | This way administrators can set the delay for farther away remotes to be longer, and for really close remotes to be much shorter. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Add admin command "gerrit replicate" to force resync a projectShawn O. Pearce2009-05-275-60/+309
| | | | | | | | | | This can be useful to force a project to resync, such as after detecting a mirror failure and the mirror has been recovered, or if a ref was deleted from the main project by hand, and it must be delivered to the mirrors. Bug: GERRIT-110 Signed-off-by: Shawn O. Pearce <sop@google.com>
* Move the per-command ReviewDb handle up to AbstractCommand base classShawn O. Pearce2009-05-272-20/+18
| | | | | | | This way administrative commands can also use this feature to manage their own database connection, without having to copy the code over. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Reload the submit queue on startup with a 15 second delayShawn O. Pearce2009-05-271-1/+1
| | | | | | | | | This gives the rest of the Gerrit server to come online before we start hammering the thread pool with a potentially expensive to perform task (searching the database for outstanding merges, and spinning up workers to perform them). Signed-off-by: Shawn O. Pearce <sop@google.com>
* Add "gerrit show-queue" to display the work queueShawn O. Pearce2009-05-275-2/+142
| | | | | | | The task work queue is everything gerrit needs to do in the background, via some work threads. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Refactor WorkQueue to support task inspectionShawn O. Pearce2009-05-271-6/+189
| | | | | | | | | By extending the ScheduledThreadPoolExecutor we are able to apply a decoration to the tasks before they are added to the queue, giving us the ability to pull them out at a later point in time and get any data we want, in particular, the input Runnable. Signed-off-by: Shawn O. Pearce <sop@google.com>
* Refactor PushQueue.scheduleUpdate to be smaller methodsShawn O. Pearce2009-05-271-12/+16
| | | | | | | Its a lot easier to follow what happens here by using small, self contained methods with clear return types and responsibilities. Signed-off-by: Shawn O. Pearce <sop@google.com>